On Thursday, December 11, 2014 06:12:47 PM Ian Romanick wrote:
> On 12/11/2014 02:34 PM, Eduardo Lima Mitev wrote:
> > From: Samuel Iglesias Gonsalvez
> >
> > Return the proper value for two-dimensional array texture and
> > three-dimensional textures.
> >
> > From OpenGL ES 3.0 spec, chapter 6.
On 11/12/14 22:02, Brian Paul wrote:
On 12/11/2014 02:51 PM, Carl Worth wrote:
From: Kristian Høgsberg
The upcoming shader cache uses the SHA-1 algorithm for cryptographic
naming. These new mesa_sha1 functions are implemented with the nettle
library.
---
This patch is another in support of my
Hi,
SHA1 is easy to implement. If you want an always-working backup, I
have a couple of C versions I wrote myself. Libraries are only
interesting if they offer significant speedups through cpu-dependance.
Especially since the shader cache is not in the happy fun land of
hardware-based attacks
On Thu, 2014-12-11 at 18:10 -0800, Ian Romanick wrote:
> On 12/11/2014 02:34 PM, Eduardo Lima Mitev wrote:
> > From: Iago Toral Quiroga
> >
> > From the OpenGL ES3 spec:
> >
> > "9.4. FRAMEBUFFER COMPLETENESS
> > ...
> > Depth and stencil attachments, if present, are the same image.
> > ...
>
GCC >=3.3 has been required since 9aa3aa71386394725ce88df463d6183f62777ee5
Signed-off-by: Timothy Arceri
---
include/c99/stdbool.h | 3 +--
include/c99_compat.h | 6 +-
src/glx/dri_common.h | 2 +-
3 files changed, 3 insertions(+), 8 deletions(-)
diff --git a/include/c99/stdbool.h b/inclu
Signed-off-by: Timothy Arceri
---
src/mesa/main/compiler.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/mesa/main/compiler.h b/src/mesa/main/compiler.h
index 34671dc..cdc843d 100644
--- a/src/mesa/main/compiler.h
+++ b/src/mesa/main/compiler.h
@@ -122,7 +122,7 @@ extern
Signed-off-by: Timothy Arceri
---
Its been just under 5 years since the required version
of GCC was set at 3.3.0 at the time it was 7 years old.
I'm proposing bumping it to 4.1.0 which is almost 9 years
old since its used in RHEL 5 which is still supported.
For the record if it was set to
Signed-off-by: Timothy Arceri
---
src/util/u_atomic.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/util/u_atomic.h b/src/util/u_atomic.h
index 56c5740..4010036 100644
--- a/src/util/u_atomic.h
+++ b/src/util/u_atomic.h
@@ -21,7 +21,7 @@
#define PIPE_ATOMIC_OS_SOLARIS
Signed-off-by: Timothy Arceri
---
src/gbm/main/gbmint.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/gbm/main/gbmint.h b/src/gbm/main/gbmint.h
index 31345e6..155eb12 100644
--- a/src/gbm/main/gbmint.h
+++ b/src/gbm/main/gbmint.h
@@ -32,7 +32,7 @@
#include
/* GCC vi
Signed-off-by: Timothy Arceri
---
src/gtest/include/gtest/internal/gtest-port.h | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/gtest/include/gtest/internal/gtest-port.h
b/src/gtest/include/gtest/internal/gtest-port.h
index dc4fe0c..70d3b25 100644
--- a/src/gte
Signed-off-by: Timothy Arceri
---
src/egl/wayland/wayland-egl/wayland-egl-priv.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/egl/wayland/wayland-egl/wayland-egl-priv.h
b/src/egl/wayland/wayland-egl/wayland-egl-priv.h
index da25be9..74a1552 100644
--- a/src/egl/wayland
Signed-off-by: Timothy Arceri
---
src/gallium/auxiliary/util/u_math.h | 8
src/gallium/state_trackers/xa/xa_priv.h | 2 +-
2 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/gallium/auxiliary/util/u_math.h
b/src/gallium/auxiliary/util/u_math.h
index 0113fb1..19c7343
This code has been turned off for the last
decade 88e3ed2d816cd619b26a20755262bae85e05175e
Considering 3Dnow is obsolete it
seems the bug will never be fixed so just
remove it.
Signed-off-by: Timothy Arceri
---
src/mesa/Makefile.sources | 1 -
src/mesa/x86/3dnow.c| 5 -
src/mesa/x
Signed-off-by: Juha-Pekka Heikkila
---
src/mesa/drivers/dri/i965/.gitignore | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/mesa/drivers/dri/i965/.gitignore
b/src/mesa/drivers/dri/i965/.gitignore
index cb66728..8eb9f4e 100644
--- a/src/mesa/drivers/dri/i965/.gitignore
+++ b/src/mesa/driv
Signed-off-by: Juha-Pekka Heikkila
---
src/mapi/.gitignore | 1 +
1 file changed, 1 insertion(+)
create mode 100644 src/mapi/.gitignore
diff --git a/src/mapi/.gitignore b/src/mapi/.gitignore
new file mode 100644
index 000..060683b
--- /dev/null
+++ b/src/mapi/.gitignore
@@ -0,0 +1 @@
+share
I didn't find this being used anywhere
Signed-off-by: Juha-Pekka Heikkila
---
src/glx/glxclient.h | 3 ---
src/glx/glxcmds.c | 17 -
2 files changed, 20 deletions(-)
diff --git a/src/glx/glxclient.h b/src/glx/glxclient.h
index 74c19c4..aaca989 100644
--- a/src/glx/glxclient.h
From: José Fonseca
f0ba7d897d1c22202531acb70f134f2edc30557d made debug_assert()/assert()
unsafe for expressions, but only now with u_atomic.h started to rely on
them for Windows this became an issue.
This fixes non-debug builds with MSVC.
---
src/gallium/auxiliary/util/u_debug.h | 2 +-
1 file
On 12/12/2014 07:09 AM, Jose Fonseca wrote:
From: José Fonseca
f0ba7d897d1c22202531acb70f134f2edc30557d made debug_assert()/assert()
unsafe for expressions, but only now with u_atomic.h started to rely on
them for Windows this became an issue.
This fixes non-debug builds with MSVC.
---
src/g
"9.4. FRAMEBUFFER COMPLETENESS
...
Depth and stencil attachments, if present, are the same image."
Notice that this restriction is not included in the OpenGL ES2 spec.
Fixes 18 dEQP tests in:
dEQP-GLES3.functional.fbo.completeness.attachment_combinations.*
---
src/mesa/main/fbobject.c | 20 +++
Typo in subject line: "ans" -> "and"
-Brian
On 12/12/2014 07:14 AM, Iago Toral Quiroga wrote:
"9.4. FRAMEBUFFER COMPLETENESS
...
Depth and stencil attachments, if present, are the same image."
Notice that this restriction is not included in the OpenGL ES2 spec.
Fixes 18 dEQP tests in:
dEQ
On Wed, Dec 10, 2014 at 6:50 AM, Vadim Girlin wrote:
> On 12/09/2014 07:39 AM, Vadim Girlin wrote:
>>
>> On 12/09/2014 05:18 AM, Dave Airlie wrote:
>>>
>>> On 8 December 2014 at 20:41, Vadim Girlin wrote:
On 12/06/2014 07:13 AM, Vadim Girlin wrote:
>
>
> On 12/04/2014 01:43
Series looks nice cleanup.
I don't know of any need to keep support for older GCC neither.
But I don't think it makes sense to mess with gtest -- it's better to
keep this in sync with upstream, and clobber with new upstream versions
when appropriate.
All other changes are
Reviewed-By: Jose
I suggest you compare pitch_tile_max between the color surface and
fmask. If it's different, then I think radeon_surface should use the
color surface pitch instead of calculating a separate fmask pitch.
I don't have any docs for r600-r700, but I have an old address lib
that only contains r600-r800
Alternatively, I can search the format string and reject it if it
contains '%' not followed by 's'.
Marek
On Wed, Dec 10, 2014 at 9:37 PM, Marek Olšák wrote:
> Indeed, locales can cause problems.
>
> Would "vsnprintf_l" that overrides the current locale or "uselocale"
> address your concerns?
>
On Dec 11, 2014 11:46 PM, "Iago Toral" wrote:
>
> On Fri, 2014-12-12 at 08:21 +0100, Iago Toral wrote:
> > On Thu, 2014-12-11 at 11:24 -0800, Jason Ekstrand wrote:
> > >
> > >
> > > On Tue, Dec 9, 2014 at 4:06 AM, Iago Toral Quiroga
> > > wrote:
> > > From: Jason Ekstrand
> > >
> > >
Am 12.12.2014 um 15:09 schrieb Jose Fonseca:
> From: José Fonseca
>
> f0ba7d897d1c22202531acb70f134f2edc30557d made debug_assert()/assert()
> unsafe for expressions, but only now with u_atomic.h started to rely on
> them for Windows this became an issue.
>
> This fixes non-debug builds with MSVC
This patch is intended to fix:
https://bugs.freedesktop.org/show_bug.cgi?id=82991
Which is now also exposed through the piglit patch sent at:
http://lists.freedesktop.org/archives/piglit/2014-December/013648.html
Andres Gomez (1):
i965/brw_reg: struct constructor now needs explicit negate and a
We were asuming, when constructing a new brw_reg struct, that the
negate and abs register modifiers would not be present by default in
the new register.
Now, we force explicitly setting these values when constructing a new
register.
This will avoid problems like forgetting to properly set them wh
On Fri, Dec 12, 2014 at 10:17 AM, Roland Scheidegger
wrote:
> Am 12.12.2014 um 15:09 schrieb Jose Fonseca:
> > From: José Fonseca
> >
> > f0ba7d897d1c22202531acb70f134f2edc30557d made debug_assert()/assert()
> > unsafe for expressions, but only now with u_atomic.h started to rely on
> > them for
On 12/12/14 16:30, Patrick Baggett wrote:
On Fri, Dec 12, 2014 at 10:17 AM, Roland Scheidegger mailto:srol...@vmware.com>> wrote:
Am 12.12.2014 um 15:09 schrieb Jose Fonseca:
> From: José Fonseca mailto:jfons...@vmware.com>>
>
> f0ba7d897d1c22202531acb70f134f2edc30557d made
On Tue, Dec 9, 2014 at 4:06 AM, Iago Toral Quiroga wrote:
> diff --git a/m4/ax_check_python_mako_module.m4
> b/m4/ax_check_python_mako_module.m4
> new file mode 100644
> index 000..f289f26
> --- /dev/null
> +++ b/m4/ax_check_python_mako_module.m4
> @@ -0,0 +1,77 @@
> +# ==
I'm currently trying to create an OpenGL texture from an existing memory
block
I allocated using CMEM(TI module). I adjusted CMEM to work on an intel
baytrail CoM. The block is filled by an FPGA that does not support scatter
gather DMA. So I reserved an area within the baytrail's system memory us
Thanks Timothy. The whole series looks good to me:
Reviewed-by: Matt Turner
I'd wait a couple of days for objections before pushing the series.
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-
On Fri, Dec 12, 2014 at 6:07 AM, Juha-Pekka Heikkila
wrote:
> Signed-off-by: Juha-Pekka Heikkila
> ---
> src/mapi/.gitignore | 1 +
> 1 file changed, 1 insertion(+)
> create mode 100644 src/mapi/.gitignore
>
> diff --git a/src/mapi/.gitignore b/src/mapi/.gitignore
> new file mode 100644
> index
Reviewed-by: Matt Turner
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Reviewed-by: Matt Turner
Thanks JP!
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
On Tue, Dec 9, 2014 at 11:09 PM, Maxence Le Doré
wrote:
> It seems to have been forgotten during viewports array implementation time.
> ---
> src/glsl/builtin_variables.cpp | 4
> src/glsl/glsl_parser_extras.cpp | 3 +++
> src/glsl/glsl_parser_extras.h | 3 +++
> 3 files changed, 10 inser
On 11/12/14 20:05, Jan Vesely wrote:
Signed-off-by: Jan Vesely
---
src/util/register_allocate.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/src/util/register_allocate.c b/src/util/register_allocate.c
index 1cfd66f..af7a20c 100644
--- a/src/util/register_al
Hello,
Maybe this change should be mentioned in the relnotes ?
2014-12-12 18:04 GMT+01:00 Matt Turner :
>
> Thanks Timothy. The whole series looks good to me:
>
> Reviewed-by: Matt Turner
>
> I'd wait a couple of days for objections before pushing the series.
> ___
On Thu, Dec 11, 2014 at 2:34 PM, Eduardo Lima Mitev wrote:
> From: Iago Toral Quiroga
>
> For code such as this in a vertex or fragment shader:
>
> uniform float in0;
> flat out float out0;
> ...
> out0 = ceil(in0)
>
> We generate this IR:
>
> (assign (x) (var_ref packed:out0)
>(expression i
On 12/12/2014 06:55 AM, Jose Fonseca wrote:
> Series looks nice cleanup.
>
> I don't know of any need to keep support for older GCC neither.
>
> But I don't think it makes sense to mess with gtest -- it's better to
> keep this in sync with upstream, and clobber with new upstream versions
> when a
On 12/12/2014 12:02 AM, Samuel Iglesias Gonsálvez wrote:
> On Thursday, December 11, 2014 06:12:47 PM Ian Romanick wrote:
>> On 12/11/2014 02:34 PM, Eduardo Lima Mitev wrote:
>>> From: Samuel Iglesias Gonsalvez
>>>
>>> Return the proper value for two-dimensional array texture and
>>> three-dimensi
With s/ans/and/ in the commit message, this patch is
Reviewed-by: Ian Romanick
On 12/12/2014 06:14 AM, Iago Toral Quiroga wrote:
> "9.4. FRAMEBUFFER COMPLETENESS
> ...
> Depth and stencil attachments, if present, are the same image."
>
> Notice that this restriction is not included in the Ope
What?!? My K6-2 300MHz is teh awesome. :)
On 12/12/2014 04:26 AM, Timothy Arceri wrote:
> This code has been turned off for the last
> decade 88e3ed2d816cd619b26a20755262bae85e05175e
>
> Considering 3Dnow is obsolete it
> seems the bug will never be fixed so just
> remove it.
>
> Signed-off-by:
Without this, this extension basically can't work in indirect contexts,
TexImage2D will compute the image size as 0 and we'll send no image data
to the server. Old servers would do undefined things upon receipt of
such a teximage; new servers with the fix for CVE-2014-8098 will correctly
reject th
On Tue, Dec 9, 2014 at 4:07 AM, Iago Toral Quiroga
wrote:
>
> From: Jason Ekstrand
>
> v2 by Iago Toral :
>
> - When testing if we can directly pack we should use the src format to
> check
> if we are packing from an RGBA format. The original code used the dst
> format
> for the ubyte case by
On Tue, Dec 9, 2014 at 4:07 AM, Iago Toral Quiroga
wrote:
>
> This is necessary to handle conversions between array types where
> the driver does not support the dst format requested by the client and
> chooses a different format instead.
>
> We will need this in _mesa_format_convert, so move it t
Looks good!
Reviewed-by: Jason Ekstrand
On Tue, Dec 9, 2014 at 4:07 AM, Iago Toral Quiroga
wrote:
>
> The new parameter allows callers to provide a rebase swizzle that
> the function needs to use to match the requirements of the base
> internal format involved. This is necessary when the source
I like this patch, but I doubt it actually builds at this point in the
series. There are other callers of _mesa_swizzle_and_convert.
--Jason
On Tue, Dec 9, 2014 at 4:07 AM, Iago Toral Quiroga
wrote:
>
> In the future we would like to have a format conversion library that is
> independent of GL s
On Tue, Dec 9, 2014 at 4:07 AM, Iago Toral Quiroga
wrote:
>
> For glReadPixels with a Luminance destination format we compute luminance
> values from RGBA as L=R+G+B. This, however, requires ad-hoc implementation,
> since pack/unpack functions or _mesa_swizzle_and_convert won't do this
> (and thus
On Tue, Dec 9, 2014 at 4:07 AM, Iago Toral Quiroga
wrote:
>
> Notice that _mesa_format_convert does not handle byte-swapping scenarios,
> GL_COLOR_INDEX or MESA_FORMAT_YCBCR(_REV), so these must be handled
> separately.
>
> Also, remove all the code that goes unused after using
> _mesa_format_conv
On Tue, Dec 9, 2014 at 4:07 AM, Iago Toral Quiroga
wrote:
>
> This is the only place that uses _mesa_unpack_color_span_float so after
> this we should be able to remove that function.
> ---
> src/mesa/swrast/s_drawpix.c | 39 +++
> 1 file changed, 35 insertions
On 12/10/2014 07:08 AM, Valentin Corfu wrote:
>
> On 10.12.2014 07:02, Chad Versace wrote:
>> On 12/08/2014 01:45 PM, Ian Romanick wrote:
>>> On 12/02/2014 12:10 AM, Valentin Corfu wrote:
With this check we can avoid segmentation fault when invalid value used
during eglCreateContext.
>>
On Thu, Dec 11, 2014 at 2:25 AM, Emil Velikov wrote:
> It seems that it's still broken [1] - for both in and out of three builds.
Oh, I bet I didn't see that because I was configuring with my regular
configure arguments which include --enable-gles{1,2}.
Just needed to move the rule for the glapi
José,
As it is now, since we're not building the gbm or egl state trackers
via autotools, they're not included in the tarball created by make
dist. That is, the files in
src/gallium/state_trackers/egl
src/gallium/state_trackers/gbm
wouldn't be distributed. I notice that there are SConscripts tho
Iago,
This is looking good. I have a few comments on a couple of the patches.
Everything else is
Reviewed-by: Jason Ekstrand
On Tue, Dec 9, 2014 at 4:07 AM, Iago Toral Quiroga
wrote:
>
> This is the second of two series that aim to address:
> https://bugs.freedesktop.org/show_bug.cgi?id=84566
On 12/12/14 20:38, Matt Turner wrote:
José,
As it is now, since we're not building the gbm or egl state trackers
via autotools, they're not included in the tarball created by make
dist. That is, the files in
src/gallium/state_trackers/egl
src/gallium/state_trackers/gbm
wouldn't be distributed.
On Fri, Dec 12, 2014 at 12:54 PM, Jose Fonseca wrote:
> On 12/12/14 20:38, Matt Turner wrote:
>>
>> José,
>>
>> As it is now, since we're not building the gbm or egl state trackers
>> via autotools, they're not included in the tarball created by make
>> dist. That is, the files in
>>
>> src/galliu
On 12/11/2014 09:20 AM, Jose Fonseca wrote:
On 11/12/14 08:40, Emil Velikov wrote:
Hi Jose,
On 10/12/14 14:18, Jose Fonseca wrote:
I never tried, but it doesn't surprise that ?USE_MGL_NAMESPACE
doesn't work properly on Windows.
At very least the src/mesa/drivers/windows/gdi and
src/gallium/ta
https://bugs.freedesktop.org/show_bug.cgi?id=86944
--- Comment #4 from Brian Paul ---
Vinson, can you see if commit e75e677d288e67c3c05e7b8744e08cd73bdcbed8 fixes
this?
--
You are receiving this mail because:
You are the assignee for the bug.
___
mesa
Looking at src/glx/glxextensions.c (the known_glx_extensions array
specifically), I don't think we support GL_EXT_texture_integer on the
client side for indirect rendering. So... do we actually need this patch?
On 12/12/2014 10:34 AM, Adam Jackson wrote:
> Without this, this extension basically c
https://bugs.freedesktop.org/show_bug.cgi?id=86944
--- Comment #5 from Vinson Lee ---
(In reply to Brian Paul from comment #4)
> Vinson, can you see if commit e75e677d288e67c3c05e7b8744e08cd73bdcbed8 fixes
> this?
No, it does not fix the build error.
--
You are receiving this mail because:
You
On 12/12/14 20:59, Matt Turner wrote:
On Fri, Dec 12, 2014 at 12:54 PM, Jose Fonseca wrote:
On 12/12/14 20:38, Matt Turner wrote:
José,
As it is now, since we're not building the gbm or egl state trackers
via autotools, they're not included in the tarball created by make
dist. That is, the f
On Thu, Dec 11 2014, Jason Ekstrand wrote:
> Yeah, this looks nifty.
Thanks!
> I've got some comments on the implementation though.
I really appreciate the careful review. I obviously didn't pay quite as
much attention to detail as I would like to when writing this patch. I'm
glad I didn't bury
On Thu, Dec 11, 2014 at 09:02:11 +, Emil Velikov wrote:
> * Don't ship anything but a tar.xz tarball.
> Linux, *BSD and WindowsXP+ have/ship programs that support the format
> for more than 5 years.
>
FWIW I'd appreciate if you kept the tar.gz.
Cheers,
Julien
___
This new interface allows for writing a series of objects to a chunk
of memory (a "blob").. The allocated memory is maintained within the
blob itself, (and re-allocated by doubling when necessary).
There are also functions for reading objects from a blob as well. If
code attempts to read beyond th
On Fri, Dec 12, 2014 at 2:43 PM, Carl Worth wrote:
> diff --git a/src/glsl/Makefile.sources b/src/glsl/Makefile.sources
> index 676fa0d..875e4bf 100644
> --- a/src/glsl/Makefile.sources
> +++ b/src/glsl/Makefile.sources
> @@ -105,7 +105,8 @@ LIBGLSL_FILES = \
> $(GLSL_SRCDIR)/opt_swizzle_s
On Fri, Dec 12, 2014 at 2:43 PM, Carl Worth wrote:
>
> This new interface allows for writing a series of objects to a chunk
> of memory (a "blob").. The allocated memory is maintained within the
> blob itself, (and re-allocated by doubling when necessary).
>
> There are also functions for reading
On Fri, Dec 12, 2014 at 2:37 PM, Carl Worth wrote:
>
> On Thu, Dec 11 2014, Jason Ekstrand wrote:
> > Yeah, this looks nifty.
>
> Thanks!
>
> > I've got some comments on the implementation though.
>
> I really appreciate the careful review. I obviously didn't pay quite as
> much attention to detai
On Fri, Dec 12 2014, Jason Ekstrand wrote:
> Should be MAX2(blob->allocated * 2, blob->size + additional)
Yikes! Yes. That's really embarrassing.
> Something to tuck in the back of your brain in case you have a need to grow
> this datastructure: The above write functions could be generated with t
In addition to the (mostly) nits below, this seems ripe for some unit
tests. Especially for the overrun cases and the data alignment cases.
On 12/12/2014 02:43 PM, Carl Worth wrote:
> This new interface allows for writing a series of objects to a chunk
> of memory (a "blob").. The allocated memor
On Fri, Dec 12 2014, Ian Romanick wrote:
> In addition to the (mostly) nits below, this seems ripe for some unit
> tests. Especially for the overrun cases and the data alignment cases.
Thanks for the review, Ian. Testing makes sense. I'll cook something up.
And thanks for the nit-picking. I've c
If you had a conditional assignment of an array or struct (say, from the
if-lowering pass), we'd try doing swizzle_for_size() on the aggregate
type, and it would assertion fail due to vector_elements==0. Instead,
extend emit_block_mov() to handle emitting the conditional operations,
which also mea
Requires Evergreen/Cayman and updated radeon kernel module
Signed-off-by: Glenn Kennard
---
Changes since V1:
* Fixed 8 bit index case, only triggerable using GLES 3.1 which isn't supported
yet
* Don't read info struct values that have no meaning for indirect case
* Don't update start_instance/i
Chris Wilson noted that repeated calls to CheckQuery() would call
drm_intel_bo_references(brw->batch.bo, query->bo) on each invocation,
which is expensive. Once we've flushed, we know that future batches
won't reference query->bo, so there's no point in asking more than once.
This patch adds a br
If query->bo == NULL, this is a redundant CheckQuery call, and we
should simply return. We didn't do anything anyway - we skipped the
batch flushing block, and although we called get_results(), it has an
early return and does nothing. Why bother?
Signed-off-by: Kenneth Graunke
Cc: Chris Wilson
q->Ready means that the results are in, and core Mesa is free to return
them to the application. gen6_queryobj_get_results() is a natural place
to set that flag; doing so means callers don't have to.
The older non-hardware-context aware code couldn't do this, because we
had to call brw_queryobj_g
CheckQuery calls drm_intel_bo_references to see if the batch references
the query BO, and if so, flushes. It then checks if the query BO is
busy, and if not, calls gen6_queryobj_get_results().
Stupidly, gen6_queryobj_get_results() immediately did a second redundant
drm_intel_bo_references check,
This is less code and also measures the duration of the stall for us.
Our old code predates the existance of brw_bo_map().
Signed-off-by: Kenneth Graunke
Cc: Chris Wilson
Cc: Eero Tamminen
---
src/mesa/drivers/dri/i965/gen6_queryobj.c | 8 +---
1 file changed, 1 insertion(+), 7 deletions(
79 matches
Mail list logo
