Re: [Mesa-dev] [PATCH 3/3] ra: assert against unsigned underflow in q_total

2014-09-06 Thread Kenneth Graunke
On Friday, September 05, 2014 08:59:32 PM Connor Abbott wrote: > q_total should never go below 0 (which is why it's defined as unsigned), > and if it does, then something is seriously wrong. > > Signed-off-by: Connor Abbott > --- > src/mesa/program/register_allocate.c | 1 + > 1 file changed, 1

Re: [Mesa-dev] [PATCH 04/20] i965/vec4: Preserve CFG in spill_reg().

2014-09-06 Thread Pohjolainen, Topi
On Tue, Sep 02, 2014 at 09:34:15PM -0700, Matt Turner wrote: > --- > src/mesa/drivers/dri/i965/brw_vec4.cpp | 6 ++- > src/mesa/drivers/dri/i965/brw_vec4.h | 10 ++-- > .../drivers/dri/i965/brw_vec4_reg_allocate.cpp | 11 ++-- > src/mesa/drivers/dri/i965/brw_vec4_vis

[Mesa-dev] [Bug 81680] [r600g] Firefox crashes with hardware acceleration turned on

2014-09-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=81680 Benjamin Bellec changed: What|Removed |Added CC||b.bel...@gmail.com --- Comment #36 fro

[Mesa-dev] [Bug 76188] EGL_EXT_image_dma_buf_import fd ownership is incorrect

2014-09-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=76188 Emil Velikov changed: What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|---

[Mesa-dev] [Bug 81680] [r600g] Firefox crashes with hardware acceleration turned on

2014-09-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=81680 --- Comment #37 from Eugene --- Firefox 32. MESA 10.4-Git. Still crashes. -- You are receiving this mail because: You are the assignee for the bug. ___ mesa-dev mailing list mesa-dev@lists.freedesktop

[Mesa-dev] [Bug 81680] [r600g] Firefox crashes with hardware acceleration turned on

2014-09-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=81680 --- Comment #38 from Tobias Droste --- same here with and without your patch and the settings described in comment #35. (r600g radeon hd5770) -- You are receiving this mail because: You are the assignee for the bug. ___

[Mesa-dev] [Bug 81680] [r600g] Firefox crashes with hardware acceleration turned on

2014-09-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=81680 Alexandre Demers changed: What|Removed |Added CC|alexandre.f.dem...@gmail.co | |m

[Mesa-dev] [PATCH] r600g, radeonsi: add debug option which forces DMA for copy_region and blit

2014-09-06 Thread Marek Olšák
From: Marek Olšák --- Turn this on, run piglit, and pray for mercy. It might be interesting to see if it makes 3D apps any faster. Or piglit. src/gallium/drivers/r600/evergreen_state.c| 2 +- src/gallium/drivers/r600/r600_blit.c | 18 +++--- src/gallium/drivers/r600/r

[Mesa-dev] [PATCH 2/8] nvc0: avoid null deref of screen when collecting stats

2014-09-06 Thread Ilia Mirkin
Reported by Coverity Signed-off-by: Ilia Mirkin --- src/gallium/drivers/nouveau/nvc0/nvc0_context.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/nouveau/nvc0/nvc0_context.c b/src/gallium/drivers/nouveau/nvc0/nvc0_context.c index 50c2058..b33a673 100644

[Mesa-dev] [PATCH 3/8] nvc0: size is a uint16_t, remove unnecessary assertion

2014-09-06 Thread Ilia Mirkin
Reported by Coverity. Signed-off-by: Ilia Mirkin --- src/gallium/drivers/nouveau/nvc0/nve4_compute.h | 1 - 1 file changed, 1 deletion(-) diff --git a/src/gallium/drivers/nouveau/nvc0/nve4_compute.h b/src/gallium/drivers/nouveau/nvc0/nve4_compute.h index 79862b7..4d7af54 100644 --- a/src/galli

[Mesa-dev] [PATCH 7/8] nvc0/ir: uses was always null at that point in the code

2014-09-06 Thread Ilia Mirkin
Reported by Coverity Signed-off-by: Ilia Mirkin --- src/gallium/drivers/nouveau/codegen/nv50_ir_lowering_nvc0.cpp | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/src/gallium/drivers/nouveau/codegen/nv50_ir_lowering_nvc0.cpp b/src/gallium/drivers/nouveau/codegen/nv50_i

[Mesa-dev] [PATCH 5/8] nouveau: buffer can never be null

2014-09-06 Thread Ilia Mirkin
Reported by Coverity Signed-off-by: Ilia Mirkin --- src/gallium/drivers/nouveau/nouveau_video.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/gallium/drivers/nouveau/nouveau_video.c b/src/gallium/drivers/nouveau/nouveau_video.c index bd04625..d6330fa 100644 --- a/src/gallium/drivers/

[Mesa-dev] [PATCH 6/8] nv50/ir: avoid array overrun when checking for supported mods

2014-09-06 Thread Ilia Mirkin
Reported by Coverity Signed-off-by: Ilia Mirkin Cc: "10.2 10.3" --- src/gallium/drivers/nouveau/codegen/nv50_ir_target_nv50.cpp | 2 +- src/gallium/drivers/nouveau/codegen/nv50_ir_target_nvc0.cpp | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers/nouveau/

[Mesa-dev] [PATCH 8/8] nv50/ir: accomodate all file types, there are now more than 8

2014-09-06 Thread Ilia Mirkin
Reported by Coverity Signed-off-by: Ilia Mirkin --- src/gallium/drivers/nouveau/codegen/nv50_ir_target.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers/nouveau/codegen/nv50_ir_target.h b/src/gallium/drivers/nouveau/codegen/nv50_ir_target.h index cb9f

[Mesa-dev] [PATCH 4/8] nvc0/ir: insn can never be null

2014-09-06 Thread Ilia Mirkin
Reported by Coverity. Signed-off-by: Ilia Mirkin --- src/gallium/drivers/nouveau/codegen/nv50_ir_lowering_nvc0.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/nouveau/codegen/nv50_ir_lowering_nvc0.cpp b/src/gallium/drivers/nouveau/codegen/nv50_ir_lowe

[Mesa-dev] [PATCH 1/8] nvc0: use 64-bit math when scaling the query results

2014-09-06 Thread Ilia Mirkin
Reported by Coverity. Signed-off-by: Ilia Mirkin --- src/gallium/drivers/nouveau/nvc0/nvc0_query.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/gallium/drivers/nouveau/nvc0/nvc0_query.c b/src/gallium/drivers/nouveau/nvc0/nvc0_query.c index 007f8c4..3a6df9d 100

[Mesa-dev] [Bug 78773] Doom3 BFG doesnt start

2014-09-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=78773 --- Comment #15 from Jan --- (In reply to comment #14) > according to comment #9 this is fixed i tried to get latest git and compile the code myself but that brought more errors. i dag for some time but i couldnt handle these errors. sorry --

Re: [Mesa-dev] [PATCH] r600g, radeonsi: add debug option which forces DMA for copy_region and blit

2014-09-06 Thread Andy Furniss
Marek Olšák wrote: From: Marek Olšák --- Turn this on, run piglit, and pray for mercy. It might be interesting to see if it makes 3D apps any faster. Or piglit. Well it's not piglit and I haven't benchmarked anything yet, but I get a couple of faults at the start of Unigine Valley. [20635

Re: [Mesa-dev] [PATCH] r600g, radeonsi: add debug option which forces DMA for copy_region and blit

2014-09-06 Thread Andy Furniss
Andy Furniss wrote: Marek Olšák wrote: From: Marek Olšák --- Turn this on, run piglit, and pray for mercy. It might be interesting to see if it makes 3D apps any faster. Or piglit. Well it's not piglit and I haven't benchmarked anything yet, but I get a couple of faults at the start of Unig

[Mesa-dev] [PATCH] Add support for NV_depth_buffer_float.

2014-09-06 Thread Mathias Froehlich
Hi, Please review: Add support for the unclamped versions of glDepthRange and relatives. Also starting with OpenGL 4.2 the traditional functions for this should no longer clamp the values to [0, 1]. Signed-off-by: Mathias Froehlich --- docs/GL3.txt | 1 + src/

Re: [Mesa-dev] [PATCH 3/3] ra: assert against unsigned underflow in q_total

2014-09-06 Thread Connor Abbott
On Sat, Sep 6, 2014 at 3:23 AM, Kenneth Graunke wrote: > On Friday, September 05, 2014 08:59:32 PM Connor Abbott wrote: >> q_total should never go below 0 (which is why it's defined as unsigned), >> and if it does, then something is seriously wrong. >> >> Signed-off-by: Connor Abbott >> --- >> s

[Mesa-dev] [Bug 83567] New: Mesa 10.2.6 does not compile with llvm 3.5

2014-09-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=83567 Priority: medium Bug ID: 83567 Assignee: mesa-dev@lists.freedesktop.org Summary: Mesa 10.2.6 does not compile with llvm 3.5 Severity: normal Classification: Unclassified OS:

[Mesa-dev] [Bug 83567] Mesa 10.2.6 does not compile with llvm 3.5

2014-09-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=83567 --- Comment #1 from Vinson Lee --- (In reply to comment #0) > It appears the structure of llvm changed a bit in 3.5 and the Mesa scons > scripts assume the old structure. Please post the output of the build error. -- You are receiving this mai

[Mesa-dev] [Bug 83567] Mesa 10.2.6 does not compile with llvm 3.5

2014-09-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=83567 --- Comment #2 from smoki --- For me also does not build with autoconf too, seems like this one is missed for stable: http://cgit.freedesktop.org/mesa/mesa/commit/src/gallium/auxiliary/gallivm/lp_bld_debug.cpp?id=564821c917f4a9d5a0de2ee77b90b0c

[Mesa-dev] [Bug 83567] Mesa 10.2.6 does not compile with llvm 3.5

2014-09-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=83567 Vinson Lee changed: What|Removed |Added CC||awa...@gmail.com, |

[Mesa-dev] [Bug 83570] New: Glyphy demo throws unhandled Integer division by zero exception

2014-09-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=83570 Priority: medium Bug ID: 83570 Assignee: mesa-dev@lists.freedesktop.org Summary: Glyphy demo throws unhandled Integer division by zero exception Severity: major Classific

[Mesa-dev] [Bug 82471] [swrast] piglit fp-condition_codes-01 regression

2014-09-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=82471 Vinson Lee changed: What|Removed |Added Blocks||79706 -- You are receiving this mail becau

[Mesa-dev] [Bug 79706] [TRACKER] Mesa regression tracker

2014-09-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=79706 Vinson Lee changed: What|Removed |Added Depends on||82471 -- You are receiving this mail becau

[Mesa-dev] [PATCH 1/3] i965/fs: Remove direct fs_visitor brw_wm_prog_data dependence

2014-09-06 Thread Jordan Justen
Instead we store a brw_stage_prog_data pointer, and cast it to brw_wm_prog_data for fragment shader specific code paths. Signed-off-by: Jordan Justen --- git://people.freedesktop.org/~jljusten/mesa for-upstream No piglit regressions seen on gen7. src/mesa/drivers/dri/i965/brw_fs.cpp |

[Mesa-dev] [PATCH 2/3] i965/fs: Use brw_sampler_prog_key_data instead of brw_wm_prog_key::tex

2014-09-06 Thread Jordan Justen
This helps: 1. Reduce the need to have fs_visitor::key's type be brw_wm_prog_key* 2. Align the code to allow brw_sampler_prog_key_data to be pulled out of other prog_key types for different stages. Signed-off-by: Jordan Justen --- src/mesa/drivers/dri/i965/brw_fs_visitor.cpp | 41

[Mesa-dev] [PATCH 3/3] i965/fs: Remove direct fs_visitor brw_wm_prog_key dependence

2014-09-06 Thread Jordan Justen
Instead we store a void pointer to the key, and cast it to brw_wm_prog_key for fragment shader specific code paths. Signed-off-by: Jordan Justen --- src/mesa/drivers/dri/i965/brw_fs.cpp | 17 +++-- src/mesa/drivers/dri/i965/brw_fs.h | 2 +- src/mesa/drivers/dri/i96

[Mesa-dev] [Bug 83573] New: [swrast] piglit fs-op-not-bool-using-if regression

2014-09-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=83573 Priority: medium Bug ID: 83573 Keywords: bisected, regression CC: anuj.pho...@gmail.com, matts...@gmail.com Assignee: mesa-dev@lists.freedesktop.org Blocks: 79706 Sum

[Mesa-dev] [Bug 79706] [TRACKER] Mesa regression tracker

2014-09-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=79706 Vinson Lee changed: What|Removed |Added Depends on||83573 -- You are receiving this mail becau

[Mesa-dev] [Bug 83574] New: [llvmpipe] [softpipe] piglit arb_explicit_uniform_location-use-of-unused-loc regression

2014-09-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=83574 Priority: medium Bug ID: 83574 Keywords: have-backtrace, regression Assignee: mesa-dev@lists.freedesktop.org Summary: [llvmpipe] [softpipe] piglit arb_explicit_uniform_locati

[Mesa-dev] [Bug 83574] [llvmpipe] [softpipe] piglit arb_explicit_uniform_location-use-of-unused-loc regression

2014-09-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=83574 Vinson Lee changed: What|Removed |Added CC||lem...@gmail.com, |

[Mesa-dev] [Bug 79706] [TRACKER] Mesa regression tracker

2014-09-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=79706 Vinson Lee changed: What|Removed |Added Depends on||83574 -- You are receiving this mail becau

[Mesa-dev] [Bug 60943] /usr/include/xorg/fb.h(98): catastrophic error: #error directive: "GLYPHPADBYTES must be 4"

2014-09-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=60943 Vinson Lee changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[Mesa-dev] [PATCH] pipe-loader: Include unistd.h in pipe_loader_drm.c for close function.

2014-09-06 Thread Vinson Lee
This patch fixes a build error on DragonFly. CC libpipe_loader_la-pipe_loader_drm.lo pipe_loader_drm.c: In function 'pipe_loader_drm_probe': pipe_loader_drm.c:207:10: error: implicit declaration of function 'close' [-Werror=implicit-function-declaration] Signed-off-by: Vinson Lee --- s

Re: [Mesa-dev] [PATCH 3/3] meta: Avoid shader recompilation for msaa color resolve blit

2014-09-06 Thread Dave Airlie
coverity reported a use before NULL check for src_rb in the below code, maybe it was there already, but it noticed it now you changed it, we check src_rb->NumSamples then later src_rb is checked. Could you take a look. Dave. > const char *texcoord_type = "vec2"; > const int samples = MA

[Mesa-dev] [Bug 83570] Glyphy demo throws unhandled Integer division by zero exception

2014-09-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=83570 --- Comment #1 from rcond...@hotmail.com --- I haven't really gotten a grasp on the code base, but my assessment is that the issue is: tgsi_exec.c static void micro_idiv(union tgsi_exec_channel *dst, const union tgsi_exec_channel *src

[Mesa-dev] [Bug 83574] [llvmpipe] [softpipe] piglit arb_explicit_uniform_location-use-of-unused-loc regression

2014-09-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=83574 Tapani Pälli changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|mesa-dev@list