Re: [Mesa-dev] [PATCH v2 18/23] i965: Implement GL_PRIMITIVES_GENERATED with non-zero streams.

Hi Chris, On Tue, 2014-06-24 at 22:12 +1200, Chris Forbes wrote: > Continuing from this, I think you need a test to ensure that the > points emitted in nonzero streams are not accidentally rendered when > SO isn't active. > > According to that same section of the Haswell PRM, if SO Function > Ena

[Mesa-dev] [Bug 79629] [dri3] piglit glx_GLX_ARB_create_context_current_with_no_framebuffer fails

https://bugs.freedesktop.org/show_bug.cgi?id=79629 --- Comment #4 from fangxun --- Created attachment 101740 --> https://bugs.freedesktop.org/attachment.cgi?id=101740&action=edit build.log Build failure is due to "dri3.c:46:9: error: 'NullPixmap' undeclared". NullPixmap was removed in commit

Re: [Mesa-dev] [PATCH] Remove unneeded stall calls from batches on Baytrail.

On 24 June 2014 22:25, Kenneth Graunke wrote: > > On Wednesday, June 18, 2014 11:21:00 AM Gregory Hunt wrote: > > From: Greg Hunt > > > > These cause a small slowdown when we are sending a large number of small > batches to the GPU. > > Hello! > > Do you have any more specific data? For example,

[Mesa-dev] [PATCH 1/6] mesa: Add Pixman library to configure.ac

Added '--enable-pixman' (default=no) parameter for autogen and corresponding behaviour to include paths and Pixman library for Mesa if Pixman found. Signed-off-by: Juha-Pekka Heikkila --- configure.ac | 32 1 file changed, 32 insertions(+) diff --git a/configure

[Mesa-dev] [PATCH 0/6] Enable Pixman for Mesa

This is my old set which enable using Pixman on Mesa for some texture conversion fast paths. As is this passes Piglit quick set on my IVB. For general case this does not offer essentially better fps or such but these were recently tested on Chromebook with HSW inside where it showed promising dro

[Mesa-dev] [PATCH 5/6] mesa: Pixman texture conversion argb to rgb

If available use Pixman fastpath for texture conversion. Signed-off-by: Juha-Pekka Heikkila --- src/mesa/main/texstore.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/src/mesa/main/texstore.c b/src/mesa/main/texstore.c index 6a55f7a..fff92eb 100644 --- a/src/mes

[Mesa-dev] [PATCH 6/6] mesa: Pixman texture conversion rgb to rgb565 and rgb565_rev

If available use Pixman fastpath for texture conversion. Signed-off-by: Juha-Pekka Heikkila --- src/mesa/main/texstore.c | 8 1 file changed, 8 insertions(+) diff --git a/src/mesa/main/texstore.c b/src/mesa/main/texstore.c index fff92eb..3d95fb6 100644 --- a/src/mesa/main/texstore.c ++

[Mesa-dev] [PATCH 3/6] mesa: Pixman texture conversion rgb to abgr

If available use Pixman fastpath for texture conversion. Signed-off-by: Juha-Pekka Heikkila --- src/mesa/main/texstore.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/src/mesa/main/texstore.c b/src/mesa/main/texstore.c index a32b406..340fa42 100644 --- a/src/mesa/

[Mesa-dev] [PATCH 4/6] mesa: Pixman texture conversion argb to abgr

If available use Pixman fastpath for texture conversion. Signed-off-by: Juha-Pekka Heikkila --- src/mesa/main/texstore.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/src/mesa/main/texstore.c b/src/mesa/main/texstore.c index 340fa42..6a55f7a 100644 --- a/src/mes

[Mesa-dev] [PATCH 2/6] mesa: Add Pixman usage to texstore.c

This patch adds 'pixman_texture_conversion' function which will be used by following patches for converting textures between different pixel formats. Signed-off-by: Juha-Pekka Heikkila --- src/mesa/main/texstore.c | 65 1 file changed, 65 insertio

[Mesa-dev] [PATCH v2] Remove unneeded stall calls from batches on Baytrail. According to the bspec and running piglit these are not needed.

From: Greg Hunt These cause a small slowdown when we are sending a large number of small batches to the GPU. Removing these improves performance by upto 5% on some CPU bound SynMark tests (Batch[4-7], DrvState1, HdrBloom, Multithread, ShMapPcf). Signed-off-by: Gregory Hunt --- src/mesa/drive

[Mesa-dev] [PATCH 5/5] clover: Enable cl_khr_fp64 for devices that support doubles v2

v2: - Report correct values for CL_DEVICE_NATIVE_VECTOR_WIDTH_DOUBLE and CL_DEVICE_PREFERRED_VECTOR_WIDTH_DOUBLE. - Only define cl_khr_fp64 if the extension is supported. - Remove trailing space from extension string. - Rename device query function from cl_khr_fp86() to has_doubles(). -

[Mesa-dev] [PATCH 1/5] clover: Have compat::string allocate its own memory.

From: Francisco Jerez --- src/gallium/state_trackers/clover/api/kernel.cpp | 4 +++- src/gallium/state_trackers/clover/util/compat.hpp | 8 2 files changed, 7 insertions(+), 5 deletions(-) diff --git a/src/gallium/state_trackers/clover/api/kernel.cpp b/src/gallium/state_trackers/clov

[Mesa-dev] [PATCH 4/5] gallium: Add PIPE_SHADER_CAP_DOUBLES

This is for reporting whether or not double precision floating-point operations are supported. Reviewed-by: Francisco Jerez --- src/gallium/auxiliary/gallivm/lp_bld_limits.h | 2 ++ src/gallium/auxiliary/tgsi/tgsi_exec.h| 2 ++ src/gallium/docs/source/screen.rst| 2 ++ src/ga

[Mesa-dev] [PATCH 3/5] clover: Report default values for half and double fp configs v2

From: Matt Arsenault v2: -Fix indentation --- src/gallium/state_trackers/clover/api/device.cpp | 11 +-- src/gallium/state_trackers/clover/core/device.cpp | 24 +++ src/gallium/state_trackers/clover/core/device.hpp | 3 +++ 3 files changed, 36 insertions(+), 2 del

[Mesa-dev] [PATCH 2/5] clover: Fix not setting build log if the build succeeds v2

From: Matt Arsenault If there were only warnings, they would not be added to the log. Also fixes valgrind use after free errors. v2: - Use compat::string. --- src/gallium/state_trackers/clover/core/compiler.hpp | 3 ++- src/gallium/state_trackers/clover/core/error.hpp | 4 ++-- src/g

Re: [Mesa-dev] [PATCH] i965: disable blorp's linear filtering on SNB

Hi, I've been looking into this bug a bit more. I don't think disabling the blorp path on Sandybridge is the right thing to do. The only notable difference between the blorp code path and the meta code path seems to be that the blorp code forces the use of non-normalized coordinates whereas the me

[Mesa-dev] [PATCH] i965: Make glGetTex to PBO path use blorp to handle swizzled formats

Existing texture read into PBO was using GPU Blit engine in which src and dest formats must match. With commit 61e264f4fcdba, internally stored texture formats were no longer swizzled (BGRA instead of RGBA). This caused existing accelerated paths to fallback to the SW slow path since the internal

Re: [Mesa-dev] [PATCH v2 01/23] glsl: Add parsing support for multi-stream output in geometry shaders.

On 06/20/2014 08:17 PM, Timothy Arceri wrote: > On Fri, 2014-06-20 at 10:46 -0700, Ian Romanick wrote: > >> I care a lot less about "what is often done" than I do about "what >> should be done". If there is an argument to be made that stand-alone >> comments (not on a line with other code) are be

Re: [Mesa-dev] [PATCH] glsl: Properly lex extra tokens when handling # directives.

Kenneth Graunke writes: > That was the strangest bug I've tracked down in a while. A truly heroic debug effort, Ken! I recently ran into a bug or two in glcpp which were also running afoul of the annoying default lex rule. I'm about to publish my latest series of glcpp patches, but below is a p

[Mesa-dev] [PATCH 04/16] mesa: Use typed foreach_in_list instead of foreach_list.

--- src/mesa/main/shader_query.cpp | 24 +-- src/mesa/program/ir_to_mesa.cpp| 31 -- src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 69 +- 3 files changed, 41 insertions(+), 83 deletions(-) diff --git a/src/mesa/main/shader_que

[Mesa-dev] [PATCH 01/16] glsl: Add typed foreach_in_list/_reverse macros.

--- src/glsl/list.h | 10 ++ 1 file changed, 10 insertions(+) diff --git a/src/glsl/list.h b/src/glsl/list.h index 576bc14..914ce96 100644 --- a/src/glsl/list.h +++ b/src/glsl/list.h @@ -573,6 +573,16 @@ inline void exec_node::insert_before(exec_list *before) ; (__node)->next != N

[Mesa-dev] [PATCH 02/16] glsl: Add typed foreach_in_list_safe macro.

--- src/glsl/list.h | 9 + 1 file changed, 9 insertions(+) diff --git a/src/glsl/list.h b/src/glsl/list.h index 914ce96..a4c6408 100644 --- a/src/glsl/list.h +++ b/src/glsl/list.h @@ -584,6 +584,15 @@ inline void exec_node::insert_before(exec_list *before) (__inst) = (__type *)(_

[Mesa-dev] [PATCH 08/16] glsl: Replace another couple uses of foreach_list.

--- src/glsl/ir_reader.cpp | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/src/glsl/ir_reader.cpp b/src/glsl/ir_reader.cpp index cc87edc..57c51a7 100644 --- a/src/glsl/ir_reader.cpp +++ b/src/glsl/ir_reader.cpp @@ -170,9 +170,8 @@ ir_reader::scan_for_prototypes(exec_

[Mesa-dev] [PATCH 09/16] glsl: Replace uses of foreach_list_const.

--- src/glsl/ir_clone.cpp | 16 src/glsl/link_functions.cpp | 7 ++- 2 files changed, 6 insertions(+), 17 deletions(-) diff --git a/src/glsl/ir_clone.cpp b/src/glsl/ir_clone.cpp index 86a6205..4b444d4 100644 --- a/src/glsl/ir_clone.cpp +++ b/src/glsl/ir_clone.cpp @@ -2

[Mesa-dev] [PATCH 06/16] mesa: Use typed foreach_in_list_safe instead of foreach_list_safe.

--- src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/mesa/state_tracker/st_glsl_to_tgsi.cpp b/src/mesa/state_tracker/st_glsl_to_tgsi.cpp index a5aec5b..00d16cf 100644 --- a/src/mesa/state_tracker/st_glsl_to_tgsi.cpp +++ b/src/me

[Mesa-dev] [PATCH 11/16] mesa: Add and use foreach_list_typed_safe.

--- src/glsl/list.h | 9 + src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 4 +--- 2 files changed, 10 insertions(+), 3 deletions(-) diff --git a/src/glsl/list.h b/src/glsl/list.h index 77e3aaf..b7221cb 100644 --- a/src/glsl/list.h +++ b/src/glsl/list.h @@ -6

[Mesa-dev] [PATCH 10/16] mesa: Add and use foreach_in_list_use_after.

--- src/glsl/list.h| 5 + src/mesa/drivers/dri/i965/brw_fs_cse.cpp | 5 + src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 6 +- 3 files changed, 7 insertions(+), 9 deletions(-) diff --git a/src/glsl/list.h b/src/glsl/list.h index a4c6408..77e3aaf 100644 ---

[Mesa-dev] [PATCH 05/16] glsl: Use typed foreach_in_list_safe instead of foreach_list_safe.

--- src/glsl/ast_function.cpp | 14 -- src/glsl/ast_to_hir.cpp | 12 ++-- src/glsl/ir.cpp | 4 ++-- src/glsl/ir_function_detect_recursion.cpp | 8 +++- src/glsl/ir_hv_accept.cpp | 3 +--

[Mesa-dev] [PATCH 13/16] i965: Add and use foreach_inst_in_block macros.

--- src/mesa/drivers/dri/i965/brw_cfg.h | 10 ++ src/mesa/drivers/dri/i965/brw_fs_copy_propagation.cpp | 9 ++--- src/mesa/drivers/dri/i965/brw_fs_cse.cpp | 5 + src/mesa/drivers/dri/i965/brw_fs_dead_code_eliminate.cpp | 4 +--- src/me

[Mesa-dev] [PATCH 14/16] i965: Use typed foreach_in_list instead of foreach_list.

--- src/mesa/drivers/dri/i965/brw_cfg.cpp | 4 +- src/mesa/drivers/dri/i965/brw_fs.cpp | 48 ++ .../drivers/dri/i965/brw_fs_copy_propagation.cpp | 10 ++--- src/mesa/drivers/dri/i965/brw_fs_generator.cpp | 6 +-- src/mesa/drivers/dri/i965/brw_

[Mesa-dev] [PATCH 16/16] glsl: Remove now unused foreach_list* macros.

foreach_list_typed_const was never used as far as I can tell. --- src/glsl/list.h | 24 1 file changed, 24 deletions(-) diff --git a/src/glsl/list.h b/src/glsl/list.h index b7221cb..922bd68 100644 --- a/src/glsl/list.h +++ b/src/glsl/list.h @@ -560,19 +560,6 @@ inline voi

[Mesa-dev] [PATCH 12/16] i965/fs: Use is_head_sentinel() instead of ->prev == NULL.

Makes it more clear what we're doing and requires less knowledge of exec_list. --- src/mesa/drivers/dri/i965/brw_fs.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/brw_fs.cpp b/src/mesa/drivers/dri/i965/brw_fs.cpp index 185a1f6..3dd5c0e 100644 ---

[Mesa-dev] [PATCH 07/16] glsl: Use foreach_list_typed when possible.

--- src/glsl/ast_function.cpp | 6 ++ src/glsl/ast_to_hir.cpp | 2 +- src/glsl/glsl_parser_extras.cpp | 41 +++-- 3 files changed, 18 insertions(+), 31 deletions(-) diff --git a/src/glsl/ast_function.cpp b/src/glsl/ast_function.cpp index b4c

[Mesa-dev] [PATCH 15/16] i965: Use typed foreach_in_list_safe instead of foreach_list_safe.

--- src/mesa/drivers/dri/i965/brw_fs.cpp | 24 ++ .../drivers/dri/i965/brw_fs_copy_propagation.cpp | 7 ++- src/mesa/drivers/dri/i965/brw_fs_cse.cpp | 4 +--- .../dri/i965/brw_fs_dead_code_eliminate.cpp| 4 +--- .../drivers/dri/i965/brw_

[Mesa-dev] [PATCH 00/16] Replace foreach_list macros with macros that take the iterator type

Throughout the compiler bits of Mesa, we used a list-walking pattern that looked like: foreach_list(node, list) { actual_type *thing = (actual_type *)node; ... } Instead, just make the macros take the types of the iterator and perform the cast themselves: foreach_in_list(fs_inst, inst, &i

Re: [Mesa-dev] [PATCH 1/6] mesa: Add Pixman library to configure.ac

On Wed, Jun 25, 2014 at 5:38 AM, Juha-Pekka Heikkila wrote: > Added '--enable-pixman' (default=no) parameter for autogen > and corresponding behaviour to include paths and Pixman > library for Mesa if Pixman found. > > Signed-off-by: Juha-Pekka Heikkila > --- > configure.ac | 32

Re: [Mesa-dev] [PATCH 0/6] Enable Pixman for Mesa

On Wed, Jun 25, 2014 at 5:38 AM, Juha-Pekka Heikkila wrote: > This is my old set which enable using Pixman on Mesa for some texture > conversion fast paths. As is this passes Piglit quick set on my IVB. Pixman doesn't actually have fast paths for swizzling, like we're using in this series. I imag

Re: [Mesa-dev] [PATCH 2/6] mesa: Add Pixman usage to texstore.c

On Wed, Jun 25, 2014 at 5:38 AM, Juha-Pekka Heikkila wrote: > This patch adds 'pixman_texture_conversion' function which will > be used by following patches for converting textures between > different pixel formats. > > Signed-off-by: Juha-Pekka Heikkila > --- > src/mesa/main/texstore.c | 65 >

Re: [Mesa-dev] [PATCH 1/6] mesa: Add Pixman library to configure.ac

On Wed, Jun 25, 2014 at 1:20 PM, Matt Turner wrote: > On Wed, Jun 25, 2014 at 5:38 AM, Juha-Pekka Heikkila > wrote: >> Added '--enable-pixman' (default=no) parameter for autogen >> and corresponding behaviour to include paths and Pixman >> library for Mesa if Pixman found. >> >> Signed-off-by: Ju

[Mesa-dev] [PATCH 1/4] i965/vec4: Add basic common subexpression elimination.

From: Kenneth Graunke [mattst88]: Modified to perform CSE on instructions with the same writemask. Offered no improvement before. total instructions in shared programs: 1995633 -> 1995185 (-0.02%) instructions in affected programs: 14410 -> 13962 (-3.11%) Reviewed-by: Matt Turne

[Mesa-dev] [PATCH 2/4] i965/vec4: Improve CSE performance by expiring some available expressions.

Port of commit 5daf867f to the vec4 code. --- src/mesa/drivers/dri/i965/brw_vec4_cse.cpp | 20 1 file changed, 20 insertions(+) diff --git a/src/mesa/drivers/dri/i965/brw_vec4_cse.cpp b/src/mesa/drivers/dri/i965/brw_vec4_cse.cpp index 33c7430..67fc58a 100644 --- a/src/mesa/d

[Mesa-dev] [PATCH 3/4] i965/vec4: Don't emit null MOVs in CSE.

Port of commit 219b43c6 to the vec4 code. --- src/mesa/drivers/dri/i965/brw_vec4_cse.cpp | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_vec4_cse.cpp b/src/mesa/drivers/dri/i965/brw_vec4_cse.cpp index 67fc58a..8013517 100644 --- a/src

[Mesa-dev] [PATCH 4/4] i965/vec4: Perform CSE on CMP(N) instructions.

Port of commit b16b3c87 to the vec4 code. No shader-db improvements, but might as well. The fs backend saw an improvement because it's scalar and multiple identical CMP instructions were generated by the SEL peepholes. --- src/mesa/drivers/dri/i965/brw_vec4_cse.cpp | 17 - 1 file

Re: [Mesa-dev] [PATCH] glxinfo: Print XFB, TBO, and UBO limits

On 06/23/2014 11:31 AM, Ilia Mirkin wrote: On Mon, Jun 23, 2014 at 9:48 AM, Brian Paul wrote: From: Fredrik Höglund Updated patch for refactored glxinfo/wglinfo code by Brian Paul. There were more patches that added more things... https://urldefense.proofpoint.com/v1/url?u=http://patchwork.

[Mesa-dev] [Bug 80541] New: [softpipe] piglit levelclamp regression

https://bugs.freedesktop.org/show_bug.cgi?id=80541 Priority: medium Bug ID: 80541 Keywords: regression CC: mar...@gmail.com, srol...@vmware.com Assignee: mesa-dev@lists.freedesktop.org Summary: [softpipe] piglit levelclamp regres

Re: [Mesa-dev] [PATCH] glsl: Don't convert reductions of ivec to a dot-product

Reviewed-by: Christoph Brill Am 25.06.2014 04:15 schrieb "Ian Romanick" : > From: Ian Romanick > > Mesa has an optimization that converts expressions like "v.x + v.y + v.z > + v.w" into dot(v, 1.0). And therein lies the rub: the other operand to > the dot-product is always a float... even if th

[Mesa-dev] [PATCH] softpipe: use last_level from sampler view, not from the resource

From: Roland Scheidegger The last_level from the sampler view may be limited by the state tracker to a value lower than what the base texture provides. Fixes https://bugs.freedesktop.org/show_bug.cgi?id=80541. --- src/gallium/drivers/softpipe/sp_tex_sample.c | 39 ++-- 1

[Mesa-dev] [PATCH v3] i965: Implement GL_PRIMITIVES_GENERATED with non-zero streams.

So far we have been using CL_INVOCATION_COUNT to resolve this query but this is no good with streams, as only stream 0 reaches the clipping stage. Instead we will use SO_PRIM_STORAGE_NEEDED which can keep track of the primitives sent to each individual stream. Since SO_PRIM_STORAGE_NEEDED is relat