[Mesa-dev] [PATCH] Add an ir_triop_mid3 expression and lower it to mins and maxs.

If mid3 is called with two constants, the resulting IR was two maxes and three mins, when one max and one min would have sufficed. Make mid3() produce an ir_expression with ir_triop_mid3 (new ir_expression operation) and lower it in a lower_instructions pass to the needed amount of mins and maxs.

Re: [Mesa-dev] [PATCH] Add an ir_triop_mid3 expression and lower it to mins and maxs.

Just noticed that this obviously conflicts with Ilia Mirkin's patches for lowering of carry/borrow. I'll rebase and resend once those land. -- Petri Latvala ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman

Re: [Mesa-dev] [PATCH] R600/SI: allow 4 more input SGPRs to a shader

Also, I think it would be a good idea to add the maximum possible number or registers to the calling convention (i.e. the number or register we would use if all inputs are enabled and all user sgprs are being used). Well that's what we did previously, unfortunately it wasn't adopted when we add

Re: [Mesa-dev] [PATCH v2 1/1] clover: Align kernel argument sizes to nearest power of 2

Francisco Jerez writes: > Jan Vesely writes: > >> v2: use a new variable for aligned size >> add comment >> make both vars const >> only use the aligned value in argument constructors >> fix comment typo >> >> Signed-off-by: Jan Vesely > > Looks good to me, thanks, > Reviewed-by

Re: [Mesa-dev] [PATCH 1/1] clover: Add clEnqueue{Marker, Barrier}WithWaitList

EdB writes: > --- > src/gallium/state_trackers/clover/api/dispatch.cpp | 4 +- > src/gallium/state_trackers/clover/api/event.cpp| 46 > +++--- > 2 files changed, 43 insertions(+), 7 deletions(-) > > diff --git a/src/gallium/state_trackers/clover/api/dispatch.cpp > b/src/gal

Re: [Mesa-dev] [PATCH] clover : Implement sub-devices

EdB writes: > The implementation is basically a NOP > but it conforms with OpenCL 1.2 > > As before, it needed CL 1.2 headers Pushed with a couple of minor-ish fixes [1]. [1] http://cgit.freedesktop.org/mesa/mesa/commit/?id=7fb05f929802bf32391e416ceb62a34b4571905c > --- > src/gallium/state_t

[Mesa-dev] [PATCH] i965: Make intel_texsubimage_tiled_memcpy compile with Clang.

Apparently Clang needs an extra #include, and doesn't understand __attribute__((flatten)). Marking the helper functions as always_inline works just as well, and actually compiles with Clang. Signed-off-by: Kenneth Graunke --- src/mesa/drivers/dri/i965/intel_tex_subimage.c | 17 ++---

Re: [Mesa-dev] [PATCH] i965: Make intel_texsubimage_tiled_memcpy compile with Clang.

On Tue, Apr 29, 2014 at 11:38 AM, Kenneth Graunke wrote: > Apparently Clang needs an extra #include, and doesn't understand > __attribute__((flatten)). Marking the helper functions as > always_inline works just as well, and actually compiles with Clang. > > Signed-off-by: Kenneth Graunke > --- >

Re: [Mesa-dev] [PATCH] Add an ir_triop_mid3 expression and lower it to mins and maxs.

On Tue, Apr 29, 2014 at 9:15 AM, Petri Latvala wrote: > Just noticed that this obviously conflicts with Ilia Mirkin's patches for > lowering of carry/borrow. I'll rebase and resend once those land. I'm still waiting for a review on my 2/2, so whoever lands second will be doing the rebase. I don't

Re: [Mesa-dev] [PATCH 2/2] i965: Disable Z16 in all APIs.

On Mon, Apr 14, 2014 at 03:04:12PM -0700, Kenneth Graunke wrote: > On 04/14/2014 06:30 AM, Chia-I Wu wrote: > > On Mon, Apr 14, 2014 at 1:04 PM, Kenneth Graunke > > wrote: > >> We originally thought that GL 3.0 required GL_DEPTH_COMPONENT16 to map > >> exactly to Z16. However, we misread the spe

Re: [Mesa-dev] [PATCH] i965: Make Broadwell HiZ path arrange for TC flushes.

On Mon, Apr 21, 2014 at 02:08:49PM -0700, Kenneth Graunke wrote: > HiZ operations make the depth/render caches out of sync with the sampler > caches. We need to arrange for a TC flush to happen before the target > buffer is used by the sampler. Calling brw_render_cache_set_add_bo > makes that hap

Re: [Mesa-dev] [PATCH] Add an ir_triop_mid3 expression and lower it to mins and maxs.

On Tue, Apr 29, 2014 at 6:01 AM, Petri Latvala wrote: > If mid3 is called with two constants, the resulting IR was two maxes and three > mins, when one max and one min would have sufficed. Make mid3() produce an > ir_expression with ir_triop_mid3 (new ir_expression operation) and lower it in > a l

Re: [Mesa-dev] [PATCH] i965: Make intel_texsubimage_tiled_memcpy compile with Clang.

On Tue, Apr 29, 2014 at 8:38 AM, Kenneth Graunke wrote: > Apparently Clang needs an extra #include, and doesn't understand > __attribute__((flatten)). Marking the helper functions as > always_inline works just as well, and actually compiles with Clang. > > Signed-off-by: Kenneth Graunke > --- >

Re: [Mesa-dev] intel, dma-buf import and egl image external

On Mon, Mar 24, 2014 at 09:07:32AM +1000, Dave Airlie wrote: > On Sat, Mar 8, 2014 at 12:13 AM, Pohjolainen, Topi > wrote: > > On Mon, Mar 03, 2014 at 01:19:48PM +1000, Dave Airlie wrote: > >> There is a comment and two checks in the i965 dma-buf importer, > >> > >> * Images originating via EGL_EX

Re: [Mesa-dev] [PATCH] clover : Implement sub-devices

On Tuesday, April 29, 2014 04:21:35 PM Francisco Jerez wrote: > EdB writes: > > The implementation is basically a NOP > > but it conforms with OpenCL 1.2 > > > > As before, it needed CL 1.2 headers > > Pushed with a couple of minor-ish fixes [1]. > > [1] > http://cgit.freedesktop.org/mesa/mesa/

Re: [Mesa-dev] intel, dma-buf import and egl image external

Chad Versace writes: > On Mon, Mar 24, 2014 at 09:07:32AM +1000, Dave Airlie wrote: >> On Sat, Mar 8, 2014 at 12:13 AM, Pohjolainen, Topi >> wrote: >> > On Mon, Mar 03, 2014 at 01:19:48PM +1000, Dave Airlie wrote: >> >> There is a comment and two checks in the i965 dma-buf importer, >> >> >> >>

[Mesa-dev] [Bug 78095] New: Mesa: --enable-llvm-shared-libs option only works if it's omitted

https://bugs.freedesktop.org/show_bug.cgi?id=78095 Priority: medium Bug ID: 78095 Assignee: mesa-dev@lists.freedesktop.org Summary: Mesa: --enable-llvm-shared-libs option only works if it's omitted Severity: normal Classi

[Mesa-dev] [Bug 78095] Mesa: --enable-llvm-shared-libs option only works if it's omitted

https://bugs.freedesktop.org/show_bug.cgi?id=78095 --- Comment #1 from Erich Seifert --- Created attachment 98195 --> https://bugs.freedesktop.org/attachment.cgi?id=98195&action=edit mesa-10.1.1-llvm-shared-libs.patch Added a patch which tries to fix llvm-shared-libs. It assigns the variable e

[Mesa-dev] [Bug 78095] Mesa: --enable-llvm-shared-libs option only works if it's omitted

https://bugs.freedesktop.org/show_bug.cgi?id=78095 Erich Seifert changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[Mesa-dev] [PATCH] i965: Actually emit PIPELINE_SELECT and 3DSTATE_VF_STATISTICS.

For platforms using hardware contexts (currently Gen6+), we failed to emit PIPELINE_SELECT and 3DSTATE_VF_STATISTICS, instead emitting MI_NOOP for both. During one of the context initialization reordering patches, we accidentally moved brw_init_state before we set brw->CMD_PIPELINE_SELECT and brw-

Re: [Mesa-dev] [PATCH] i965: Actually emit PIPELINE_SELECT and 3DSTATE_VF_STATISTICS.

Kenneth Graunke writes: > For platforms using hardware contexts (currently Gen6+), we failed to > emit PIPELINE_SELECT and 3DSTATE_VF_STATISTICS, instead emitting MI_NOOP > for both. > > During one of the context initialization reordering patches, we > accidentally moved brw_init_state before we

Re: [Mesa-dev] Undefined reference in libGLES when shared glapi is disabled

On Tue, Apr 29, 2014 at 02:04:25AM +0100, Emil Velikov wrote: > On 28/04/14 22:56, Eric Le Bihan wrote: > > Hi! > > > > I'm currently cross-compiling Mesa3d for embedded systems using the > > following configure options: > > > > --enable-shared --disable-glx --disable-xa --disable-static > > --w

[Mesa-dev] Question: glsl shader input/output for arrays of arrays

Hi all, First of all sorry for the newbie question but I'm having trouble figuring out what I need to do next for the arrays of arrays implementation. I'm just looking for some quick pointers in the right direction. I'm currently looking at what needs to be done to update ir_set_program_inout

[Mesa-dev] [Bug 78097] New: glUniform1ui and friends not supported by display lists

https://bugs.freedesktop.org/show_bug.cgi?id=78097 Priority: medium Bug ID: 78097 Assignee: mesa-dev@lists.freedesktop.org Summary: glUniform1ui and friends not supported by display lists Severity: normal Classification:

[Mesa-dev] [PATCH 01/18] i965: Reuse intel_miptree_get_tile_offsets().

--- src/mesa/drivers/dri/i965/intel_screen.c | 15 +++ 1 file changed, 3 insertions(+), 12 deletions(-) diff --git a/src/mesa/drivers/dri/i965/intel_screen.c b/src/mesa/drivers/dri/i965/intel_screen.c index 3b2e4e9..46a7e3b 100644 --- a/src/mesa/drivers/dri/i965/intel_screen.c +++ b/

[Mesa-dev] [PATCH 10/18] i965: Make intel_set_texture_region just take a BO and pitch.

I want to do this to get the region removed from DRI images. However, it does mean that we won't share the intel_region between the rb and the texture for texture_from_pixmap. I think that's fine. --- src/mesa/drivers/dri/i965/intel_tex_image.c | 56 ++--- 1 file changed,

[Mesa-dev] [PATCH 13/18] i965: Fix intel_bufferobj_buffer range for blit drawpixels.

If the stride wasn't width*cpp, we wouldn't track how much of the src is busy, and allow a subdata into the end to proceed unsynchronized. --- src/mesa/drivers/dri/i965/intel_pixel_draw.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/mesa/drivers/dri/i965/intel_pixel

[Mesa-dev] [PATCH 04/18] i965: Move intel_region_get_tile_offsets() to be a miptree function.

All the consumers are doing it on a miptree. --- src/mesa/drivers/dri/i965/brw_blorp.cpp | 3 +-- src/mesa/drivers/dri/i965/brw_misc_state.c| 14 +-- src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 35 ++- src/mesa/drivers/dri/i965/intel_mipmap_tree.h |

[Mesa-dev] [PATCH 07/18] i965: Drop the tiling argument to intel_miptree_create_for_bo.

The drm function to get the tiling is just a getter storing the two pointers, so we don't need to go out of our way to avoid it. --- src/mesa/drivers/dri/i965/intel_fbo.c | 3 +-- src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 9 + src/mesa/drivers/dri/i965/intel_mipmap_tree.h | 3

[Mesa-dev] [PATCH 17/18] i965: Rename intel_regions.h to something more appropriate now.

We had the EGLimage structure laying around in intel_regions.h, but now it's the only thing left in the file. --- src/mesa/drivers/dri/i965/brw_context.c| 2 +- src/mesa/drivers/dri/i965/intel_fbo.c | 2 +- src/mesa/drivers/dri/i965/intel_image.h| 109 +

[Mesa-dev] [PATCH 15/18] i965: Drop region usage from DRI2 winsys-allocated buffers.

--- src/mesa/drivers/dri/i965/intel_screen.c | 30 +- 1 file changed, 17 insertions(+), 13 deletions(-) diff --git a/src/mesa/drivers/dri/i965/intel_screen.c b/src/mesa/drivers/dri/i965/intel_screen.c index ab95a39..454f1cb 100644 --- a/src/mesa/drivers/dri/i965/intel

[Mesa-dev] [PATCH 14/18] i965: Drop a funny assert about mt pitch.

I slipped this in in the region->pitch change from pixels to bytes, but I don't see any reason for it any more -- the libdrm code doesn't appear to divide pitch by a cpp. --- src/mesa/drivers/dri/i965/intel_screen.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/intel

[Mesa-dev] i965: no more regions!

Here's the series for removing struct intel_region from the i965 driver. I think it's worth it for the code savings and reduced steps in allocating a miptree. Plus, it gave me a chance to rewrite some comments about the driver. It's a longer series than I wanted, but there are some nice little cl

[Mesa-dev] [PATCH 16/18] i965: Delete the intel_regions.c code.

--- src/mesa/drivers/dri/i965/Makefile.sources| 1 - src/mesa/drivers/dri/i965/brw_clear.c | 1 - src/mesa/drivers/dri/i965/brw_curbe.c | 1 - src/mesa/drivers/dri/i965/brw_draw.c | 1 - src/mesa/drivers/dri/i965/brw_misc_state.c| 1 - src/mesa/drivers/dr

[Mesa-dev] [PATCH 05/18] i965: Move intel_region_get_aligned_offset() to be a miptree function.

All the consumers are doing it on a miptree. --- src/mesa/drivers/dri/i965/brw_blorp.cpp | 7 ++-- src/mesa/drivers/dri/i965/brw_misc_state.c| 17 +- src/mesa/drivers/dri/i965/gen6_blorp.cpp | 18 +- src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 49 +++

[Mesa-dev] [PATCH 09/18] i965: Stop making a pointless region for DRI2 to just throw it away.

I noticed that we were doing this while changing the DRI3 path to not use regions, which involved changing the signature of intel_update_winsys_renderbuffer_miptree() this way. --- src/mesa/drivers/dri/i965/brw_context.c | 32 +-- src/mesa/drivers/dri/i965/intel_mipma

[Mesa-dev] [PATCH 02/18] i965: Fix offset-aligned-to-tile test in dma_buf import.

v1 of the patch got pushed, insted of the v2 that I had reviewed. --- src/mesa/drivers/dri/i965/intel_screen.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/mesa/drivers/dri/i965/intel_screen.c b/src/mesa/drivers/dri/i965/intel_screen.c index 46a7e3b..d708efe 100644 -

[Mesa-dev] [PATCH 18/18] i965: Fix the file comment for intel_image.h

--- src/mesa/drivers/dri/i965/intel_image.h | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/src/mesa/drivers/dri/i965/intel_image.h b/src/mesa/drivers/dri/i965/intel_image.h index ba3ed27..0cae711 100644 --- a/src/mesa/drivers/dri/i965/intel_image.h +++ b/src/mes

[Mesa-dev] [PATCH 06/18] i965: Drop pointless cast of texObj to intelObj.

--- src/mesa/drivers/dri/i965/intel_tex_image.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/mesa/drivers/dri/i965/intel_tex_image.c b/src/mesa/drivers/dri/i965/intel_tex_image.c index ee02e68..c225e4e 100644 --- a/src/mesa/drivers/dri/i965/intel_tex_image.c +++ b/sr

[Mesa-dev] [PATCH 08/18] i965: Drop the global GEM name from regions.

Once a buffer has been named, drm_intel_bo_flink() is just a getter. --- src/mesa/drivers/dri/i965/brw_context.c | 11 ++- src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 2 -- src/mesa/drivers/dri/i965/intel_regions.c | 15 --- src/mesa/drivers/dri/i965/intel_region

[Mesa-dev] [PATCH 03/18] i965: Fix another broken offset-aligned-to-tile test.

--- src/mesa/drivers/dri/i965/intel_screen.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/mesa/drivers/dri/i965/intel_screen.c b/src/mesa/drivers/dri/i965/intel_screen.c index d708efe..81c91ec 100644 --- a/src/mesa/drivers/dri/i965/intel_screen.c +++ b/src/mesa/drive

[Mesa-dev] [PATCH 11/18] i965: Replace the region in DRIimage with just a BO pointer and stride.

Regions aren't refcounted safely for multithreaded applications, and they're not terribly useful wrappers of a BO, so I'm trying to remove them. Even the stride I added here could probably be reduced to use of an existing field in the __DRIimageRec, but I want this to be as mechanical of a change

Re: [Mesa-dev] [PATCH 02/19] mesa: Add a _BoundTextures field in gl_texture_unit

On Monday 28 April 2014, Ian Romanick wrote: > On 04/21/2014 02:57 PM, Fredrik Höglund wrote: > > This will be used by glBindTextures() when unbinding textures, > > to avoid having to loop over all the targets. > > --- > > > > v2: Use &= ~(1 << index) to clear bits > > > > src/mesa/main/mtypes.h

Re: [Mesa-dev] [PATCH 00/19] Implement GL_ARB_multi_bind v2

On Monday 28 April 2014, Ian Romanick wrote: > On 04/21/2014 02:57 PM, Fredrik Höglund wrote: > > So here is version two of the ARB_multi_bind series. > > > > This incorporates feedback from Brian, Matt and Francisco, and also > > fixes an issue I happened to notice myself. It occurred to me that

[Mesa-dev] [PATCH v3 11/19] mesa: Add helper functions for looking up multiple buffers

--- v2: Document the difference between _mesa_lookup_bufferobj() and _mesa_multi_bind_lookup_bufferobj(). v3: Don't create buffer objects if they don't exist. I was looking at the GL 4.4 specification and happened to notice something I had overlooked; unlike glBindBuffer[Base/Range], the glBi

Re: [Mesa-dev] [PATCH] i965: Actually emit PIPELINE_SELECT and 3DSTATE_VF_STATISTICS.

On Tue, Apr 29, 2014 at 02:39:30PM -0700, Kenneth Graunke wrote: > For platforms using hardware contexts (currently Gen6+), we failed to > emit PIPELINE_SELECT and 3DSTATE_VF_STATISTICS, instead emitting MI_NOOP > for both. > > During one of the context initialization reordering patches, we > acci

[Mesa-dev] [PATCH 15/21] linker: Modify cross_validate_outputs_to_inputs to match using explicit locations

From: Ian Romanick This will be used for GL_ARB_separate_shader_objects. That extension not only allows separable shaders to rendezvous by location, but it also allows traditionally linked shaders to rendezvous by location. The spec says: 36. How does the behavior of input/output interface

[Mesa-dev] [PATCH 20/21] mesa: Enable GL_EXT_separate_shader_objects for OpenGL ES

From: Ian Romanick Signed-off-by: Ian Romanick --- src/glsl/glcpp/glcpp-parse.y | 1 + src/glsl/glsl_parser_extras.cpp| 1 + src/glsl/glsl_parser_extras.h | 8 +- src/glsl/linker.cpp| 3 +- sr

[Mesa-dev] [PATCH 11/21] linker: Assign varying locations for separable programs

From: Ian Romanick Signed-off-by: Ian Romanick --- src/glsl/link_varyings.cpp | 17 + src/glsl/linker.cpp| 16 +--- 2 files changed, 30 insertions(+), 3 deletions(-) diff --git a/src/glsl/link_varyings.cpp b/src/glsl/link_varyings.cpp index 8982332..85a8b90

[Mesa-dev] [PATCH 03/21] linker: Make lower_packed_varyings work with explicit locations

From: Ian Romanick Don't do anything with variables that have explicitly assigned locations. This is also how built-in varyings are handled. Signed-off-by: Ian Romanick --- src/glsl/lower_packed_varyings.cpp | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/glsl/lo

[Mesa-dev] [PATCH 21/21] mesa: Eliminate gl_shader_program::InternalSeparateShader

From: Ian Romanick This was a work-around to allow linking a program with only a fragment shader in a GLES context. Now that we have GL_EXT_separate_shader_objects in GLES contexts, we can just use that. Signed-off-by: Ian Romanick --- src/glsl/linker.cpp | 3 +-- src/mesa/m

[Mesa-dev] [PATCH 19/21] glsl: Sort the list of extensions

From: Ian Romanick ARB, OES, then everything else. If there's ever a KHR shading language extension, it should go between ARB and OES. Signed-off-by: Ian Romanick --- src/glsl/glsl_parser_extras.cpp | 52 +- src/glsl/glsl_parser_extras.h | 95 +++-

[Mesa-dev] [PATCH 04/21] mesa/sso: Refactor new function _mesa_bind_pipeline

From: Ian Romanick Pull most of the guts out of _mesa_BindPipeline into a new utility function that can be use elsewhere (e.g., meta). Signed-off-by: Ian Romanick Reviewed-by: Kenneth Graunke Reviewed-by: Eric Anholt --- src/mesa/main/pipelineobj.c | 13 ++--- src/mesa/main/pipelineo

[Mesa-dev] [00/21] Last of SSO, take 47

A lot the patches in this series were slightly reworked to incorporate Eric's feedback (remove ir_variable::user_location) on the previous attempt. Other than that change, I patch 1 is new, and patch 16 adds previously missing display list support. ___

[Mesa-dev] [PATCH 12/21] linker: Allow geometry shader without vertex shader for separable programs

From: Ian Romanick Signed-off-by: Ian Romanick Reviewed-by: Eric Anholt --- src/glsl/linker.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/glsl/linker.cpp b/src/glsl/linker.cpp index f631fdf..18d7bfc 100644 --- a/src/glsl/linker.cpp +++ b/src/glsl/linker.cpp @@ -

[Mesa-dev] [PATCH 08/21] glsl: Exit when the shader IR contains an interface block instance

From: Ian Romanick While writing the link_varyings::single_interface_input test, I discovered that populate_consumer_input_sets assumes that all shader interface blocks have been lowered to discrete variables. Since there is a pass that does this, it is a reasonable assumption. It was, however,

[Mesa-dev] [PATCH 02/21] glsl: Remove varying "base" parameters

From: Ian Romanick In February 2013 Paul unified the values used for shader stage outputs and shader stage inputs. See commits 8a076c5f0^..eed6baf76. Since that time, the location_base parameters are always VARYING_SLOT_VAR0. Instead of passing that around, just hard code it. Signed-off-by: Ia

[Mesa-dev] [PATCH 17/21] mesa/sso: Enable GL_ARB_separate_shader_objects by default

From: Ian Romanick Signed-off-by: Ian Romanick --- src/glsl/glcpp/glcpp-parse.y | 4 +--- src/glsl/glsl_parser_extras.cpp | 2 +- src/mesa/drivers/common/meta.c | 19 --- src/mesa/main/extensions.c | 2 +- src/mesa/main/get.c | 1 - src/mesa/main/ge

[Mesa-dev] [PATCH 01/21] glsl: Constify parameter to a couple varying_matches methods

From: Ian Romanick Signed-off-by: Ian Romanick Reviewed-by: Kenneth Graunke --- src/glsl/link_varyings.cpp | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/glsl/link_varyings.cpp b/src/glsl/link_varyings.cpp index c925c00..a9b15f6 100644 --- a/src/glsl/link_varyi

[Mesa-dev] [PATCH 16/21] sso: Add display list support for ARB_separate_shader_objects new functions

From: Ian Romanick With this patch, the piglit arb_separate_shader_object-dlist test passes. Signed-off-by: Ian Romanick --- src/mesa/main/dlist.c | 911 ++ 1 file changed, 911 insertions(+) diff --git a/src/mesa/main/dlist.c b/src/mesa/main/dli

[Mesa-dev] [PATCH 06/21] linker: Refactor code that builds hash tables of varyings during linking

From: Ian Romanick I want to make some changes to this code, but first I want to make some unit tests for it... so that I can capture the pre- and post-invariants. Pulling the code out into its own function in a non-anonymous namespace enables that. Signed-off-by: Ian Romanick Reviewed-by: Ken

[Mesa-dev] [PATCH 05/21] meta: Fix saving the program pipeline state

From: Ian Romanick This code was broken in some odd ways before. Too much state was being saved, it was being restored in the wrong order, and in the wrong way. The biggest problem was that the pipeline object was restored before restoring the programs attached to the default pipeline. Fixes a

[Mesa-dev] [PATCH 14/21] linker: Sort shader I/O variables into a canonical order

From: Ian Romanick v2: Rebase on removal of ir_variable::user_location. Signed-off-by: Ian Romanick --- src/glsl/link_varyings.cpp | 78 +++--- 1 file changed, 74 insertions(+), 4 deletions(-) diff --git a/src/glsl/link_varyings.cpp b/src/glsl/link_vary

[Mesa-dev] [PATCH 10/21] linker: Allow consumer stage or producer stage to be NULL

From: Ian Romanick When linking a separable program that contains only a fragment shader, the producer will be NULL. Similar cases will exist with geometry shaders and, eventually, tessellation shaders. Signed-off-by: Ian Romanick Reviewed-by: Eric Anholt --- src/glsl/link_varyings.cpp | 71

[Mesa-dev] [PATCH 09/21] linker: Refactor code that gets an input matching an output

From: Ian Romanick Signed-off-by: Ian Romanick --- src/glsl/link_varyings.cpp | 51 - src/glsl/tests/varyings_test.cpp | 80 2 files changed, 114 insertions(+), 17 deletions(-) diff --git a/src/glsl/link_varyings.cpp b/src/

[Mesa-dev] [PATCH 07/21] glsl/tests: Add first simple tests of populate_consumer_input_sets

From: Ian Romanick Four initial tests: * Create an IR list with a single input variable and verify that variable is the only thing in the hash tables. * Same as the previous test, but use a built-in variable (gl_ClipDistance) with an explicit location set. * Create an IR list with a single

[Mesa-dev] [PATCH 13/21] glsl: Track explicitly set varying locations

From: Ian Romanick Signed-off-by: Ian Romanick --- src/glsl/ast_to_hir.cpp | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/glsl/ast_to_hir.cpp b/src/glsl/ast_to_hir.cpp index 0411bef..e1192ed 100644 --- a/src/glsl/ast_to_hir.cpp +++ b/src/glsl/ast_to_hir.cpp @@ -2268,6 +2268,8 @@ vali

[Mesa-dev] [PATCH 18/21] mesa: Remove support for desktop OpenGL GL_EXT_separate_shader_objects

From: Ian Romanick I don't know of any applications that actually use it. Now that Mesa supports GL_ARB_separate_shader_objects in all drivers, this extension is just cruft. The entrypoints for the extension remain in the XML. This is done so that a new libGL will continue to provide dispatch

Re: [Mesa-dev] [PATCH v2 2/2] egl: Add EGL_CHROMIUM_sync_control extension.

This patch looks good to me. Reviewed-by: Chad Versace On Thu, Apr 24, 2014 at 04:32:08PM -0700, Sarah Sharp wrote: > Chromium defined a new GL extension (that isn't registered with Khronos). > We need to add an EGL extension for it, so we can migrate ChromeOS on > Intel systems to use EGL instea

Re: [Mesa-dev] [PATCH v2 1/2] Import eglextchromium.h from Chromium.

On Thu, Apr 24, 2014 at 04:32:08PM -0700, Sarah Sharp wrote: > In order to support the (currently unregistered) Chromium-specific EGL > extension eglGetSyncValuesCHROMIUM on Intel systems, we need to import > the Chromium header that defines it. The file was downloaded from > > https://chromium.g

Re: [Mesa-dev] Question: glsl shader input/output for arrays of arrays

>Hi all, > >First of all sorry for the newbie question but I'm having trouble figuring out >what I need to do next for the >arrays of arrays implementation. I'm just >looking for some quick pointers in the right direction. > >I'm currently looking at what needs to be done to update >ir_set_p

Re: [Mesa-dev] [PATCH] i965: Actually emit PIPELINE_SELECT and 3DSTATE_VF_STATISTICS.

On 04/29/2014 05:42 PM, Ben Widawsky wrote: > On Tue, Apr 29, 2014 at 02:39:30PM -0700, Kenneth Graunke wrote: >> For platforms using hardware contexts (currently Gen6+), we failed to >> emit PIPELINE_SELECT and 3DSTATE_VF_STATISTICS, instead emitting MI_NOOP >> for both. >> >> During one of the co

Re: [Mesa-dev] [PATCH 05/21] meta: Fix saving the program pipeline state

On Wed, Apr 30, 2014 at 8:52 AM, Ian Romanick wrote: > From: Ian Romanick > > This code was broken in some odd ways before. Too much state was being > saved, it was being restored in the wrong order, and in the wrong way. > The biggest problem was that the pipeline object was restored before > r

[Mesa-dev] [PATCH] nvc0: treat non-linear 2DRect textures the same as 2D

This fixes textureGather(2DRect) piglit tests, and does not appear to have any adverse effects. Signed-off-by: Ilia Mirkin --- Not sure why the sampler would care whether it's 2D or 2DRect in the first place. But I think the only difference between a non-linear RECT texture and a 2D one are the

Re: [Mesa-dev] [PATCH 01/18] i965: Reuse intel_miptree_get_tile_offsets().

On Tue, Apr 29, 2014 at 4:34 PM, Eric Anholt wrote: Reviewed-by: Kristian Høgsberg > --- > src/mesa/drivers/dri/i965/intel_screen.c | 15 +++ > 1 file changed, 3 insertions(+), 12 deletions(-) > > diff --git a/src/mesa/drivers/dri/i965/intel_screen.c > b/src/mesa/drivers/dri/i965/

Re: [Mesa-dev] [PATCH 04/18] i965: Move intel_region_get_tile_offsets() to be a miptree function.

On Tue, Apr 29, 2014 at 4:34 PM, Eric Anholt wrote: > All the consumers are doing it on a miptree. Reviewed-by: Kristian Høgsberg > --- > src/mesa/drivers/dri/i965/brw_blorp.cpp | 3 +-- > src/mesa/drivers/dri/i965/brw_misc_state.c| 14 +-- > src/mesa/drivers/dri/i965/intel_

Re: [Mesa-dev] [PATCH 05/18] i965: Move intel_region_get_aligned_offset() to be a miptree function.

On Tue, Apr 29, 2014 at 4:34 PM, Eric Anholt wrote: > All the consumers are doing it on a miptree. Reviewed-by: Kristian Høgsberg > --- > src/mesa/drivers/dri/i965/brw_blorp.cpp | 7 ++-- > src/mesa/drivers/dri/i965/brw_misc_state.c| 17 +- > src/mesa/drivers/dri/i965/gen6_b

Re: [Mesa-dev] [PATCH 06/18] i965: Drop pointless cast of texObj to intelObj.

On Tue, Apr 29, 2014 at 4:34 PM, Eric Anholt wrote: Reviewed-by: Kristian Høgsberg > --- > src/mesa/drivers/dri/i965/intel_tex_image.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/src/mesa/drivers/dri/i965/intel_tex_image.c > b/src/mesa/drivers/dri/i965/intel_te

Re: [Mesa-dev] [PATCH 07/18] i965: Drop the tiling argument to intel_miptree_create_for_bo.

On Tue, Apr 29, 2014 at 4:34 PM, Eric Anholt wrote: > The drm function to get the tiling is just a getter storing the two > pointers, so we don't need to go out of our way to avoid it. Reviewed-by: Kristian Høgsberg > --- > src/mesa/drivers/dri/i965/intel_fbo.c | 3 +-- > src/mesa/driv

Re: [Mesa-dev] [PATCH 08/18] i965: Drop the global GEM name from regions.

On Tue, Apr 29, 2014 at 4:34 PM, Eric Anholt wrote: > Once a buffer has been named, drm_intel_bo_flink() is just a getter. Reviewed-by: Kristian Høgsberg > --- > src/mesa/drivers/dri/i965/brw_context.c | 11 ++- > src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 2 -- > src/mesa/

[Mesa-dev] [Bug 78101] New: [bisected] Mesa demos fails to link with drawtex.c:34: undefined reference to `glDrawTexfOES'

https://bugs.freedesktop.org/show_bug.cgi?id=78101 Priority: medium Bug ID: 78101 Assignee: mesa-dev@lists.freedesktop.org Summary: [bisected] Mesa demos fails to link with drawtex.c:34: undefined reference to `glDrawTexfOES'

Re: [Mesa-dev] [PATCH 09/18] i965: Stop making a pointless region for DRI2 to just throw it away.

On Tue, Apr 29, 2014 at 4:34 PM, Eric Anholt wrote: > I noticed that we were doing this while changing the DRI3 path to not use > regions, which involved changing the signature of > intel_update_winsys_renderbuffer_miptree() this way. Reviewed-by: Kristian Høgsberg > --- > src/mesa/drivers/dri

[Mesa-dev] [Bug 37470] OpenGL ES2 test, black screen and test crashes

https://bugs.freedesktop.org/show_bug.cgi?id=37470 Tapani Pälli changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

Re: [Mesa-dev] [PATCH 13/21] glsl: Track explicitly set varying locations

Looks like this patch should have been dropped with the removal of user_location? On Tue, 2014-04-29 at 17:52 -0700, Ian Romanick wrote: > From: Ian Romanick > > Signed-off-by: Ian Romanick > --- > src/glsl/ast_to_hir.cpp | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/src/glsl/ast

[Mesa-dev] [Bug 29844] (7.8.2) glGetActiveUniform incorrectly handles structs in shaders

https://bugs.freedesktop.org/show_bug.cgi?id=29844 Tapani Pälli changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

Re: [Mesa-dev] [PATCH 04/18] i965: Move intel_region_get_tile_offsets() to be a miptree function.

s/intel_region_get_tile_offsets/intel_region_get_tile_masks/ in the subject? On Wed, Apr 30, 2014 at 8:45 AM, Kristian Høgsberg wrote: > On Tue, Apr 29, 2014 at 4:34 PM, Eric Anholt wrote: >> All the consumers are doing it on a miptree. > > Reviewed-by: Kristian Høgsberg > >> --- >> src/mesa/d