Re: [Mesa-dev] [PATCH 3/5] i965: Add envvar to debug the optimization passes.

2014-04-13 Thread Kenneth Graunke
On 04/11/2014 10:29 PM, Matt Turner wrote: > --- > src/mesa/drivers/dri/i965/intel_debug.c | 1 + > src/mesa/drivers/dri/i965/intel_debug.h | 1 + > 2 files changed, 2 insertions(+) > > diff --git a/src/mesa/drivers/dri/i965/intel_debug.c > b/src/mesa/drivers/dri/i965/intel_debug.c > index dc742

Re: [Mesa-dev] [PATCH 4/5] i965: Let dump_instructions write to a file.

2014-04-13 Thread Kenneth Graunke
On 04/11/2014 10:29 PM, Matt Turner wrote: > --- > src/mesa/drivers/dri/i965/brw_fs.cpp | 129 > +- > src/mesa/drivers/dri/i965/brw_fs.h| 2 + > src/mesa/drivers/dri/i965/brw_fs_reg_allocate.cpp | 2 +- > src/mesa/drivers/dri/i965/brw_shader.cp

Re: [Mesa-dev] [PATCH 5/5] i965/fs: Debug the optimization passes by dumping instr to file.

2014-04-13 Thread Kenneth Graunke
On 04/11/2014 10:29 PM, Matt Turner wrote: > With INTEL_DEBUG=optimizer, write the output of dump_instructions() to a > file each time an optimization pass makes progress. This lets you easily > diff successive files to see what an optimization pass did. > > Example filenames written when running

Re: [Mesa-dev] [PATCH 1/5] dri: Expand driParseDebugString return value to uint64_t.

2014-04-13 Thread Kenneth Graunke
On 04/11/2014 10:29 PM, Matt Turner wrote: > Users will downcast if they don't have >32 debug flags. > --- > src/mesa/drivers/dri/common/utils.c | 7 +++ > src/mesa/drivers/dri/common/utils.h | 4 ++-- > 2 files changed, 5 insertions(+), 6 deletions(-) > > diff --git a/src/mesa/drivers/dri/co

Re: [Mesa-dev] [PATCH 4/5] i965: Let dump_instructions write to a file.

2014-04-13 Thread Matt Turner
On Sun, Apr 13, 2014 at 12:12 AM, Kenneth Graunke wrote: > On 04/11/2014 10:29 PM, Matt Turner wrote: >> --- >> src/mesa/drivers/dri/i965/brw_fs.cpp | 129 >> +- >> src/mesa/drivers/dri/i965/brw_fs.h| 2 + >> src/mesa/drivers/dri/i965/brw_fs_reg

Re: [Mesa-dev] [PATCH 5/5] i965/fs: Debug the optimization passes by dumping instr to file.

2014-04-13 Thread Matt Turner
On Sun, Apr 13, 2014 at 12:16 AM, Kenneth Graunke wrote: > On 04/11/2014 10:29 PM, Matt Turner wrote: >> With INTEL_DEBUG=optimizer, write the output of dump_instructions() to a >> file each time an optimization pass makes progress. This lets you easily >> diff successive files to see what an opti

Re: [Mesa-dev] [PATCH 01/10] winsys/radeon: remove cs_write_reloc, add simpler cs_get_reloc

2014-04-13 Thread Christian König
For this series: Reviewed-by: Christian König BTW: Can we get rid of RADEON_FLUSH_ASYNC and always flush asynchronously? Just calling cs_sync_flush directly after the flush should have the same effect as synchronous flushing. Christian. Am 12.04.2014 18:34, schrieb Marek Olšák: From: Marek

Re: [Mesa-dev] [PATCH 4/5] i965: Let dump_instructions write to a file.

2014-04-13 Thread Kenneth Graunke
On 04/13/2014 12:53 AM, Matt Turner wrote: > On Sun, Apr 13, 2014 at 12:12 AM, Kenneth Graunke > wrote: >> On 04/11/2014 10:29 PM, Matt Turner wrote: >>> --- >>> src/mesa/drivers/dri/i965/brw_fs.cpp | 129 >>> +- >>> src/mesa/drivers/dri/i965/brw_fs.h

[Mesa-dev] [PATCH 2/7] translate_sse: Rename translate_buffer_variant to translate_group.

2014-04-13 Thread Andreas Hartmetz
From: Andreas Hartmetz It is a better description of what goes on and it's shorter, too. --- src/gallium/auxiliary/translate/translate_sse.c | 86 - 1 file changed, 43 insertions(+), 43 deletions(-) diff --git a/src/gallium/auxiliary/translate/translate_sse.c b/src/gall

[Mesa-dev] [PATCH 5/7] translate_sse: Preserve low bit during unsigned -> float conversion.

2014-04-13 Thread Andreas Hartmetz
From: Andreas Hartmetz --- src/gallium/auxiliary/translate/translate_sse.c | 35 - 1 file changed, 28 insertions(+), 7 deletions(-) diff --git a/src/gallium/auxiliary/translate/translate_sse.c b/src/gallium/auxiliary/translate/translate_sse.c index dace722..03d8276 1006

[Mesa-dev] [PATCH 0/7] translate_sse fixes

2014-04-13 Thread Andreas Hartmetz
Hello, I noticed and incorrect uint->float conversion of vertex shader input in an application I'm working on, so I set out to fix it. In the meantime the application changed to avoid that conversion because it seems broken in too many drivers. So anyway, this series contains two actual bug fixes

[Mesa-dev] [PATCH 7/7] translate_sse: Remove a stray break;

2014-04-13 Thread Andreas Hartmetz
From: Andreas Hartmetz --- src/gallium/auxiliary/translate/translate_sse.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/gallium/auxiliary/translate/translate_sse.c b/src/gallium/auxiliary/translate/translate_sse.c index ca02b7a..992c5f6 100644 --- a/src/gallium/auxiliary/translate/t

[Mesa-dev] [PATCH 6/7] translate_sse: Be more specific in comment about loss of precision.

2014-04-13 Thread Andreas Hartmetz
From: Andreas Hartmetz The only loss of precision here due to intrinsic properties of unsigned int and float. --- src/gallium/auxiliary/translate/translate_sse.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/auxiliary/translate/translate_sse.c b/src/gallium/aux

[Mesa-dev] [PATCH 4/7] translate_sse: Use the correct buffer index in this fast path.

2014-04-13 Thread Andreas Hartmetz
From: Andreas Hartmetz It is possible that there are multiple input buffers but only one is relevant for translation. Then there will be only a single translation group, which might need to source data from a buffer index != 0. Fixes wrong vertex shader inputs as observed while debugging with an

[Mesa-dev] [PATCH 1/7] translate_sse: Explain what struct translate_buffer_variant is for.

2014-04-13 Thread Andreas Hartmetz
From: Andreas Hartmetz --- src/gallium/auxiliary/translate/translate_sse.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/src/gallium/auxiliary/translate/translate_sse.c b/src/gallium/auxiliary/translate/translate_sse.c index 1b698cd..24d8017 100644 --- a/src/gallium/auxiliary/trans

[Mesa-dev] [PATCH 3/7] translate_sse: Make those comments less abstract.

2014-04-13 Thread Andreas Hartmetz
From: Andreas Hartmetz --- src/gallium/auxiliary/translate/translate_sse.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/gallium/auxiliary/translate/translate_sse.c b/src/gallium/auxiliary/translate/translate_sse.c index e25d450..8dd30c4 100644 --- a/src/gallium/

[Mesa-dev] [PATCH 2/2] i965: Disable Z16 in all APIs.

2014-04-13 Thread Kenneth Graunke
We originally thought that GL 3.0 required GL_DEPTH_COMPONENT16 to map exactly to Z16. However, we misread the specification, thanks in part to LaTeX reordering the tables in the PDF. Page 180 of the GL 3.0 specification (glspec30.20080923.pdf) says: "[...] memory allocation per texture component

[Mesa-dev] [PATCH 1/2] i965: Update comments about Z16 being slow.

2014-04-13 Thread Kenneth Graunke
We've learned a few things since we originally disabled Z16; this attempts to summarize the issue. I am no expert on this subject, though, so the comment may not be totally accurate. I did some benchmarking on GM45 and Ironlake, and discovered that for GLBenchmark 2.7 EgyptHD, using Z16 was 3% sl

Re: [Mesa-dev] [PATCH 2/2] i965: Disable Z16 in all APIs.

2014-04-13 Thread Matt Turner
Both are Reviewed-by: Matt Turner ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev