On 11/25/2013 05:38 AM, Ben Skeggs wrote:
On Mon, Nov 25, 2013 at 1:57 PM,
wrote:
From: Christopher James Halse Rogers
http://cgit.freedesktop.org/~keithp/mesa/log/?h=dri3
Ben,
Christopher's patches have apparently been on the mesa dev lists since
April, with various reviews and comments,
I've pushed these now, including dropping the old names for those debug bits.
I've left the stats stuff as-is for now, but suggested more useful
options in the docs.
On Mon, Nov 25, 2013 at 4:44 AM, Kenneth Graunke wrote:
> On 11/23/2013 09:13 PM, Chris Forbes wrote:
>> Signed-off-by: Chris Forb
From: Dave Airlie
So GL4.3 spec pretty much says glClear on integer buffers is undefined,
then we have a piglit multisample test
ext_framebuffer_multisample-int-draw-buffers-alpha-to-coverage
that actually does undefined things but doesn't rely on the results except
not crashing.
(The tests bin
On Fri, Nov 22, 2013 at 02:12:13PM -0800, Kristian Høgsberg wrote:
> I don't know what else you'd propose? Pass an X visual in the ioctl?
> An EGL config? This is our name space, we can add stuff as we need
> (as Keith is doing here). include/uapi/drm/drm_fourcc.h is the
> canonical source for th
These two patches fake MSAA support for drisw and llvmpipe,
Discuss... :-)
Dave.
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
This adds support for multisample to drisw, even if we fake
multisample in the drivers we should at least do best effort,
and not fail to render.
Signed-off-by: Dave Airlie
---
src/gallium/state_trackers/dri/sw/drisw.c | 24 +++-
1 file changed, 23 insertions(+), 1 deletion(-
From: Dave Airlie
We've talked in the past about just faking multisample support
in the sw drivers as much as we possibly can, this just adds enough
to llvmpipe to do that.
It produces some valid fails in piglit, like the accuracy tests
and the texelFetch tests fail due to lack of second texel,
This just always returns 0.5,0.5 as the position.
Signed-off-by: Dave Airlie
---
src/gallium/drivers/llvmpipe/lp_context.c | 10 ++
1 file changed, 10 insertions(+)
diff --git a/src/gallium/drivers/llvmpipe/lp_context.c
b/src/gallium/drivers/llvmpipe/lp_context.c
index 9a6d13b..678f852
On Mon, Nov 25, 2013 at 09:57:23AM +0100, Daniel Vetter wrote:
> On Fri, Nov 22, 2013 at 02:12:13PM -0800, Kristian Høgsberg wrote:
> > I don't know what else you'd propose? Pass an X visual in the ioctl?
> > An EGL config? This is our name space, we can add stuff as we need
> > (as Keith is doin
On 11/22/2013 08:05 PM, Francisco Jerez wrote:
Petri Latvala writes:
[...]
@@ -325,8 +326,9 @@ public:
*/
dst_reg output_reg[BRW_VARYING_SLOT_COUNT];
const char *output_reg_annotation[BRW_VARYING_SLOT_COUNT];
- int uniform_size[MAX_UNIFORMS];
- int uniform_vector_size[MAX_U
Extra null check before accessing user given context pointer.
Signed-off-by: Juha-Pekka Heikkila
---
src/glx/glxcurrent.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/glx/glxcurrent.c b/src/glx/glxcurrent.c
index a6884cf..b9f259e 100644
--- a/src/glx/glxcurrent.c
+++ b
On Fri, Nov 22, 2013 at 05:35:54AM -0800, Keith Packard wrote:
> If the application sends us a file descriptor pointing at a prime
> buffer that we've already got, we have to re-use the same bo_gem
> structure or chaos will result.
>
> Track the set of all known prime objects and look to see if th
The previous commit fixes a bug wherein we would incorrectly refer to
stale geometry shader prog_data when no geometry shader was active.
This patch reduces the likelihood of that sort of bug occurring in the
future by setting prog_data to NULL whenever there is no GS program.
Cc: mesa-sta...@lis
Previously, in brw_gs_upload_binding_table(), we checked whether
brw->gs.prog_data was NULL in order to determine whether a geometry
shader was active. This didn't work: brw->gs.prog_data starts off as
NULL, but it is set to non-NULL when a geometry shader program is
built, and then never set to N
On 11/24/2013 07:41 PM, Jordan Justen wrote:
> On Sun, Nov 24, 2013 at 2:55 AM, Marek Olšák wrote:
>> From: Marek Olšák
>>
>> It needs glFramebufferTexture, which isn't available in the compatibility
>> profile.
>> ---
>> src/mesa/main/extensions.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 de
On 11/25/2013 07:23 AM, Juha-Pekka Heikkila wrote:
> Extra null check before accessing user given context pointer.
oldGC can never be NULL. If there is no current context, it will point
to dummyContext.
> Signed-off-by: Juha-Pekka Heikkila
> ---
> src/glx/glxcurrent.c | 2 +-
> 1 file changed,
Am 25.11.2013 09:51, schrieb Dave Airlie:
> From: Dave Airlie
>
> So GL4.3 spec pretty much says glClear on integer buffers is undefined,
> then we have a piglit multisample test
> ext_framebuffer_multisample-int-draw-buffers-alpha-to-coverage
> that actually does undefined things but doesn't re
Am 25.11.2013 11:57, schrieb Dave Airlie:
> This just always returns 0.5,0.5 as the position.
>
> Signed-off-by: Dave Airlie
> ---
> src/gallium/drivers/llvmpipe/lp_context.c | 10 ++
> 1 file changed, 10 insertions(+)
>
> diff --git a/src/gallium/drivers/llvmpipe/lp_context.c
> b/src/
Chris Forbes writes:
> + if (index > ctx->Const.MaxImageUnits)
> + goto invalid_value;
>
> Image unit indices are zero-based, so I think you want >= in all these cases.
>
Ouch... Good catch. I'll fix that.
Thanks.
> -- Chris
>
> On Mon, Nov 25, 2013 at 6:00 PM, Francisco Jerez
Chris Forbes writes:
> Does this want to be enabled in compatibility? I had assumed we
> wouldn't, for the same reasons we don't enable texbo there.
Hmm... I don't see why not. The extension was specifically written
against the GL 3.2 compatibility profile.
>
> On Mon, Nov 25, 2013 at 6:00 P
Chris Forbes writes:
> It would be nice not to have to touch this memory when the extension
> is unused|unsupported, but that might be a problem for another
> patch...
>
How do you mean? If the driver doesn't know about this extension
ctx->Const.MaxImageUnits will be zero and no memory will be t
Am 25.11.2013 11:41, schrieb Dave Airlie:
> From: Dave Airlie
>
> We've talked in the past about just faking multisample support
> in the sw drivers as much as we possibly can, this just adds enough
> to llvmpipe to do that.
>
> It produces some valid fails in piglit, like the accuracy tests
> a
Chris Forbes writes:
> In the commit message, s/requried/required/
>
> Does holding onto the whole texture object make things easier? I had
> assumed you could get by just referencing the right gl_texture_image,
> but maybe that doesn't work out.
>
Yes, it does for many reasons: First, if we onl
Petri Latvala writes:
> On 11/22/2013 08:05 PM, Francisco Jerez wrote:
>> Petri Latvala writes:
>>
>>> [...]
>>> @@ -325,8 +326,9 @@ public:
>>> */
>>> dst_reg output_reg[BRW_VARYING_SLOT_COUNT];
>>> const char *output_reg_annotation[BRW_VARYING_SLOT_COUNT];
>>> - int uniform_s
That makes good sense.
On Tue, Nov 26, 2013 at 6:45 AM, Francisco Jerez wrote:
> Chris Forbes writes:
>
>> In the commit message, s/requried/required/
>>
>> Does holding onto the whole texture object make things easier? I had
>> assumed you could get by just referencing the right gl_texture_imag
Ah, of course; so it's not a factor for driver which don't expose the
extension at all.
The `unused` side still stands as a vague concern, I think -- we
currently pay for lots of things that most apps don't use.
On Tue, Nov 26, 2013 at 6:43 AM, Francisco Jerez wrote:
> Chris Forbes writes:
>
>>
On 11/24/2013 11:17 PM, Chris Forbes wrote:
> I'm not convinced that just using _mesa_align_malloc() is sufficient
> here. Issue 2 from the ARB_map_buffer_alignment spec says:
>
> 2) What alignment should be used for MapBufferRange when is
> non-zero?
>
> RESOLVED: The pointer retur
On Mon, Nov 25, 2013 at 7:12 PM, Ian Romanick wrote:
> On 11/25/2013 07:23 AM, Juha-Pekka Heikkila wrote:
> > Extra null check before accessing user given context pointer.
>
> oldGC can never be NULL. If there is no current context, it will point
> to dummyContext.
>
Ah, ok. I was just going thr
Hi,
today I read an article on phoronix
(http://www.phoronix.com/scan.php?page=news_item&px=MTUyNDY) which
linked to a wiki page (http://wiki.freedesktop.org/dri/NewbieProjects/)
where easy projects to start with were listed. I gave it a shot and
tried to implement the ARB_map_buffer_alignment ext
On 11/22/2013 03:08 PM, Paul Berry wrote:
> The ARB_geometry_shader4 spec says, in the list of conditions necessary
> for framebuffer completeness:
>
> * If any framebuffer attachment is layered, all attachments must have
> the same layer count. For three-dimensional textures, the l
Paul Berry writes:
> The previous commit fixes a bug wherein we would incorrectly refer to
> stale geometry shader prog_data when no geometry shader was active.
>
> This patch reduces the likelihood of that sort of bug occurring in the
> future by setting prog_data to NULL whenever there is no GS
On 11/23/2013 01:41 PM, Kenneth Graunke wrote:
The fast tiled texture upload code does not compile with GCC 4.8's -Og
optimization flag.
memcpy() has the always_inline attribute set. This poses a problem,
since {x,y}tile_copy_faster calls it indirectly via {x,y}tile_copy,
and {x,y}tile_copy nor
Ouch.
Reviewed-by: Chris Forbes
On Tue, Nov 26, 2013 at 5:23 AM, Paul Berry wrote:
> Previously, in brw_gs_upload_binding_table(), we checked whether
> brw->gs.prog_data was NULL in order to determine whether a geometry
> shader was active. This didn't work: brw->gs.prog_data starts off as
> N
On 11/25/2013 08:23 AM, Paul Berry wrote:
> Previously, in brw_gs_upload_binding_table(), we checked whether
> brw->gs.prog_data was NULL in order to determine whether a geometry
> shader was active. This didn't work: brw->gs.prog_data starts off as
> NULL, but it is set to non-NULL when a geometr
Hi,
+ pipe_resource_reference(&img->texture, tex);
You shouldn't reference the texture before we manage to get a correct
dri_format,
in case we fail.
+ img->level = level;
+ img->layer = depth;
+ img->dri_format = driGLFormatToImageFormat(obj->_BufferObjectFormat);
This doesn't gi
I've added a viewport_array-rc2 branch to my github repository with updates
from the feedback so far. Also includes a commit from Ian to Add varying
slot for viewport index.
Courtney
On Fri, Nov 22, 2013 at 3:51 PM, Courtney Goeltzenleuchter <
court...@lunarg.com> wrote:
> Got it.
>
>
> On Fri,
Keith Packard writes:
> Just copying code from the dri2 path to set up the fast color clear state.
>
> This also removes a couple of bogus intel_region_reference calls.
These two are:
Reviewed-by: Eric Anholt
pgpWbpIEouoko.pgp
Description: PGP signature
__
On Thu, Nov 21, 2013 at 5:56 PM, Brian Paul wrote:
> On 11/19/2013 04:16 PM, Courtney Goeltzenleuchter wrote:
>
>> Add helper function to set texture_view state from TexStorage calls.
>>
>> Signed-off-by: Courtney Goeltzenleuchter
>> ---
>> src/mesa/main/textureview.c | 59
Daniel Vetter writes:
> Yeah, it unfortunately took a few rounds of kernel fixes and other
> haggling to get the semantics right on this one. The kernel atm promises
> to userspace (minus one big in a racy corner case no one should care
> about, still need to fix that one) that it'll return the s
If the application sends us a file descriptor pointing at a prime
buffer that we've already got, we have to re-use the same bo_gem
structure or chaos will result.
Track the set of all known prime objects and look to see if the kernel
has returned one of those for a new file descriptor.
Also check
On Sun, Nov 24, 2013 at 11:36 PM, Siavash Eliasi
wrote:
> ---
> src/mesa/main/bufferobj.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/src/mesa/main/bufferobj.c b/src/mesa/main/bufferobj.c
> index b27f592..5581a5d 100644
> --- a/src/mesa/main/bufferobj.c
> +++ b/sr
Keith Packard writes:
> The easy part is turning on the extension, now that the X server has a patch
> to send the events.
>
> The only trick was making sure the Present extension reliably provided the
> right 'sbc' count back in the event, and that's done by making sure the sbc
> count is always
On Gen4+, OUT_RELOC_FENCED is equivalent to OUT_RELOC; libdrm silently
ignores the fenced flag:
/* We never use HW fences for rendering on 965+ */
if (bufmgr_gem->gen >= 4)
need_fence = false;
Thanks to Eric for noticing this.
Signed-off-by: Kenneth Graunke
---
Keith Packard writes:
> The __DRIimage createImageFromFds function takes a fourcc code, but there was
> no fourcc code that match __DRI_IMAGE_FORMAT_SARGB8. This adds a define for
> that format, adds a translation in DRI3 from __DRI_IMAGE_FORMAT_SARGB8 to
> __DRI_IMAGE_FOURCC_SARGB and then a
Hello Grigori,
indeed the patch cures the error, but when I was testing the newly compiled
Mesa
with XPlane10, it turns out there is something wrong - there are no shadows
(without
shadows I can't really tell if the patch didn't visibly break anything).
I'm going to try and find out where exac
Eric Anholt writes:
> I'd prefer to see sbc stay with its current name, since that's its name
> in the specs we're trying to implement (GLX_OML_sync_control,
> GLX_INTEL_swap_event). If you drop the rename from the patch,
>
> Reviewed-by: Eric Anholt
Sounds good.
> I read that as "SBC is incr
Keith Packard writes:
> This allows GL to support the GLX_INTEL_swap_event extension
>
> Signed-off-by: Keith Packard
There's a minor behavior change that the event now gets sent to the
drawable owner rather than the caller of DRI2SwapBuffers.
I don't expect it to matter in practice (I expect
Paul Berry writes:
> In commit 065da16 (glsl: Convert lower_clip_distance_visitor to be an
> ir_rvalue_visitor), we failed to notice that since
> lower_clip_distance_visitor overrides visit_leave(ir_assignment *),
> ir_rvalue_visitor::visit_leave(ir_assignment *) wasn't getting called.
> As a res
On 25 November 2013 15:02, Eric Anholt wrote:
> Paul Berry writes:
>
> > In commit 065da16 (glsl: Convert lower_clip_distance_visitor to be an
> > ir_rvalue_visitor), we failed to notice that since
> > lower_clip_distance_visitor overrides visit_leave(ir_assignment *),
> > ir_rvalue_visitor::vis
Kenneth Graunke writes:
> On Gen4+, OUT_RELOC_FENCED is equivalent to OUT_RELOC; libdrm silently
> ignores the fenced flag:
>
> /* We never use HW fences for rendering on 965+ */
> if (bufmgr_gem->gen >= 4)
> need_fence = false;
>
> Thanks to Eric for noticing this
On Thu, Nov 21, 2013 at 5:56 PM, Brian Paul wrote:
> On 11/19/2013 04:16 PM, Courtney Goeltzenleuchter wrote:
>
>>
>> Signed-off-by: Courtney Goeltzenleuchter
>> ---
>> src/mesa/drivers/common/driverfuncs.c | 3 +++
>> src/mesa/main/dd.h| 5 +
>> 2 files changed, 8 in
Refactor to make next_mipmap_level_size defined in mipmap.c a
_mesa_ helper function that can then be used by texture_view
Signed-off-by: Courtney Goeltzenleuchter
---
src/mesa/main/mipmap.c | 8
src/mesa/main/mipmap.h | 4
src/mesa/main/texstorage.c | 25 +++-
Add Mesa TextureView logic.
Incorporate feedback on ARB_texture_view:
- Add S3TC VIEW_CLASSes to compatibility table
- Use existing _mesa_get_tex_image
- Clean up error strings
- Use bool instead of GLboolean for internal functions
- Split compound level & layer test into individual tests
Signed-o
While incorporating Brian's comments I did some refactoring to consolidate
multiple uses of next_mimap_level_size into one shared helper function.
That adds another commit to the stream. I thought it was big enough now
that I should post the branch to make it easier to use.
I've posted the updated
Eric Anholt writes:
> There's a minor behavior change that the event now gets sent to the
> drawable owner rather than the caller of DRI2SwapBuffers.
Yeah, probably not ideal, especially when the GLX drawable is created
using the window XID (as is the case for some older GLX clients). I
don't ha
From: Roland Scheidegger
Now that it is possible to query drivers for the max sampler view it should
be safe to increase this without crashing.
Not entirely convinced this really works correctly though if state trackers
using non-linked sampler / sampler_views use this.
---
src/gallium/auxiliary
From: Roland Scheidegger
Ever since introducing separate sampler and sampler view max this was really
missing.
Every driver but llvmpipe reports the same number as number of samplers for
now, so nothing should break.
---
src/gallium/auxiliary/gallivm/lp_bld_limits.h|2 ++
src/gallium/doc
From: Roland Scheidegger
This adds support for this to more drivers, in particular for all the "special"
ones useful for debugging.
HW drivers are left alone, some should be able to support it if they want but
they may not be interested at this point.
---
src/gallium/drivers/galahad/glhd_context
Am 25.11.2013 06:36 schrieb "Siavash Eliasi" :
>
> ---
> src/gallium/drivers/softpipe/sp_screen.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/gallium/drivers/softpipe/sp_screen.c
b/src/gallium/drivers/softpipe/sp_screen.c
> index 47ef20e..022b5bf 100644
> --- a/src
Am 25.11.2013 06:36 schrieb "Siavash Eliasi" :
>
> ---
> src/gallium/drivers/llvmpipe/lp_screen.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/src/gallium/drivers/llvmpipe/lp_screen.c
b/src/gallium/drivers/llvmpipe/lp_screen.c
> index f61df98..8be1779 100644
> --- a/src/gallium/drivers
On Sat, Nov 23, 2013 at 2:10 AM, Ville Syrjälä
wrote:
> On Fri, Nov 22, 2013 at 03:43:13PM -0800, Keith Packard wrote:
>> Ville Syrjälä writes:
>>
>> > What is this format anyway? -ENODOCS
>>
>> Same as MESA_FORMAT_SARGB8 and __DRI_IMAGE_FORMAT_SARGB8 :-)
>>
>> > If its just an srgb version of AR
On Son, 2013-11-24 at 11:55 +0100, Marek Olšák wrote:
> From: Marek Olšák
The radeonsi patches in this series are
Reviewed-by: Michel Dänzer
--
Earthling Michel Dänzer| http://www.amd.com
Libre software enthusiast |Mesa and X developer
_
Hello, thanks for reviewing these patches! There is a patch to address
these issues:
http://lists.freedesktop.org/archives/mesa-dev/2013-November/049057.html
Best Regards,
Siavash Eliasi.
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http:
From: Tom Stellard
SGPRs are spilled into VGPRs using the {READ,WRITE}LANE_B32 instructions.
v2:
- Fix encoding of Lane Mask
- Use correct register flags, so we don't overwrite the low dword
when restoring multi-dword registers.
v3:
- Register spilling seems to hang the GPU, so replac
On Sat, Nov 23, 2013 at 03:30:30PM -0800, Ian Romanick wrote:
> I believe that I have picked over all of the patches marked for the 10.0
> release branch. I have included the full list far below. There are a
> few patches that were sent to the mesa-stable mailing list that do not
> appear to have l
The entire series looks good to me.
> Now that it is possible to query drivers for the max sampler view it should
> be safe to increase this without crashing.
> Not entirely convinced this really works correctly though if state trackers
> using non-linked sampler / sampler_views use this.
I'm not
Move the depth field up with width and height.
Remove unused previous_time and frames fields.
Signed-off-by: Keith Packard
---
src/glx/dri3_priv.h | 6 +-
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/src/glx/dri3_priv.h b/src/glx/dri3_priv.h
index 05f66cf..34c67a6 100644
---
Tracking the full 64-bit SBC values makes it clearer how those values are
being used, and simplifies the wait_msc code. The only trick is in
re-constructing the full 64-bit value from Present's 32-bit serial number that
we use to pass the SBC value from request to event.
Signed-off-by: Keith Packa
Eric figured out that glXWaitForSbcOML wanted to block until the requested SBC
had been completed, which means to wait until the PresentCompleteNotify event
for that SBC had been received.
This replaces the simple sleep(1) loop (which was bogus) with a loop that just
checks to see if we've seen th
Now that we're tracking SBC values correctly, and the X server has the ability
to send the GLX swap events from a PresentPixmap request, enable this extension.
Signed-off-by: Keith Packard
---
src/glx/dri3_glx.c | 18 +-
1 file changed, 1 insertion(+), 17 deletions(-)
diff --git
I've split the GLX_INTEL_swap_event enabling patch into four bits -- the first
three just fix the existing code to track SBC values correctly and to fix
wait_for_sbc. The fourth is the trivial patch to actually turn on the new
extension; all of the hard work for that is actually dealt with in the X
Yes I think you are right, I guess *_mesa_align_realloc* is the correct
function which should be used here.
What do you think Ian?
Best regards,
Siavash Eliasi.
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mai
From: Christopher James Halse Rogers
v2: Pick out the correct gl_context pointer
v3: Don't leak pipe_resources on error path
Set img->dri_format correctly
---
src/gallium/state_trackers/dri/drm/dri2.c | 72 ++-
1 file changed, 71 insertions(+), 1 deletion(-)
diff
73 matches
Mail list logo
