Re: [Mesa-dev] spec/!OpenGL 3.0/gl-3.0-texture-integer fails on r600g

Well, I should have been more clear. If I do this: 263: value[3] = 0; 290: expected[3] = 1.0; The test always passes, but if I only do this: 290: expected[3] = 1.0; The test fails with this error: texture-integer: failure with format GL_RGB8I_EXT: texture color = 92, 126, 14, 104 expected

[Mesa-dev] [PATCH 1/2] i965: Add a new debug mode for the VUE map

INTEL_DEBUG=vue now emits a listing of each slot in the VUE map, and the corresponding interpolation mode. Signed-off-by: Chris Forbes --- src/mesa/drivers/dri/i965/brw_interpolation_map.c | 28 +++ src/mesa/drivers/dri/i965/intel_context.c | 1 + src/mesa/drivers/dr

[Mesa-dev] [PATCH 2/2] i965: add missing BRW_NEW_INTERPOLATION_MAP to state dump

Makes this flag appear in the output for INTEL_DEBUG=state Signed-off-by: Chris Forbes --- src/mesa/drivers/dri/i965/brw_state_upload.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/mesa/drivers/dri/i965/brw_state_upload.c b/src/mesa/drivers/dri/i965/brw_state_upload.c index e3ef245..

[Mesa-dev] [RFC PATCH 00/10] i965: gl_ClipDistance for Gen4/5

This series adds support for GLSL-1.30-style clipping using gl_ClipDistance on Gen4/5. All of the interpolation piglits now pass, but there are still a couple of things I need to do: * Get rid of clip plane compaction * Add similar support for clipping lines

[Mesa-dev] [RFC PATCH 01/10] i965: allow 8 user clip planes on CTG+

There's no need to use a clip flag for NEGW on these gens, so no reason we can't just enable 8 planes. V2: Bump (and document!) MAX_VERTS in the clip code. Signed-off-by: Chris Forbes --- src/mesa/drivers/dri/i965/brw_clip.h | 6 +- src/mesa/drivers/dri/i965/brw_clip_tri.c | 4 ++-- src

[Mesa-dev] [RFC PATCH 03/10] i965/fs: Gen4/5: Fix inconsistency in the VUE map.

The SF never gets to see the clip distances. If we didn't ignore them here, we got confused about the correct offsets for any varyings laid out after them. (user-defined varyings would break, but gl_FrontColor etc worked properly). Signed-off-by: Chris Forbes --- src/mesa/drivers/dri/i965/brw_fs

[Mesa-dev] [RFC PATCH 02/10] i965/Gen4-5: allocate VUE slots for clipdistance if user clipping is enabled

Also adjust the SF URB read offset to account for there being two additional slots of stuff it doesn't care about. Signed-off-by: Chris Forbes --- src/mesa/drivers/dri/i965/brw_sf.h | 2 +- src/mesa/drivers/dri/i965/brw_vs.c | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/s

[Mesa-dev] [RFC PATCH 05/10] i965/clip: Enable interpolation of clip distances

Previously we had disabled interpolation of the clip distances as a special case, since they were unused. Signed-off-by: Chris Forbes --- src/mesa/drivers/dri/i965/brw_clip_util.c | 10 +++--- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_clip_ut

[Mesa-dev] [RFC PATCH 04/10] i965/vs: Do legacy clip lowering earlier

We need to produce clip flags for the vertex header on Gen4/5, so clip plane lowering has to be done before we try to emit the flags/psiz attribute. Signed-off-by: Chris Forbes --- src/mesa/drivers/dri/i965/brw_vec4.h | 2 +- src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp | 33 +++

[Mesa-dev] [RFC PATCH 07/10] i965/clip: Track offset into the vertex for clipdistance

Signed-off-by: Chris Forbes --- src/mesa/drivers/dri/i965/brw_clip.h | 3 +++ src/mesa/drivers/dri/i965/brw_clip_tri.c | 9 + 2 files changed, 12 insertions(+) diff --git a/src/mesa/drivers/dri/i965/brw_clip.h b/src/mesa/drivers/dri/i965/brw_clip.h index 671d3a9..f26d75d 100644 ---

[Mesa-dev] [RFC PATCH 06/10] i965/Gen4-5: Set clip flags from clip distances

Signed-off-by: Chris Forbes --- src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp | 25 ++--- 1 file changed, 14 insertions(+), 11 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp b/src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp index f80777b..c0b5ccd 10

[Mesa-dev] [RFC PATCH 08/10] i956/clip: push dp4 into load_clip_distance

Soon the dp4 is only going to be used for fixed clip planes. Signed-off-by: Chris Forbes --- src/mesa/drivers/dri/i965/brw_clip_tri.c | 26 ++ 1 file changed, 14 insertions(+), 12 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_clip_tri.c b/src/mesa/drivers/dri/

[Mesa-dev] [RFC PATCH 09/10] i965/clip: Use clip distances for all user clipping

Signed-off-by: Chris Forbes --- src/mesa/drivers/dri/i965/brw_clip_tri.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_clip_tri.c b/src/mesa/drivers/dri/i965/brw_clip_tri.c index bd3ffb3..4d2eb0a 100644 --- a/src/mesa/drivers/dri/i965/br

[Mesa-dev] [RFC PATCH 10/10] i965/clip: remove spurious clipvertex param

Nothing in the clipper uses gl_ClipVertex any more, so we don't care where it is. Signed-off-by: Chris Forbes --- src/mesa/drivers/dri/i965/brw_clip_tri.c | 12 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_clip_tri.c b/src/mesa/drivers

[Mesa-dev] [PATCH] draw: Change slot from unsigned to int.

unfilled_stage::face_slot is of type int. Fixes "Unsigned compared against 0" defect reported by Coverity. Signed-off-by: Vinson Lee --- src/gallium/auxiliary/draw/draw_pipe_unfilled.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/auxiliary/draw/draw_pipe_unfil