Re: [Mesa-dev] [PATCH 1/2] clover: Added missing address space checking of kernel parameters

2013-07-24 Thread Francisco Jerez
Tom Stellard writes: > On Mon, Jul 22, 2013 at 09:24:12AM -0400, Jonathan Charest wrote: >> To have non-static buffers in local memory, it is necessary to pass them >> as arguments to the kernel. This was almost supported but the address >> space mapping was missing to perform the check (thanks t

Re: [Mesa-dev] [PATCH] gallium/util: Fix detection of AVX cpu caps

2013-07-24 Thread Andre Heider
On Wed, Jul 24, 2013 at 12:11 AM, Jose Fonseca wrote: > > > - Original Message - >> On Tue, Jul 23, 2013 at 8:57 PM, Roland Scheidegger >> wrote: >> > Am 23.07.2013 19:08, schrieb Andre Heider: >> >> For AVX it's not sufficient to only rely on the cpuid flags. If the CPU >> >> supports th

[Mesa-dev] [Bug 67120] Dota 2 crashes sporadically on Intel/Mesa git (full backtrace with mesa symbols included)

2013-07-24 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=67120 Vedran Rodic changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[Mesa-dev] [v8] EXT_image_dma_buf_import for intel

2013-07-24 Thread Topi Pohjolainen
The set introduces new target for 'eglCreateImageKHR()' allowing one to create EGL images out of externally allocated buffers. For now only natively supported RGB formatted buffers are accepted. This revision ties the dma-buffer import extension tightly with the image external extension. One can a

[Mesa-dev] [v8 1/9] intel: allow packed prime buffers to be treated normally

2013-07-24 Thread Topi Pohjolainen
v2: - fix earlier rebase error breaking bisect (loaderPriv -> loaderPrivate) Signed-off-by: Topi Pohjolainen Reviewed-by: Chad Versace --- src/mesa/drivers/dri/i965/intel_screen.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/intel_sc

[Mesa-dev] [v8 2/9] intel: do not create renderbuffers out of planar images

2013-07-24 Thread Topi Pohjolainen
v2 (Chad): emit 'GL_INVALID_OPERATION' and description of error Signed-off-by: Topi Pohjolainen --- src/mesa/drivers/dri/i965/intel_fbo.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/src/mesa/drivers/dri/i965/intel_fbo.c b/src/mesa/drivers/dri/i965/intel_fbo.c index e746cb4..059b3

[Mesa-dev] [v8 3/9] intel: refactor planar format lookup

2013-07-24 Thread Topi Pohjolainen
v2 (Eric): refactor both occurences, not just one v3 (Chad): replace 0 by NULL Signed-off-by: Topi Pohjolainen Reviewed-by: Chad Versace --- src/mesa/drivers/dri/i965/intel_screen.c | 31 ++- 1 file changed, 18 insertions(+), 13 deletions(-) diff --git a/src/mesa/d

[Mesa-dev] [v8 4/9] intel: set dri image dimensions even when creating out of primes

2013-07-24 Thread Topi Pohjolainen
Otherwise 'intel_set_texture_image_region()' won't have enough details to work with. Signed-off-by: Topi Pohjolainen Reviewed-by: Chad Versace --- src/mesa/drivers/dri/i965/intel_screen.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/mesa/drivers/dri/i965/intel_screen.c b/src/mesa/

[Mesa-dev] [v8 5/9] dri: propagate extra dma_buf import attributes to the drivers

2013-07-24 Thread Topi Pohjolainen
v2: do not break ABI, but instead introduce new entry point for dma buffers and bump up the dri-interface version to eight v3 (Chad): allow the hook to specify an error originating from the driver. For now only unsupported format is considered. I thought about rejecting t

[Mesa-dev] [v8 7/9] intel: restrict dma-buf-import images to external sampling only

2013-07-24 Thread Topi Pohjolainen
Memory originating outside mesa stack is meant to be for reading only. In addition, the restrictions imposed by the image external extension should apply. For example, users shouldn't be allowed to generare mip-trees based on these images. v2 (Chad): document using full extension names, fix the co

[Mesa-dev] [v8 6/9] egl: definitions for EXT_image_dma_buf_import

2013-07-24 Thread Topi Pohjolainen
As specified in: http://www.khronos.org/registry/egl/extensions/EXT/EGL_EXT_image_dma_buf_import.txt Checking for the valid fourcc values is left for drivers avoiding dependency to drm header files here. v2: enforce EGL_NO_CONTEXT v3: declare the extension as EGL (not GLES) v4: do not update e

[Mesa-dev] [v8 8/9] egl/dri2: support for creating images out of dma buffers

2013-07-24 Thread Topi Pohjolainen
v2: - upon success close the given file descriptors v3: - use specific entry for dma buffers instead of the basic for primes, and enable the extension based on the availability of the hook v4 (Chad): - use ARRAY_SIZE - improve the comment about the number of file descriptors

[Mesa-dev] [v8 9/9] i965: enable image external sampling for imported dma-buffers

2013-07-24 Thread Topi Pohjolainen
Signed-off-by: Topi Pohjolainen --- src/mesa/drivers/dri/i965/intel_extensions.c | 1 + src/mesa/drivers/dri/i965/intel_tex_image.c | 7 +++ 2 files changed, 8 insertions(+) diff --git a/src/mesa/drivers/dri/i965/intel_extensions.c b/src/mesa/drivers/dri/i965/intel_extensions.c index 409d4

Re: [Mesa-dev] [PATCH 09/10] Float fbconfigs frontend patch [2/3] Creation of dummy X pixmap associated with float buffer.

2013-07-24 Thread Tomasz Lis
Is there any progress regarding this patch? Without it, XServer will try to create a 128 bpp pixmap while creating float pbuffers. Buffers with BPP over 32 are not supported by xf86-video-intel, and the pixmap creation will fail. 2013/7/19 Ian Romanick > On 07/17/2013 04:49 AM, Tomasz Lis wro

Re: [Mesa-dev] [PATCH 1/2] clover: Added missing address space checking of kernel parameters

2013-07-24 Thread Jonathan Charest
Here is an updated patch with no line wrapping and respecting 80-column limit (for my changes). --- .../state_trackers/clover/llvm/invocation.cpp | 34 +++--- 1 file changed, 23 insertions(+), 11 deletions(-) diff --git a/src/gallium/state_trackers/clover/llvm/invocation.cp

[Mesa-dev] [Bug 66806] [softpipe] glxgears floating point exception

2013-07-24 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=66806 Roland Scheidegger changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[Mesa-dev] [PATCH] glsl: Handle empty if statement encountered during loop analysis.

2013-07-24 Thread Paul Berry
The is_loop_terminator() function was asserting that the following kind of if statement could never occur: if (...) { } else { } (presumably based on the assumption that such an if statement would be eliminated by previous optimization stages). But that isn't the case--it's possible that pre

[Mesa-dev] [PATCH 2/3] meta: handle 2D texture arrays in decompress_texture_image()

2013-07-24 Thread Brian Paul
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=66850 NOTE: This is a candidate for the 9.x branches. Cc: mesa-sta...@lists.freedesktop.org --- src/mesa/drivers/common/meta.c | 23 +-- 1 file changed, 21 insertions(+), 2 deletions(-) diff --git a/src/mesa/drivers/com

[Mesa-dev] [PATCH 1/3] mesa: handle 2D texture arrays in get_tex_rgba_compressed()

2013-07-24 Thread Brian Paul
If we call glGetTexImage() for a compressed 2D texture array we need to loop over all the slices. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=66850 NOTE: This is a candidate for the 9.x branches. Cc: mesa-sta...@lists.freedesktop.org --- src/mesa/main/texgetimage.c | 52

[Mesa-dev] [PATCH 3/3] mesa: implement mipmap generation for compressed 2D array textures

2013-07-24 Thread Brian Paul
We weren't looping over all the slices in the array. The updated code should also correctly handle 3D compressed textures too, whenever we have that feature. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=66850 NOTE: This is a candidate for the 9.x branches Cc: mesa-sta...@lists.freedesk

Re: [Mesa-dev] [PATCH 3/3] mesa: implement mipmap generation for compressed 2D array textures

2013-07-24 Thread Jose Fonseca
Series looks alright AFAICT. Jose - Original Message - > We weren't looping over all the slices in the array. The updated > code should also correctly handle 3D compressed textures too, whenever > we have that feature. > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=66850 >

[Mesa-dev] [PATCH] i965: Initialize inout_offset parameter to brw_search_cache().

2013-07-24 Thread Paul Berry
Two callers of brw_search_cache() weren't initializing that function's inout_offset parameter: brw_blorp_const_color_params::get_wm_prog() and brw_blorp_const_color_params::get_wm_prog(). That's a benign problem, since the only effect of not initializing inout_offset prior to calling brw_search_ca

Re: [Mesa-dev] [PATCH] i965: Initialize inout_offset parameter to brw_search_cache().

2013-07-24 Thread Kenneth Graunke
On 07/24/2013 09:33 AM, Paul Berry wrote: Two callers of brw_search_cache() weren't initializing that function's inout_offset parameter: brw_blorp_const_color_params::get_wm_prog() and brw_blorp_const_color_params::get_wm_prog(). That's a benign problem, since the only effect of not initializing

Re: [Mesa-dev] [PATCH] glsl: Handle empty if statement encountered during loop analysis.

2013-07-24 Thread Kenneth Graunke
On 07/24/2013 08:17 AM, Paul Berry wrote: The is_loop_terminator() function was asserting that the following kind of if statement could never occur: if (...) { } else { } (presumably based on the assumption that such an if statement would be eliminated by previous optimization stages). Bu

[Mesa-dev] ES3 conformance regressions

2013-07-24 Thread Kenneth Graunke
Hey Ian, I'm seeing three regressions in es3conform: GL3Tests/depth24/depth24_basic.test GL3Tests/depth24/depth24_precision.test GL3Tests/rgb8_rgba8/rgb8_rgba8_rgb.test 9.1.4 worked, but 9.1.5 and master are both broken. Bisecting tracked it down to: commit c170c901d0f5384e5ab8b79b827663fa2

[Mesa-dev] [PATCH] draw: fix vertex id computation

2013-07-24 Thread Zack Rusin
vertex id has to be unaffected by the start index (i.e. when calling draw arrays with start_index = 5, the first vertex_id has to still be 0, not 5) and it has to be equal to the index when performing indexed rendering (in which case it has to be unaffected by the index bias). This fixes our behavi

Re: [Mesa-dev] ES3 conformance regressions

2013-07-24 Thread Ian Romanick
On 07/24/2013 02:15 PM, Kenneth Graunke wrote: Hey Ian, I'm seeing three regressions in es3conform: GL3Tests/depth24/depth24_basic.test GL3Tests/depth24/depth24_precision.test GL3Tests/rgb8_rgba8/rgb8_rgba8_rgb.test I didn't observer that failure when I pushed that commit, but it does appear

Re: [Mesa-dev] ES3 conformance regressions

2013-07-24 Thread Kenneth Graunke
On 07/24/2013 02:26 PM, Ian Romanick wrote: On 07/24/2013 02:15 PM, Kenneth Graunke wrote: Hey Ian, I'm seeing three regressions in es3conform: GL3Tests/depth24/depth24_basic.test GL3Tests/depth24/depth24_precision.test GL3Tests/rgb8_rgba8/rgb8_rgba8_rgb.test I didn't observer that failure w

[Mesa-dev] vdpau/vl 422 chroma width/height mix up

2013-07-24 Thread Andy Furniss
I was looking into some minor 422 issues/discrepencies I noticed long ago using vdpau on my rv790. I noticed that there is code that is halving height rather than width - 422 is full height AFAIK. Making the changes below doesn't actually make any noticable difference to what I was looking i

Re: [Mesa-dev] [PATCH vmwgfx] update for XA API changes

2013-07-24 Thread Jakob Bornecrantz
On Thu, Jul 11, 2013 at 1:58 AM, Jakob Bornecrantz wrote: > Just tried this out, on your XA branch, and I'm getting rendering > issues in gnome-terminal. It looks like some text is offset by > one or two lines, and the rest looks a bit like pitch issues. > > http://i.imgur.com/mdivF0q.png > > I ca

Re: [Mesa-dev] [PATCH vmwgfx] update for XA API changes

2013-07-24 Thread Rob Clark
On Wed, Jul 24, 2013 at 6:33 PM, Jakob Bornecrantz wrote: > On Thu, Jul 11, 2013 at 1:58 AM, Jakob Bornecrantz > wrote: >> >> Just tried this out, on your XA branch, and I'm getting rendering >> issues in gnome-terminal. It looks like some text is offset by >> one or two lines, and the rest looks

Re: [Mesa-dev] [PATCH] draw: fix vertex id computation

2013-07-24 Thread Brian Paul
On 07/24/2013 03:22 PM, Zack Rusin wrote: vertex id has to be unaffected by the start index (i.e. when calling draw arrays with start_index = 5, the first vertex_id has to still be 0, not 5) and it has to be equal to the index when performing indexed rendering (in which case it has to be unaffect

Re: [Mesa-dev] [PATCH] draw: fix vertex id computation

2013-07-24 Thread Roland Scheidegger
Am 24.07.2013 23:22, schrieb Zack Rusin: > vertex id has to be unaffected by the start index (i.e. when calling > draw arrays with start_index = 5, the first vertex_id has to still > be 0, not 5) and it has to be equal to the index when performing > indexed rendering (in which case it has to be una

Re: [Mesa-dev] [v8 2/9] intel: do not create renderbuffers out of planar images

2013-07-24 Thread Chad Versace
On 07/24/2013 03:23 AM, Topi Pohjolainen wrote: v2 (Chad): emit 'GL_INVALID_OPERATION' and description of error Signed-off-by: Topi Pohjolainen --- src/mesa/drivers/dri/i965/intel_fbo.c | 7 +++ 1 file changed, 7 insertions(+) Reviewed-by: Chad Versace ___

Re: [Mesa-dev] [v8 7/9] intel: restrict dma-buf-import images to external sampling only

2013-07-24 Thread Chad Versace
On 07/24/2013 03:23 AM, Topi Pohjolainen wrote: Memory originating outside mesa stack is meant to be for reading only. In addition, the restrictions imposed by the image external extension should apply. For example, users shouldn't be allowed to generare mip-trees based on these images. v2 (Chad

Re: [Mesa-dev] [PATCH vmwgfx] update for XA API changes

2013-07-24 Thread Jakob Bornecrantz
Sure, okay with me. I'll push this patch to the video-vmware repo. Cheers, Jakob. On Thu, Jul 25, 2013 at 1:20 AM, Rob Clark wrote: > On Wed, Jul 24, 2013 at 6:33 PM, Jakob Bornecrantz > wrote: > > On Thu, Jul 11, 2013 at 1:58 AM, Jakob Bornecrantz > > > wrote: > >> > >> Just tried this out,

Re: [Mesa-dev] [v8 8/9] egl/dri2: support for creating images out of dma buffers

2013-07-24 Thread Chad Versace
On 07/24/2013 03:23 AM, Topi Pohjolainen wrote: v2: - upon success close the given file descriptors v3: - use specific entry for dma buffers instead of the basic for primes, and enable the extension based on the availability of the hook v4 (Chad): - use ARRAY_SIZE -

Re: [Mesa-dev] [v8 9/9] i965: enable image external sampling for imported dma-buffers

2013-07-24 Thread Chad Versace
This patch is Reviewed-by: Chad Versace with the understanding that it depends on previous patches. I'll begin reviewing your Piglit tests now. On 07/24/2013 03:23 AM, Topi Pohjolainen wrote: Signed-off-by: Topi Pohjolainen --- src/mesa/drivers/dri/i965/intel_extensions.c | 1 + src/mesa/d

[Mesa-dev] [PATCH] gallium/vl: add prime support

2013-07-24 Thread Dave Airlie
From: Dave Airlie This fixes the dri2 opening to check if DRI_PRIME is set, and picks the correct drm device path to open, this along with a change to libvdpau allows vdpauinfo to work at least, Martin Peres tested with nouveau, and there seems to be a further issue with final displaying, it onl

Re: [Mesa-dev] [v8 8/9] egl/dri2: support for creating images out of dma buffers

2013-07-24 Thread Pohjolainen, Topi
On Wed, Jul 24, 2013 at 05:02:50PM -0700, Chad Versace wrote: > On 07/24/2013 03:23 AM, Topi Pohjolainen wrote: > >v2: > >- upon success close the given file descriptors > > > >v3: > >- use specific entry for dma buffers instead of the basic for > > primes, and enable the extension bas

[Mesa-dev] [PATCH] gallivm: Remove NoFramePointerElimNonLeaf for LLVM >= 3.4.

2013-07-24 Thread Vinson Lee
TargetOptions::NoFramePointerElimNonLeaf was removed in LLVM 3.4 r187093. Signed-off-by: Vinson Lee --- src/gallium/auxiliary/gallivm/lp_bld_misc.cpp | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/gallium/auxiliary/gallivm/lp_bld_misc.cpp b/src/gallium/auxiliary/gallivm/lp_bld_misc.c