[Mesa-dev] Build with optimization + debug and 'Mesa errors' messages

2012-12-31 Thread Fabio Pedretti
After commit 122345876 there is no way to change compiler optimization flag on a debug build, since -O0 gets added after your CFLAGS. Can this be changed? Also it would be nice to always enable, also on non debug builds, the messages about Mesa errors in output_if_debug. It can be enabled with M

Re: [Mesa-dev] [PATCH] nv50/codegen/nv50_ir.cpp: #include on -DNDEBUG.

2012-12-31 Thread Christoph Bumiller
On 31.12.2012 04:21, Johannes Obermayr wrote: > Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=58879 > --- > On debug builds it is included: > nv50_ir.cpp:23 -> nv50_ir.h:33 -> nv50_ir_util.h:33 -> And on non-debug builds it's supposed to *not* be included, because they should work without r

Re: [Mesa-dev] [PATCH] nv50/codegen/nv50_ir.cpp: #include on -DNDEBUG.

2012-12-31 Thread Christoph Bumiller
On 31.12.2012 14:01, Christoph Bumiller wrote: > On 31.12.2012 04:21, Johannes Obermayr wrote: >> Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=58879 >> --- >> On debug builds it is included: >> nv50_ir.cpp:23 -> nv50_ir.h:33 -> nv50_ir_util.h:33 -> > And on non-debug builds it's supposed to

Re: [Mesa-dev] [PATCH] configure.ac: Save user {C, CXX}FLAGS and append them at end.

2012-12-31 Thread Dan Nicholson
On Sun, Dec 23, 2012 at 3:41 AM, Johannes Obermayr wrote: > Am Samstag, 22. Dezember 2012, 16:34:48 schrieben Sie: >> On Sat, Dec 22, 2012 at 10:47 AM, Johannes Obermayr >> wrote: >> > Am Samstag, 22. Dezember 2012, 09:21:33 schrieb Matt Turner: >> >> On Sat, Dec 22, 2012 at 9:16 AM, Johannes Obe

Re: [Mesa-dev] [PATCH 1/2] r600g: rework handling of the constants

2012-12-31 Thread Tom Stellard
On Wed, Dec 26, 2012 at 05:38:27PM +0100, Vincent Lejeune wrote: > From Vadim Girlin patch > --- > src/gallium/drivers/r600/r600_llvm.c | 27 +++ > src/gallium/drivers/r600/r600_shader.c | 39 > -- > .../drivers/radeon/radeon_setup_tgsi_ll

Re: [Mesa-dev] [PATCH 1/2] r600g: rework handling of the constants

2012-12-31 Thread Vincent
Le dimanche 30 décembre 2012 à 10:29 -0500, Tom Stellard a écrit : > On Wed, Dec 26, 2012 at 05:38:27PM +0100, Vincent Lejeune wrote: > > From Vadim Girlin patch > > --- > > src/gallium/drivers/r600/r600_llvm.c | 27 +++ > > src/gallium/drivers/r600/r600_shader.c

[Mesa-dev] [PATCH 1/2] mesa: Fix error reporting in _mesa_invalidate_pbo_{compressed_, }teximage.

2012-12-31 Thread Paul Berry
The old error reporting was completely bogus, passing _mesa_error() a format string that didn't even match the remaining arguments. Also, in many cases the number of dimensions in the TexImage call was not preserved in the error message (e.g. an error in glTexImage2D was reported simply as an erro

[Mesa-dev] [PATCH 2/2] mesa: Implement compressed 2D array textures.

2012-12-31 Thread Paul Berry
This patch adds functionality to Mesa to upload compressed 2-dimensional array textures, using the glCompressedTexImage3D and glCompressedTexSubImage3D calls. Fixes piglit tests "EXT_texture_array/compressed *" and "!OpenGL ES 3.0/ext_texture_array-compressed_gles3 *". Also partially fixes GLES3

Re: [Mesa-dev] [PATCH 1/2] mesa: Fix error reporting in _mesa_invalidate_pbo_{compressed_, }teximage.

2012-12-31 Thread Matt Turner
On Mon, Dec 31, 2012 at 11:18 AM, Paul Berry wrote: > The old error reporting was completely bogus, passing _mesa_error() a > format string that didn't even match the remaining arguments. Also, > in many cases the number of dimensions in the TexImage call was not > preserved in the error message

Re: [Mesa-dev] [PATCH 2/2] mesa: Implement compressed 2D array textures.

2012-12-31 Thread Jordan Justen
Series Reviewed-by: Jordan Justen On Mon, Dec 31, 2012 at 11:18 AM, Paul Berry wrote: > This patch adds functionality to Mesa to upload compressed > 2-dimensional array textures, using the glCompressedTexImage3D and > glCompressedTexSubImage3D calls. > > Fixes piglit tests "EXT_texture_array/com

Re: [Mesa-dev] [PATCH 1/2] r600g: rework handling of the constants

2012-12-31 Thread Vadim Girlin
On 12/31/2012 10:39 PM, Vincent wrote: Le dimanche 30 décembre 2012 à 10:29 -0500, Tom Stellard a écrit : On Wed, Dec 26, 2012 at 05:38:27PM +0100, Vincent Lejeune wrote: From Vadim Girlin patch --- src/gallium/drivers/r600/r600_llvm.c | 27 +++ src/gallium/drivers

Re: [Mesa-dev] [PATCH] r600g: rework check_and_set_bank_swizzle

2012-12-31 Thread Vadim Girlin
On 12/31/2012 05:34 AM, Vadim Girlin wrote: Optimize it for better performance. Signed-off-by: Vadim Girlin --- I did some benchmarking for this patch together with the patch that introduces ISA tables, using the texCombine test (IIRC it builds hundreds of shaders) and making the driver build

[Mesa-dev] [PATCH] configure.ac: Remove space after indent -T flag.

2012-12-31 Thread Vinson Lee
Fixes this build error on platforms not using GNU indent. indent: Command line: ``-T'' requires a parameter Signed-off-by: Vinson Lee --- configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index 1294740..87bb71f 100644 --- a/configure.ac

Re: [Mesa-dev] [PATCH] configure.ac: Remove space after indent -T flag.

2012-12-31 Thread Matt Turner
On Mon, Dec 31, 2012 at 3:27 PM, Vinson Lee wrote: > Fixes this build error on platforms not using GNU indent. > > indent: Command line: ``-T'' requires a parameter > > Signed-off-by: Vinson Lee > --- > configure.ac | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/configu

[Mesa-dev] [PATCH 1/3] mesa: Mark _mesa_{init, delete}_sampler_object as static

2012-12-31 Thread Matt Turner
--- src/mesa/main/samplerobj.c |4 ++-- src/mesa/main/samplerobj.h |7 --- 2 files changed, 2 insertions(+), 9 deletions(-) diff --git a/src/mesa/main/samplerobj.c b/src/mesa/main/samplerobj.c index 3c3bfff..9b21216 100644 --- a/src/mesa/main/samplerobj.c +++ b/src/mesa/main/samplerob

[Mesa-dev] [PATCH 3/3] mesa: Add missing ASSERT_OUTSIDE_BEGIN_END to GetSamplerParameter*

2012-12-31 Thread Matt Turner
--- src/mesa/main/samplerobj.c |8 1 files changed, 8 insertions(+), 0 deletions(-) diff --git a/src/mesa/main/samplerobj.c b/src/mesa/main/samplerobj.c index 1d441bc..773bebf 100644 --- a/src/mesa/main/samplerobj.c +++ b/src/mesa/main/samplerobj.c @@ -1135,6 +1135,8 @@ _mesa_GetSamp

[Mesa-dev] [PATCH 2/3] mesa: Add missing ASSERT_OUTSIDE_BEGIN_END to SamplerParameter*

2012-12-31 Thread Matt Turner
Commit f22d49de added the SamplerParamter* functions but only used ASSERT_OUTSIDE_BEGIN_END inside the -f and -fv versions. --- src/mesa/main/samplerobj.c |8 1 files changed, 8 insertions(+), 0 deletions(-) diff --git a/src/mesa/main/samplerobj.c b/src/mesa/main/samplerobj.c index 9

Re: [Mesa-dev] [PATCH 1/3] mesa: Mark _mesa_{init, delete}_sampler_object as static

2012-12-31 Thread Kenneth Graunke
On 12/31/2012 08:35 PM, Matt Turner wrote: --- src/mesa/main/samplerobj.c |4 ++-- src/mesa/main/samplerobj.h |7 --- 2 files changed, 2 insertions(+), 9 deletions(-) diff --git a/src/mesa/main/samplerobj.c b/src/mesa/main/samplerobj.c index 3c3bfff..9b21216 100644 --- a/src/mesa