Re: [Mesa-dev] [PATCH] i965: Fail to blit rather than assert on invalid pitch requirements.

2012-12-26 Thread Jordan Justen
I also hit this assert for gles3conform, but in my case it required another simultaneous change to intel_tex_image.c to not crash. Reviewed-by: Jordan Justen On Tue, Dec 25, 2012 at 8:55 PM, Kenneth Graunke wrote: > Dungeon Defenders hits TexImage()'s try_pbo_upload() path where > image->Width

Re: [Mesa-dev] [PATCH] i965: Fail to blit rather than assert on invalid pitch requirements.

2012-12-26 Thread Paul Berry
On 25 December 2012 20:55, Kenneth Graunke wrote: > Dungeon Defenders hits TexImage()'s try_pbo_upload() path where > image->Width == 2, which doesn't meet intelEmitCopyBlit's requirement > that the pitch needs to be a multiple of 4. > > Since intelEmitCopyBlit can already fail for a myriad of ot

[Mesa-dev] [PATCH 1/4] R600: Factorise VTX_WORD0 and VTX_WORD1 in tblgen def

2012-12-26 Thread Vincent Lejeune
--- lib/Target/AMDGPU/R600Instructions.td | 110 -- 1 file changed, 65 insertions(+), 45 deletions(-) diff --git a/lib/Target/AMDGPU/R600Instructions.td b/lib/Target/AMDGPU/R600Instructions.td index 66c9249..7921fe1e 100644 --- a/lib/Target/AMDGPU/R600Instructions

[Mesa-dev] [PATCH 2/4] R600: Add a CONST_ADDRESS node to model constant buf read

2012-12-26 Thread Vincent Lejeune
--- lib/Target/AMDGPU/AMDGPUISelLowering.cpp | 1 + lib/Target/AMDGPU/AMDGPUISelLowering.h | 1 + lib/Target/AMDGPU/R600Instructions.td| 11 ++- 3 files changed, 12 insertions(+), 1 deletion(-) diff --git a/lib/Target/AMDGPU/AMDGPUISelLowering.cpp b/lib/Target/AMDGPU/AMDGPUISelLo

[Mesa-dev] [PATCH 3/4] R600: rework handling of the constants

2012-12-26 Thread Vincent Lejeune
From: Vadim Girlin Remove Cxxx registers, add new special register - "ALU_CONST" and new operand for each alu src - "sel". ALU_CONST is used to designate that the new operand contains the value to override src.sel, src.kc_bank, src.chan for constants in the driver. v2[Vincent Lejeune]: -Parse l

[Mesa-dev] [PATCH 4/4] R600: Fold CONST_ADDRESS when possible

2012-12-26 Thread Vincent Lejeune
--- lib/Target/AMDGPU/AMDILISelDAGToDAG.cpp | 27 ++- 1 file changed, 26 insertions(+), 1 deletion(-) diff --git a/lib/Target/AMDGPU/AMDILISelDAGToDAG.cpp b/lib/Target/AMDGPU/AMDILISelDAGToDAG.cpp index 6f156df..6e07734 100644 --- a/lib/Target/AMDGPU/AMDILISelDAGToDAG.cpp

[Mesa-dev] [PATCH 1/2] r600g: rework handling of the constants

2012-12-26 Thread Vincent Lejeune
>From Vadim Girlin patch --- src/gallium/drivers/r600/r600_llvm.c | 27 +++ src/gallium/drivers/r600/r600_shader.c | 39 -- .../drivers/radeon/radeon_setup_tgsi_llvm.c| 4 +++ 3 files changed, 54 insertions(+), 16 deletions(-) dif

[Mesa-dev] [PATCH 2/2] r600g: tgsi to llvm emits store.swizzle intrinsic for vs/fs output

2012-12-26 Thread Vincent Lejeune
--- src/gallium/drivers/r600/r600_llvm.c | 194 ++- src/gallium/drivers/r600/r600_shader.c | 6 +- src/gallium/drivers/radeon/radeon_llvm.h | 1 + 3 files changed, 144 insertions(+), 57 deletions(-) diff --git a/src/gallium/drivers/r600/r600_llvm.c b/src/gal

Re: [Mesa-dev] [PATCH] i965: Fail to blit rather than assert on invalid pitch requirements.

2012-12-26 Thread Kenneth Graunke
On 12/26/2012 08:32 AM, Paul Berry wrote: On 25 December 2012 20:55, Kenneth Graunke mailto:kenn...@whitecape.org>> wrote: Dungeon Defenders hits TexImage()'s try_pbo_upload() path where image->Width == 2, which doesn't meet intelEmitCopyBlit's requirement that the pitch needs to be

Re: [Mesa-dev] [PATCH] i965: Fail to blit rather than assert on invalid pitch requirements.

2012-12-26 Thread Matt Turner
On Tue, Dec 25, 2012 at 8:55 PM, Kenneth Graunke wrote: > Dungeon Defenders hits TexImage()'s try_pbo_upload() path where > image->Width == 2, which doesn't meet intelEmitCopyBlit's requirement > that the pitch needs to be a multiple of 4. > > Since intelEmitCopyBlit can already fail for a myriad

Re: [Mesa-dev] [PATCH 2/2] intel: Skip texture validation logic when nothing has changed.

2012-12-26 Thread Eric Anholt
Kenneth Graunke writes: > On 12/23/2012 11:43 PM, Eric Anholt wrote: >> Improves GLBenchmark 2.1 offscreen performance by 3.2% +/- 1.5% (n=52). >> --- >> src/mesa/drivers/dri/intel/intel_mipmap_tree.c |3 +++ >> src/mesa/drivers/dri/intel/intel_tex.c |4 >> src/mesa/dri

[Mesa-dev] [PATCH] xlib: handle _mesa_initialize_visual()'s return value

2012-12-26 Thread Brian Paul
From: Brian Paul If the call fails, we should return NULL from XMesaCreateVisual(). This was found when Waffle tried to create a visual with depth/stencil bits = -1. That's an illegal value for glXChooseFBConfig() and we should return NULL in that situation. Note: This is a candidate for the st

[Mesa-dev] r600g glsl 1.40 streamout with no position test

2012-12-26 Thread Dave Airlie
So I've got a persistent hang with the glsl-1.40-tf-no-position when I enabled ubo/tbo and glsl 1.40. My original thoughts were there was no param export from the vertex shader, but I was wrong on that count, the vertex shader exports a param along with the stream output. Below is the TGSI/r600g

Re: [Mesa-dev] r600g glsl 1.40 streamout with no position test

2012-12-26 Thread Marek Olšák
On Thu, Dec 27, 2012 at 12:54 AM, Dave Airlie wrote: > So I've got a persistent hang with the glsl-1.40-tf-no-position when I > enabled ubo/tbo and glsl 1.40. > > My original thoughts were there was no param export from the vertex > shader, but I was wrong on that count, the > vertex shader export

[Mesa-dev] [Bug 58548] [swrast] SIGSEGV src/mesa/swrast/s_texfetch.c:100

2012-12-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=58548 Brian Paul changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---