[Mesa-dev] [Bug 44405] Spring RTS crashes using r600g (5670, Redwood), kernel rejects relocations

2012-04-09 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=44405 José Fonseca changed: What|Removed |Added CC||bri...@vmware.com, |

Re: [Mesa-dev] [PATCH 6/7] softpipe: add dual source blending support

2012-04-09 Thread Dave Airlie
On Wed, Apr 4, 2012 at 4:16 PM, Brian Paul wrote: > On 04/03/2012 07:16 AM, Dave Airlie wrote: >> >> From: Dave Airlie >> >> This adds support for a single dual source blending MRT to softpipe. > > > Why can't we do dual-source blending to all RTs? The problem is currently TGSI can't encode (loca

Re: [Mesa-dev] [PATCH 6/7] softpipe: add dual source blending support

2012-04-09 Thread Brian Paul
On 04/09/2012 09:14 AM, Dave Airlie wrote: On Wed, Apr 4, 2012 at 4:16 PM, Brian Paul wrote: On 04/03/2012 07:16 AM, Dave Airlie wrote: From: Dave Airlie This adds support for a single dual source blending MRT to softpipe. Why can't we do dual-source blending to all RTs? The problem is

Re: [Mesa-dev] [PATCH] st/mesa: Fix uninitialized members in glsl_to_tgsi_visitor constructor.

2012-04-09 Thread Brian Paul
On 04/08/2012 11:40 PM, Vinson Lee wrote: Fixes uninitialized member defects reported by Coverity. NOTE: This is a candidate for the 8.0 branch. Signed-off-by: Vinson Lee --- src/mesa/state_tracker/st_glsl_to_tgsi.cpp |4 1 file changed, 4 insertions(+) diff --git a/src/mesa/state_

[Mesa-dev] [PATCH 0/8] [RFC] improve driconf support for gallium

2012-04-09 Thread Vadim Girlin
These patches allow to use driver-specific driconf settings, and to handle these options in the state tracker. It's then used to handle force_glsl_extensions_warn option, so we could use it e.g. for unigine applications. gallium: add get_driver_name to pipe_screen st/dri: use pipe_screen::ge

[Mesa-dev] [PATCH 1/8] gallium: add get_driver_name to pipe_screen

2012-04-09 Thread Vadim Girlin
Returned string will be used as the driver name for driconf lookup. Signed-off-by: Vadim Girlin --- src/gallium/include/pipe/p_screen.h |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/src/gallium/include/pipe/p_screen.h b/src/gallium/include/pipe/p_screen.h index 45c441

[Mesa-dev] [PATCH 2/8] st/dri: use pipe_screen::get_driver_name to select the config

2012-04-09 Thread Vadim Girlin
If optional pipe_screen::get_driver_name is implemented, then use returned string to select the configuration, instead of "dri". Signed-off-by: Vadim Girlin --- .../state_trackers/dri/common/dri_context.c| 10 +- 1 files changed, 9 insertions(+), 1 deletions(-) diff --git a/sr

[Mesa-dev] [PATCH 3/8] gallium: add optionCache to st_context_attribs

2012-04-09 Thread Vadim Girlin
This will be used to pass the configuration options through the context creation calls. Signed-off-by: Vadim Girlin --- src/gallium/include/state_tracker/st_api.h |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/src/gallium/include/state_tracker/st_api.h b/src/gallium/

[Mesa-dev] [PATCH 4/8] st/dri: pass optionCache in the st_context_attribs

2012-04-09 Thread Vadim Girlin
Signed-off-by: Vadim Girlin --- .../state_trackers/dri/common/dri_context.c|2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/src/gallium/state_trackers/dri/common/dri_context.c b/src/gallium/state_trackers/dri/common/dri_context.c index 780cab1..bf115e9 100644 --

[Mesa-dev] [PATCH 5/8] st/mesa: pass the configuration options to st_init_extensions

2012-04-09 Thread Vadim Girlin
Signed-off-by: Vadim Girlin --- src/mesa/state_tracker/st_context.c|9 + src/mesa/state_tracker/st_context.h|3 ++- src/mesa/state_tracker/st_extensions.c |2 +- src/mesa/state_tracker/st_extensions.h |2 +- src/mesa/state_tracker/st_manager.c|2 +- 5 file

[Mesa-dev] [PATCH 6/8] st/dri: add force_glsl_extensions_warn option to dri configuration

2012-04-09 Thread Vadim Girlin
Signed-off-by: Vadim Girlin --- src/gallium/state_trackers/dri/common/dri_screen.c | 11 ++- 1 files changed, 10 insertions(+), 1 deletions(-) diff --git a/src/gallium/state_trackers/dri/common/dri_screen.c b/src/gallium/state_trackers/dri/common/dri_screen.c index 24efbde..3c6d24b 1

[Mesa-dev] [PATCH 7/8] st/mesa: handle force_glsl_extensions_warn

2012-04-09 Thread Vadim Girlin
Signed-off-by: Vadim Girlin --- src/mesa/state_tracker/st_extensions.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/src/mesa/state_tracker/st_extensions.c b/src/mesa/state_tracker/st_extensions.c index 0c98611..47e2373 100644 --- a/src/mesa/state_tracker/st_extensi

[Mesa-dev] [PATCH 8/8] r600g: implement pipe_screen::get_driver_name

2012-04-09 Thread Vadim Girlin
Signed-off-by: Vadim Girlin --- src/gallium/drivers/r600/r600_pipe.c |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/src/gallium/drivers/r600/r600_pipe.c b/src/gallium/drivers/r600/r600_pipe.c index 7c40e50..35553f4 100644 --- a/src/gallium/drivers/r600/r600_pipe.c

[Mesa-dev] [PATCH 1/2] r600g: store glsl_feature_level in the r600_screen

2012-04-09 Thread Vadim Girlin
Signed-off-by: Vadim Girlin --- src/gallium/drivers/r600/r600_pipe.c |3 ++- src/gallium/drivers/r600/r600_pipe.h |1 + 2 files changed, 3 insertions(+), 1 deletions(-) diff --git a/src/gallium/drivers/r600/r600_pipe.c b/src/gallium/drivers/r600/r600_pipe.c index 35553f4..6486640 10064

[Mesa-dev] [PATCH 2/2] r600g: disable I2F conversion for InstanceID if integers are supported

2012-04-09 Thread Vadim Girlin
Signed-off-by: Vadim Girlin --- src/gallium/drivers/r600/r600_shader.c | 27 --- 1 files changed, 16 insertions(+), 11 deletions(-) diff --git a/src/gallium/drivers/r600/r600_shader.c b/src/gallium/drivers/r600/r600_shader.c index 1adf344..bfae51c 100644 --- a/src/gal

Re: [Mesa-dev] [PATCH] x86-64: Don't print "Initializing x86-64 optimizations" in debug builds.

2012-04-09 Thread Eric Anholt
On Mon, 2 Apr 2012 14:56:14 -0700, Kenneth Graunke wrote: > In "release" builds, Mesa would print this message if the MESA_DEBUG > variable was set. Make it so for debug builds as well. > > I build debug builds all the time, but I'm not debugging this. > > Signed-off-by: Kenneth Graunke Any

Re: [Mesa-dev] [PATCH 1/2] i965: Remove vestiges of function call support from the old VS backend.

2012-04-09 Thread Eric Anholt
On Mon, 2 Apr 2012 14:30:52 -0700, Kenneth Graunke wrote: > This never worked. brwProgramStringNotify also explicitly rejects > programs that use CAL and RET. So there's no need for this to exist. > > Signed-off-by: Kenneth Graunke This series is: Reviewed-by: Eric Anholt pgp3FWBfVmK7w.

[Mesa-dev] [PATCH] i965: Stop lying about cpp and height of a stencil buffer.

2012-04-09 Thread Paul Berry
When using a separate stencil buffer, i965 requires that the pitch of the buffer (in the 3DSTATE_STENCIL_BUFFER command) be specified as 2x the actual pitch. Previously this was accomplished by doubling the "cpp" and "pitch" values stored in the intel_region data structure, and halving the height.

Re: [Mesa-dev] [PATCH] i965: Stop lying about cpp and height of a stencil buffer.

2012-04-09 Thread Kenneth Graunke
On 04/09/2012 09:43 AM, Paul Berry wrote: When using a separate stencil buffer, i965 requires that the pitch of the buffer (in the 3DSTATE_STENCIL_BUFFER command) be specified as 2x the actual pitch. Previously this was accomplished by doubling the "cpp" and "pitch" values stored in the intel_re

Re: [Mesa-dev] [PATCH 2/7] glsl: add support for ARB_blend_func_extended (v2)

2012-04-09 Thread Eric Anholt
On Tue, 3 Apr 2012 14:16:52 +0100, Dave Airlie wrote: > From: Dave Airlie > > This adds index support to the GLSL compiler. > > I'm not 100% sure of my approach here, esp without how output ordering > happens wrt location, index pairs, in the "mark" function. > > Since current hw doesn't ever

Re: [Mesa-dev] [PATCH 1/7] mesa: add support for ARB_blend_func_extended (v3)

2012-04-09 Thread Eric Anholt
On Tue, 3 Apr 2012 14:16:51 +0100, Dave Airlie wrote: > From: Dave Airlie > > Add implementations of the two API functions, > Add a new strings to uint mapping for index bindings > Add the blending mode validation for SRC1 + SRC_ALPHA_SATURATE > Add get for MAX_DUAL_SOURCE_DRAW_BUFFERS > > v2:

[Mesa-dev] [PATCH] r600g: check gpr count limit

2012-04-09 Thread Vadim Girlin
This should help to prevent gpu lockups. See https://bugs.freedesktop.org/show_bug.cgi?id=48472 Signed-off-by: Vadim Girlin --- src/gallium/drivers/r600/r600_shader.c |8 1 files changed, 8 insertions(+), 0 deletions(-) diff --git a/src/gallium/drivers/r600/r600_shader.c b/src/gal

Re: [Mesa-dev] [PATCH] i965: Stop lying about cpp and height of a stencil buffer.

2012-04-09 Thread Paul Berry
On 9 April 2012 10:59, Kenneth Graunke wrote: > On 04/09/2012 09:43 AM, Paul Berry wrote: > >> When using a separate stencil buffer, i965 requires that the pitch of >> the buffer (in the 3DSTATE_STENCIL_BUFFER command) be specified as 2x >> the actual pitch. >> >> Previously this was accomplished

Re: [Mesa-dev] [PATCH] i965: Stop lying about cpp and height of a stencil buffer.

2012-04-09 Thread Chad Versace
One comment. On 04/09/2012 09:43 AM, Paul Berry wrote: > When using a separate stencil buffer, i965 requires that the pitch of > the buffer (in the 3DSTATE_STENCIL_BUFFER command) be specified as 2x > the actual pitch. > > Previously this was accomplished by doubling the "cpp" and "pitch" > value

[Mesa-dev] ir_builder take 2

2012-04-09 Thread Eric Anholt
Here's the udpated ir_builder changeset. Now at +140 lines, I think I'll still land it given that idr has said he's interested in it for the ARB programs to GLSL conversion work. It now uses C++ tricks (noted in a big comment) to get compile-time type checking and ir_dereference_variable generati

[Mesa-dev] [PATCH 2/6] glsl: Let ir_builder expressions take un-dereferenced variables.

2012-04-09 Thread Eric Anholt
Having to explicitly dereference is irritating and bloats the code, when the compiler can detect and do the right thing. v2: Use a little shim class to produce the automatic dereference generation at compile time as opposed to runtime, while also allowing compile-time type checking. --- s

[Mesa-dev] [PATCH 1/6] glsl: Create an ir_builder helper for hand-generating IR.

2012-04-09 Thread Eric Anholt
The C++ constructors with placement new, while functional, are extremely verbose, leading to generation of simple GLSL IR expressions like (a * b + c * d) expanding to many lines of code and using lots of temporary variables. By creating a new ir_builder.h that puts simple generators in our namesp

[Mesa-dev] [PATCH 4/6] glsl: Make a little tracking class for emitting IR lists.

2012-04-09 Thread Eric Anholt
This lets us significantly shorten p->instructions->push_tail(ir), and will be used in a few more places. --- src/glsl/ir_builder.cpp |6 +++ src/glsl/ir_builder.h|8 src/mesa/main/ff_fragment_shader.cpp | 78 -- 3 files c

[Mesa-dev] [PATCH 3/6] glsl: Add common swizzles to ir_builder.

2012-04-09 Thread Eric Anholt
Now we can fold a bunch of our expression setup in ff_fragment_shader into single-line, parseable commits. v2: Make it actually work. I wasn't setting num_components in the mask structure, and not setting up a mask structure is way easier. --- src/glsl/ir_builder.cpp | 80

[Mesa-dev] [PATCH 6/6] glsl: Add a helper for generating temporary variables in ir_builder.

2012-04-09 Thread Eric Anholt
--- src/glsl/ir_builder.cpp | 11 + src/glsl/ir_builder.h|1 + src/mesa/main/ff_fragment_shader.cpp | 42 +- 3 files changed, 23 insertions(+), 31 deletions(-) diff --git a/src/glsl/ir_builder.cpp b/src/glsl/ir_builder.c

[Mesa-dev] [PATCH 5/6] glsl: Add a helper for ir_builder to make dereferences for assignments.

2012-04-09 Thread Eric Anholt
v2: Fix writemask setup for non-vec4 assignments. --- src/glsl/ir_builder.cpp | 18 ++ src/glsl/ir_builder.h| 24 + src/mesa/main/ff_fragment_shader.cpp | 66 +- 3 files changed, 59 insertions(+), 49 deletions(-

[Mesa-dev] [PATCH] main: Fix memory leak in _mesa_make_extension_string()

2012-04-09 Thread Chad Versace
I forgot to free the string returned by strdup(). Note: This is a candidate for the stable branches. CC: Johannes Obermayr Signed-off-by: Chad Versace --- src/mesa/main/extensions.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/src/mesa/main/extensions.c b/src/mesa/m

[Mesa-dev] [Bug 48424] Fix warnings/errors reported by clang's scan-build tool

2012-04-09 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=48424 --- Comment #2 from Chad Versace 2012-04-09 14:30:44 UTC --- Thanks for doing this. Here's my review of mesa/main/extensions.c. mesa/main/extensions.c:730: Thanks. I just submitted a patch for this memory leak. You're CC'd. mesa/main/extension

Re: [Mesa-dev] [PATCH] main: Fix memory leak in _mesa_make_extension_string()

2012-04-09 Thread Ian Romanick
On 04/09/2012 02:23 PM, Chad Versace wrote: I forgot to free the string returned by strdup(). Note: This is a candidate for the stable branches. CC: Johannes Obermayr Signed-off-by: Chad Versace I think the tag should be "mesa:", not "main:". Other than that, Reviewed-by: Ian Romanick ---

Re: [Mesa-dev] [PATCH 6/9] i965: fix typo

2012-04-09 Thread Chad Versace
On 04/01/2012 03:24 PM, nobled wrote: > Noticed by clang: > > brw_wm_surface_state.c:330:30: warning: initializer overrides prior > initialization of this subobject [-Winitializer-overrides] > [MESA_FORMAT_Z24_S8] = 0, > ^ > brw_wm_surface_state.c:326:30: note: p

Re: [Mesa-dev] [PATCH] r600g: check gpr count limit

2012-04-09 Thread Alex Deucher
On Mon, Apr 9, 2012 at 4:44 PM, Vadim Girlin wrote: > This should help to prevent gpu lockups. > See https://bugs.freedesktop.org/show_bug.cgi?id=48472 > > Signed-off-by: Vadim Girlin Reviewed-by: Alex Deucher Should probably also add a note that this should be applied to the stable branches a

[Mesa-dev] [PATCH] mapi: Fix Android build

2012-04-09 Thread Chad Versace
The Android build was broken by commit ca760181b4420696c7e86aa2951d7203522ad1e8 Author: Kristian Høgsberg Date: Fri Mar 16 12:55:40 2012 -0400 Subject: shared-glapi: Convert to automake The guilty change in that commit was changing the variable pattern in sources.mak from FO

Re: [Mesa-dev] [PATCH] mapi: Fix Android build

2012-04-09 Thread Chad Versace
On 04/09/2012 05:05 PM, Chad Versace wrote: > The Android build was broken by > commit ca760181b4420696c7e86aa2951d7203522ad1e8 > Author: Kristian Høgsberg > Date: Fri Mar 16 12:55:40 2012 -0400 > Subject: shared-glapi: Convert to automake > > The guilty change in that commit wa

[Mesa-dev] [Bug 39219] libgl conflict with xbmc causes lock up on xbmc exit

2012-04-09 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=39219 Shawn Landden changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|FIXED

[Mesa-dev] [Bug 39219] libgl conflict with xbmc causes lock up on xbmc exit

2012-04-09 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=39219 --- Comment #12 from Shawn Landden 2012-04-09 22:27:00 PDT --- xserver-xorg-video-radeon (1:6.14.99+git20120330.de2419e5-0ubuntu0sarvatt2) ... xserver-xorg-core (2:1.12.0.901+git20120406+server-1.12-branch.259aa5a6-0ubuntu0ricotz2) ... libdrm2 (

Re: [Mesa-dev] [PATCH 1/6] glsl: Create an ir_builder helper for hand-generating IR.

2012-04-09 Thread Kenneth Graunke
On 04/09/2012 02:22 PM, Eric Anholt wrote: The C++ constructors with placement new, while functional, are extremely verbose, leading to generation of simple GLSL IR expressions like (a * b + c * d) expanding to many lines of code and using lots of temporary variables. By creating a new ir_builde

Re: [Mesa-dev] [PATCH 4/6] glsl: Make a little tracking class for emitting IR lists.

2012-04-09 Thread Kenneth Graunke
On 04/09/2012 02:22 PM, Eric Anholt wrote: This lets us significantly shorten p->instructions->push_tail(ir), and will be used in a few more places. --- src/glsl/ir_builder.cpp |6 +++ src/glsl/ir_builder.h|8 src/mesa/main/ff_fragment_shader.cpp |

Re: [Mesa-dev] ir_builder take 2

2012-04-09 Thread Kenneth Graunke
On 04/09/2012 02:22 PM, Eric Anholt wrote: Here's the udpated ir_builder changeset. Now at +140 lines, I think I'll still land it given that idr has said he's interested in it for the ARB programs to GLSL conversion work. It now uses C++ tricks (noted in a big comment) to get compile-time type