https://bugs.freedesktop.org/show_bug.cgi?id=47967
Michel Dänzer changed:
What|Removed |Added
Status|NEW |RESOLVED
Resolution|
https://bugs.freedesktop.org/show_bug.cgi?id=47878
Christian König changed:
What|Removed |Added
Status|NEW |ASSIGNED
CC|
On Tue, Mar 27, 2012 at 11:34:40PM -0400, Matt Turner wrote:
> On Tue, Mar 27, 2012 at 10:24 PM, wrote:
> > From: Tom Stellard
> >
> > This option allows targets to link against the LLVM shared library
> > instead of the static libs. With LLVM 2.9, his saves ~13 MB for each of
> > the r300 targ
https://bugs.freedesktop.org/show_bug.cgi?id=47649
--- Comment #3 from Fabio Pedretti 2012-03-28 07:18:50
PDT ---
This is still reproducible also with the custom patches disabled:
https://launchpadlibrarian.net/98554602/buildlog_ubuntu-precise-i386.mesa_8.1~git1203271746.7f6af4~gd~p_FAILEDTOBUIL
Looks good to me. Thanks.
Jose
- Original Message -
> Use matching type qualifers to avoid method hiding.
>
> Signed-off-by: Vinson Lee
> ---
> src/gallium/auxiliary/gallivm/lp_bld_debug.cpp |6 +++---
> 1 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/src/gallium
https://bugs.freedesktop.org/show_bug.cgi?id=47878
--- Comment #3 from Christian König 2012-03-28
07:41:09 PDT ---
Created attachment 59161
--> https://bugs.freedesktop.org/attachment.cgi?id=59161
Possible fix.
Fixing the bug in the short hand is actually pretty easy, just replace the
obvious
https://bugs.freedesktop.org/show_bug.cgi?id=47649
--- Comment #4 from Kristian Høgsberg 2012-03-28 07:50:32
PDT ---
(In reply to comment #3)
> This is still reproducible also with the custom patches disabled:
> https://launchpadlibrarian.net/98554602/buildlog_ubuntu-precise-i386.mesa_8.1~git120
On 03/27/2012 02:51 PM, Marek Olšák wrote:
This replaces the cryptic void* parameter with a union.
(based on union r600_query_result)
Users of this can still pass uint64* in it, but that cannot work for every
query type, obviously. Most importantly, the code now documents what should
be expected
For both, Reviewed-by: Brian Paul
On Mon, Mar 26, 2012 at 1:57 PM, Eric Anholt wrote:
> Fixes piglit GL_ARB_texture_buffer_object/get
> ---
> src/mesa/main/texobj.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/src/mesa/main/texobj.c b/src/mesa/main/texobj.c
> i
Reviewed-by: Brian Paul
On Mon, Mar 26, 2012 at 1:42 PM, Eric Anholt wrote:
> ---
> src/mesa/main/ff_fragment_shader.cpp | 11 ---
> 1 files changed, 0 insertions(+), 11 deletions(-)
>
> diff --git a/src/mesa/main/ff_fragment_shader.cpp
> b/src/mesa/main/ff_fragment_shader.cpp
> ind
On 03/26/2012 12:42 PM, Eric Anholt wrote:
The C++ constructors with placement new, while functional, are
extremely verbose, leading to generation of simple GLSL IR expressions
like (a * b + c * d) expanding to many lines of code and using lots of
temporary variables. By creating a new ir_builde
This is set correctly in gl.spec, but was missed in Mesa. As a
result, only one of the two was hooked up in Mesa.
---
src/mapi/glapi/gen/GL3x.xml |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/src/mapi/glapi/gen/GL3x.xml b/src/mapi/glapi/gen/GL3x.xml
index 86a9a2c..ab49
Fixes piglit GL_ARB_texture_buffer_object/get
---
src/mesa/main/texobj.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/src/mesa/main/texobj.c b/src/mesa/main/texobj.c
index 97bef35..d7dee4f 100644
--- a/src/mesa/main/texobj.c
+++ b/src/mesa/main/texobj.c
@@ -153,6 +153,7
This gets the texture buffer object support to the point of running
and passing the piglit core tests other than deprecated formats on
i965.
Patch 2 is the glapi regen (I want the time back I've lost to
regen failure this week).
Patch 13 we may want to extend to gen6 before landing.
Patch 14 I'm
The type will be undefined in !glsl 1.40, and the keyword is marked as
reserved.
---
src/glsl/ast.h |3 +++
src/glsl/ast_type.cpp |3 +++
src/glsl/glsl_parser.yy |6 +-
src/glsl/glsl_types.cpp |5 -
4 files changed, 15 insertions(+), 2 deletions(-)
diff --git a/
We're supposed to just immediately call it. Fixes piglit
GL_ARB_texture_buffer_object/dlist
---
src/mesa/main/dlist.c |3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/src/mesa/main/dlist.c b/src/mesa/main/dlist.c
index f113573..8cfb97c 100644
--- a/src/mesa/main/dlist.c
All that should be needed is that it exists. Fixes segfaults on first
_mesa_update_context() with a samplerBuffer-using shader active but
without a particular buffer texture enabled.
---
src/glsl/builtins/tools/texture_builtins.py |4 +---
src/mesa/main/texobj.c |5 ++
Fix texelFetch(sampler2DRect) and textureSize(samplerBuffer)
generation to not reference a LOD at the same time because it's easier
than not fixing it.
---
src/glsl/builtins/profiles/140.frag |4
src/glsl/builtins/profiles/140.vert |4
src/glsl/builtins/tools/text
We have to skip some work that wants to look at texture images, since
buffer textures don't have any of that complexity.
---
src/mesa/main/texobj.c |8
src/mesa/main/texstate.c |4
2 files changed, 12 insertions(+), 0 deletions(-)
diff --git a/src/mesa/main/texobj.c b/src/
---
src/mesa/main/teximage.c | 54 ++
1 files changed, 54 insertions(+), 0 deletions(-)
diff --git a/src/mesa/main/teximage.c b/src/mesa/main/teximage.c
index 60b2528..2348646 100644
--- a/src/mesa/main/teximage.c
+++ b/src/mesa/main/teximage.c
@@ -38
It turns out this field *is* used, and it's the stride between samples
from the buffer. Discovered during TBO debugging.
---
src/mesa/drivers/dri/i965/gen7_wm_surface_state.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/src/mesa/drivers/dri/i965/gen7_wm_surface_state.
GL 3.1 promoted GL_RGBA to core, and added GL_R and GL_RG. It dropped
A/I/L/LA formats. Our hardware doesn't support the A/I/L/LA formats,
so if we want to support GL_ARB_texture_buffer_object on its own, we
have to map them to RG and swizzle their data into place.
---
src/mesa/drivers/dri/i965/
There was a function full of unused mappings from the GLenum to
datatype/comps, but that wasn't all the information a driver would
want, which includes the other fields that a gl_format has. Given
that all the texture buffer formats were represented in gl_format,
just use that as our description.
This was hacked in in one place for EGL image stuff, but the right
thing to do was just to provide the mapping from the mesa format to
the native hardware format, which includes render target support.
This turns out to be required for GL_ARB_texture_buffer_object, which
sees data in this layout.
-
---
src/mesa/drivers/dri/i965/brw_wm.c|2 +-
src/mesa/drivers/dri/i965/gen7_sampler_state.c|4 +
src/mesa/drivers/dri/i965/gen7_wm_surface_state.c | 62 +
src/mesa/drivers/dri/intel/intel_tex_validate.c |4 +
4 files changed, 71 insertions(+)
https://bugs.freedesktop.org/show_bug.cgi?id=47878
--- Comment #4 from Alexandre Demers 2012-03-28
11:40:58 PDT ---
This seems a good solution. My only concern is about the folder: do we want a
specific folder as for other trackers?
By the way, thank you for the info about configure.ac
(In rep
>
> diff --git a/src/mesa/main/teximage.c b/src/mesa/main/teximage.c
> index 60b2528..2348646 100644
> --- a/src/mesa/main/teximage.c
> +++ b/src/mesa/main/teximage.c
> @@ -3850,6 +3850,49 @@ get_texbuffer_format(const struct gl_context *ctx,
> GLenum internalFormat)
> return MESA_FORMAT_RGB
https://bugs.freedesktop.org/show_bug.cgi?id=47967
--- Comment #3 from Alexandre Demers 2012-03-28
11:48:13 PDT ---
While I understand the possible need for -Ldrm, why would it be the only driver
behaving like that? I mean, shouldn't the use of LIBS_LIBDRM=-L... replace the
need for -Ldrm in a w
On Wed, Mar 28, 2012 at 6:58 PM, Eric Anholt wrote:
> We have to skip some work that wants to look at texture images, since
> buffer textures don't have any of that complexity.
Reviewed-by: Dave Airlie
___
mesa-dev mailing list
mesa-dev@lists.freedeskt
On Sat, 17 Mar 2012 10:58:27 +0800, Liu Aleaxander wrote:
> On Sat, Mar 17, 2012 at 1:57 AM, Eric Anholt wrote:
> > On Mon, 12 Mar 2012 16:04:00 +0800, Yuanhan Liu
> > wrote:
> >> /**/
> >> /* High level hooks
Function calls may have side effects that alter variables used inside
the loop. In the fragment shader, they may even terminate the shader.
This means our analysis about loop-constant or induction variables may
be completely wrong.
In general it's impossible to determine whether they actually do
On Wed, Mar 28, 2012 at 01:21:18PM -0700, Eric Anholt wrote:
> On Sat, 17 Mar 2012 10:58:27 +0800, Liu Aleaxander
> wrote:
> > On Sat, Mar 17, 2012 at 1:57 AM, Eric Anholt wrote:
> > > On Mon, 12 Mar 2012 16:04:00 +0800, Yuanhan Liu
> > > wrote:
> > >> /***
On 03/28/2012 10:58 AM, Eric Anholt wrote:
The type will be undefined in !glsl 1.40, and the keyword is marked as
reserved.
---
src/glsl/ast.h |3 +++
src/glsl/ast_type.cpp |3 +++
src/glsl/glsl_parser.yy |6 +-
src/glsl/glsl_types.cpp |5 -
4 files change
On 03/28/2012 10:58 AM, Eric Anholt wrote:
All that should be needed is that it exists. Fixes segfaults on first
_mesa_update_context() with a samplerBuffer-using shader active but
without a particular buffer texture enabled.
---
src/glsl/builtins/tools/texture_builtins.py |4 +---
src/me
Function calls may have side effects that alter variables used inside
the loop. In the fragment shader, they may even terminate the shader.
This means our analysis about loop-constant or induction variables may
be completely wrong.
In general it's impossible to determine whether they actually do
I finally resurrected this work I started back in September. I think
I've included most of the old feedback, and done a bunch more cleaning.
This series changes ir_call from a value (which can be nested inside
expression trees) to a statement which can only appear in the instruction
stream. This
We used to have one big function, match_signature_by_name, which found
a matching signature, performed out-parameter conversions, and generated
the ir_call. As the code for matching against built-in functions became
more complicated, I split it internally, creating generate_call().
However, I lef
When translating a call from AST to HIR, we need to decide whether it
can be evaluated to a constant before emitting any code (namely, the
temporary declaration, assignment, and call.)
Soon, ir_call will become a statement taking a dereference of where to
store the return value, rather than an rva
generate_call() and ast_function_expression::hir() both tried to verify
that 'out' and 'inout' parameters used l-values. Irritatingly, it
turned out that this was not redundant; both checks caught -some- cases.
This patch combines the two into a single "complete" function that does
all the parame
Most of the time, we just want to read an ir_dereference, so there's no
need to have these in separate functions. However, the next patch will
want to read an ir_dereference_variable directly.
Signed-off-by: Kenneth Graunke
---
src/glsl/ir_reader.cpp | 28
1 files
Currently, ir_call can be used as either a statement (for void
functions) or a value (for non-void functions). This is rather awkward,
as it's the only class that can be used in both forms.
A number of places use ir_call::get_error_instruction() to construct a
generic value of error_type. If ir_
Aside from ir_call, our IR is cleanly split into two classes:
- Statements (typeless; used for side effects, control flow)
- Values (deeply nestable, pure, typed expression trees)
Unfortunately, ir_call confused all this:
- For void functions, we placed ir_call directly in the instruction
stream
Previously, set_callee() performed some assertions about the type of the
ir_call; protecting the bare pointer ensured these checks would be run.
However, ir_call no longer has a type, so the getter and setter methods
don't actually do anything useful. Remove them in favor of accessing
callee dire
Variables have types, expression trees have types, but statements don't.
Rather than have a nonsensical field that stays NULL in the base class,
just move it to where it makes sense.
Fix up a few places that lazily used ir_instruction even though they
actually knew the particular subclass.
Signed
On 03/28/2012 10:58 AM, Eric Anholt wrote:
It turns out this field *is* used, and it's the stride between samples
from the buffer. Discovered during TBO debugging.
---
src/mesa/drivers/dri/i965/gen7_wm_surface_state.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
Oh, right. I
https://bugs.freedesktop.org/show_bug.cgi?id=47967
--- Comment #4 from Alexandre Demers 2012-03-28
20:57:26 PDT ---
Confirmed, I understood what you meant (have both -L... and -ldrm exported).
Thanks.
--
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are re
https://bugs.freedesktop.org/show_bug.cgi?id=47873
Alexandre Demers changed:
What|Removed |Added
AssignedTo|mesa-dev@lists.freedesktop. |alexandre.f.dem...@gmail.co
See also this bug report and mail thread:
https://bugs.freedesktop.org/show_bug.cgi?id=36792
http://lists.freedesktop.org/archives/mesa-dev/2011-August/011099.html
Current Ubuntu mesa package also include updated patches.
___
mesa-dev mailing list
mesa-d
Fixes a Coverity resource leak defect.
NOTE: This is a candidate for the 8.0 branch.
Signed-off-by: Vinson Lee
---
src/glsl/link_uniforms.cpp |1 +
1 file changed, 1 insertion(+)
diff --git a/src/glsl/link_uniforms.cpp b/src/glsl/link_uniforms.cpp
index 613c9b7..86717f9 100644
--- a/src/gl
49 matches
Mail list logo