Re: [Mesa-dev] [PATCH 2/2] egl: update headers

2011-12-20 Thread Chia-I Wu
On Tue, Dec 20, 2011 at 5:28 AM, Ian Romanick wrote: > On 12/19/2011 02:05 AM, Chia-I Wu wrote: >> >> From: Chia-I Wu >> >> Update to revision 15052. >> >> EGL_MESA_drm_image is now official.  But apparently we have our own >> extension >> to it and we need this in eglmesaext.h: >> >>   #ifdef EGL

Re: [Mesa-dev] [PATCH 1/2] linker: fix strdup memory leak

2011-12-20 Thread Pekka Paalanen
On Mon, 19 Dec 2011 13:24:20 -0800 Ian Romanick wrote: > On 12/19/2011 05:23 AM, Pekka Paalanen wrote: > > On Fri, 16 Dec 2011 10:46:11 -0800 > > Ian Romanick wrote: > > > >> On 12/14/2011 11:26 PM, Pekka Paalanen wrote: > >>> string_to_uint_map::put() already does a strdup() for the key > >>> a

Re: [Mesa-dev] [PATCH] mesa: fix a leak in _mesa_delete_texture_image()

2011-12-20 Thread Pekka Paalanen
On Fri, 16 Dec 2011 08:42:01 -0700 Brian Paul wrote: > On 12/16/2011 07:17 AM, Pekka Paalanen wrote: > > Valgrind complains about a definitely lost block allocated in > > intelNewTextureImage(). This leak was apparently created by > > 6e0f9001fe3fb191c2928bd09aa9e9d05ddf4ea9, "mesa: move > > gl_t

Re: [Mesa-dev] [PATCH] Fix build with LLVM >= r145623.

2011-12-20 Thread Michel Dänzer
On Mon, 2011-12-19 at 23:11 +0100, Johannes Obermayr wrote: > This is a workaround for https://bugs.freedesktop.org/show_bug.cgi?id=43861. > > Actually the issue which makes -pedantic failing should be solved. Maybe it should, but that's not for LLVM to enforce on its users. > --- > configure

[Mesa-dev] [PATCH] xvmc: Remove unused variable

2011-12-20 Thread Maarten Lankhorst
Signed-off-by: Maarten Lankhorst --- src/gallium/state_trackers/xorg/xvmc/attributes.c |3 --- 1 files changed, 0 insertions(+), 3 deletions(-) diff --git a/src/gallium/state_trackers/xorg/xvmc/attributes.c b/src/gallium/state_trackers/xorg/xvmc/attributes.c index b115d52..d40a7b1 100644

[Mesa-dev] [PATCH] vl: Remove unused declaration

2011-12-20 Thread Maarten Lankhorst
csc is not used for rgba and gives a warning. Signed-off-by: Maarten Lankhorst --- src/gallium/auxiliary/vl/vl_compositor.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/gallium/auxiliary/vl/vl_compositor.c b/src/gallium/auxiliary/vl/vl_compositor.c index 98cb

[Mesa-dev] [PATCH 1/3] vl: Only initialize vlc once

2011-12-20 Thread Maarten Lankhorst
And add more sanity checks to stream. This shouldn't break things beyond those that aren't broken already. Signed-off-by: Maarten Lankhorst --- And yes Andy, I mean that I haven't found a good video yet to fix the playback parts that are still broken.. src/gallium/auxiliary/vl/vl_mpeg12_bits

[Mesa-dev] [PATCH 2/3] vl: Remove decode buffers

2011-12-20 Thread Maarten Lankhorst
It's something for vl_mpeg12_bitstream internally, so treat it as such. Signed-off-by: Maarten Lankhorst --- v1: Split up from previous patch and with performance restored.. src/gallium/auxiliary/vl/vl_decoder.c | 13 src/gallium/auxiliary/vl/vl_decoder.h |

[Mesa-dev] [PATCH 3/3] vl: And remove remaining unnecessary members

2011-12-20 Thread Maarten Lankhorst
Signed-off-by: Maarten Lankhorst --- begin_frame and end_frame are implied for bitstream acceleration, and a frame can be explicitly ended with the flush call, so there's no need for the extra calls. Only reason patch is big is because I unified set_picture_parameters and various calls that sh

Re: [Mesa-dev] [PATCH 1/3] vl: Only initialize vlc once

2011-12-20 Thread Christian König
On 20.12.2011 12:43, Maarten Lankhorst wrote: And add more sanity checks to stream. This shouldn't break things beyond those that aren't broken already. Signed-off-by: Maarten Lankhorst --- And yes Andy, I mean that I haven't found a good video yet to fix the playback parts that are still bro

Re: [Mesa-dev] Willing to take Haiku support Patches? (Was: DEATH to old drivers!)

2011-12-20 Thread Alexander von Gluck
On Mon, 19 Dec 2011 11:44:51 -0700, Brian Paul wrote: On Mon, Dec 19, 2011 at 11:18 AM, Alexander von Gluck wrote: Good afternoon! The Haiku OS project (not-for-profit organization, founded in 2001) has found ourselves in a weird spot, we have a working Mesa software render library based on

[Mesa-dev] [Bug 43879] (xorg-server 1.11.2-2, xf86-video-ati 6.14.3-1 or git, qt 4.7.4) black pixels instead of transparency from PNGs

2011-12-20 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=43879 Michel Dänzer changed: What|Removed |Added Status|NEW |RESOLVED Resolution|

Re: [Mesa-dev] [PATCH 1/3] vl: Only initialize vlc once

2011-12-20 Thread Maarten Lankhorst
Hey Christian, On 12/20/2011 02:16 PM, Christian König wrote: > On 20.12.2011 12:43, Maarten Lankhorst wrote: >> And add more sanity checks to stream. This shouldn't break things beyond >> those that aren't broken already. >> >> Signed-off-by: Maarten Lankhorst >> >> --- >> And yes Andy, I mean t

Re: [Mesa-dev] [PATCH 1/3] vl: Only initialize vlc once

2011-12-20 Thread Lucas Stach
Hi all! Just jumping in with regard to the assert. Am Dienstag, den 20.12.2011, 19:20 +0100 schrieb Maarten Lankhorst: [snip] > > > >> > >> return vlc->buffer>> (64 - num_bits); > >> } > >> @@ -130,7 +132,7 @@ vl_vlc_peekbits(struct vl_vlc *vlc, unsigned num_bits) > >> static INLINE void

[Mesa-dev] [PATCH 00/20] Implement GLX_ARB_create_context and friends

2011-12-20 Thread Ian Romanick
This giant series of patches implements GLX_ARB_create_context, GLX_ARB_create_context_profile, and GLX_EXT_create_context_es2_profile. One of the difficulties with this patch series is that I had to rework some of the Gallium context creation plumbing. In order for the xserver to generate the co

[Mesa-dev] [PATCH 01/20] st-api: Clean-up OpenGL profile handling

2011-12-20 Thread Ian Romanick
From: Ian Romanick There seems to have been two different ways to communicate the profile. There were flags and there were profiles. I've opted to remove the profile flags and use ST_PROFILE_DEFAULT (compatibility profile) and ST_PROFILE_OPENGL_CORE (core profile) consistently instead. Also ch

[Mesa-dev] [PATCH 02/20] st-api: Have context_create explain why creation failed

2011-12-20 Thread Ian Romanick
From: Ian Romanick This won't be used in the client-side libGL, but the xserver has to generate a different protocol error depending on the reason context creation failed. Signed-off-by: Ian Romanick --- src/gallium/include/state_tracker/st_api.h | 14 ++ .../state_tracke

[Mesa-dev] [PATCH 03/20] glx: Add __glX_send_client_info super function

2011-12-20 Thread Ian Romanick
From: Ian Romanick This function picks the correct client-info protocol (based on the server's GLX version and set of extensions) and sends it to the server. Signed-off-by: Ian Romanick --- src/glx/Makefile |1 + src/glx/clientinfo.c | 156 +

[Mesa-dev] [PATCH 04/20] glx: Use __glX_send_client_info with XCB

2011-12-20 Thread Ian Romanick
From: Ian Romanick __glX_send_client_info only supports XCB, so use that instead of __glXClientInfo when USE_XCB is defined. Signed-off-by: Ian Romanick --- src/glx/glxext.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/src/glx/glxext.c b/src/glx/glxext.c index ba

[Mesa-dev] [PATCH 05/20] dri2: Add createContextAttribs entry point for DRI2 version 3

2011-12-20 Thread Ian Romanick
From: Ian Romanick Signed-off-by: Ian Romanick --- include/GL/internal/dri_interface.h | 52 +- 1 files changed, 50 insertions(+), 2 deletions(-) diff --git a/include/GL/internal/dri_interface.h b/include/GL/internal/dri_interface.h index 4f768f0..add03c7 100

[Mesa-dev] [PATCH 06/20] glx: Add glx_screen_vtable::create_context_attribs

2011-12-20 Thread Ian Romanick
From: Ian Romanick Signed-off-by: Ian Romanick --- src/glx/dri2_glx.c |3 ++- src/glx/dri_glx.c |3 ++- src/glx/glxclient.h|8 src/glx/indirect_glx.c |3 ++- 4 files changed, 14 insertions(+), 3 deletions(-) diff --git a/src/glx/dri2_glx.c b/src/glx/dri2_g

[Mesa-dev] [PATCH 07/20] glx: Implement glx_screen_vtable::create_context_attribs for indirect contexts

2011-12-20 Thread Ian Romanick
From: Ian Romanick Signed-off-by: Ian Romanick --- src/glx/indirect_glx.c | 24 +++- 1 files changed, 23 insertions(+), 1 deletions(-) diff --git a/src/glx/indirect_glx.c b/src/glx/indirect_glx.c index b628688..2399375 100644 --- a/src/glx/indirect_glx.c +++ b/src/glx/ind

[Mesa-dev] [PATCH 08/20] glx/dri2: Implement glx_screen_vtable::create_context_attribs for DRI2 contexts

2011-12-20 Thread Ian Romanick
From: Ian Romanick This also enables GLX_ARB_create_context and GLX_ARB_create_context_profile if the driver supports DRI_DRI2 version 3 or greater. Signed-off-by: Ian Romanick --- src/glx/dri2_glx.c | 92 +++- 1 files changed, 91 insertions(+)

[Mesa-dev] [PATCH 09/20] glx: Initial implementation of glXCreateContextAttribsARB

2011-12-20 Thread Ian Romanick
From: Ian Romanick Signed-off-by: Ian Romanick --- src/glx/Makefile |1 + src/glx/create_context.c | 117 ++ src/glx/glxclient.h |2 + src/glx/glxcmds.c|2 +- 4 files changed, 121 insertions(+), 1 deletions(-) create

[Mesa-dev] [PATCH 10/20] glx: Connect glXCreateContextAttribsARB to glXGetProcAddress

2011-12-20 Thread Ian Romanick
From: Ian Romanick Signed-off-by: Ian Romanick --- src/glx/glxcmds.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/src/glx/glxcmds.c b/src/glx/glxcmds.c index f7cbf2f..37c0933 100644 --- a/src/glx/glxcmds.c +++ b/src/glx/glxcmds.c @@ -2603,6 +2603,9 @@ static const

[Mesa-dev] [PATCH 11/20] glx: Add extension strings for GLX_ARB_create_context and GLX_ARB_create_context_profile

2011-12-20 Thread Ian Romanick
From: Ian Romanick Note that these extensions are not automatically enabled for screens capable of direct-rendering. Signed-off-by: Ian Romanick --- src/glx/glxextensions.c |2 ++ src/glx/glxextensions.h |4 +++- 2 files changed, 5 insertions(+), 1 deletions(-) diff --git a/src/glx/gl

[Mesa-dev] [PATCH 12/20] dri_util: Mostly stub implementation of dri2CreateContextAttribs

2011-12-20 Thread Ian Romanick
From: Ian Romanick This adds the function and modifies dri2CreateNewContextForAPI to call it. At this point only version 2 of the DRI2 API is advertised to the loader. Signed-off-by: Ian Romanick --- src/mesa/drivers/dri/common/dri_util.c | 97 +++ 1 files change

[Mesa-dev] [PATCH 13/20] st/mesa: Reject forward-looking contexts

2011-12-20 Thread Ian Romanick
From: Ian Romanick Signed-off-by: Ian Romanick --- src/mesa/state_tracker/st_manager.c |8 ++-- 1 files changed, 6 insertions(+), 2 deletions(-) diff --git a/src/mesa/state_tracker/st_manager.c b/src/mesa/state_tracker/st_manager.c index 828f0d8..1cee312 100644 --- a/src/mesa/state_tr

[Mesa-dev] [PATCH 14/20] glx/dri: Add utility function dri2_convert_glx_attribs

2011-12-20 Thread Ian Romanick
From: Ian Romanick This converts all of the GLX data from glXCreateContextAttribsARB to the values expected by the DRI driver interfaces. Signed-off-by: Ian Romanick --- src/glx/dri_common.c | 102 ++ src/glx/dri_common.h |6 +++ 2 files cha

[Mesa-dev] [PATCH 15/20] dri2: Add createContextAttribs entry point for DRISW version 3

2011-12-20 Thread Ian Romanick
From: Ian Romanick Signed-off-by: Ian Romanick --- include/GL/internal/dri_interface.h | 20 +++- 1 files changed, 19 insertions(+), 1 deletions(-) diff --git a/include/GL/internal/dri_interface.h b/include/GL/internal/dri_interface.h index add03c7..b21445f 100644 --- a/incl

[Mesa-dev] [PATCH 16/20] glx/dri2: Implement glx_screen_vtable::create_context_attribs for DRISW contexts

2011-12-20 Thread Ian Romanick
From: Ian Romanick This also enables GLX_ARB_create_context and GLX_ARB_create_context_profile if the driver supports DRI_DRISW version 3 or greater. Signed-off-by: Ian Romanick --- src/glx/drisw_glx.c | 89 ++- 1 files changed, 88 insertions(+

[Mesa-dev] [PATCH 17/20] dri2: Add plumbing to get context version requirements and flags to drivers

2011-12-20 Thread Ian Romanick
From: Ian Romanick This adds support for DRI_DRI2 version 3 to all of the DRI2 drivers. Signed-off-by: Ian Romanick --- .../state_trackers/dri/common/dri_context.c| 51 - .../state_trackers/dri/common/dri_context.h|4 + src/mesa/drivers/dri/common/dri_util.c

[Mesa-dev] [PATCH 18/20] glx: Enable GLX_EXT_create_context_es2_profile

2011-12-20 Thread Ian Romanick
From: Ian Romanick This extension is only enabled if the underlying driver advertises support for OpenGL ES 2.0. This happens either through the getAPIMask function in version 2 of the DRI2 extension or implicity through version 2 of the DRISW extension. Since there is no OpenGL ES 2.0 protocol

[Mesa-dev] [PATCH 19/20] glx: Don't use 'new' as a function parameter name

2011-12-20 Thread Ian Romanick
From: Ian Romanick Using 'new' as a function parameter name prevents including glxclient.h the unit tests (future patch) that use the Google C++ Testing Framework. Signed-off-by: Ian Romanick --- src/glx/glxclient.h |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/

Re: [Mesa-dev] [PATCH 1/2] mesa: Set the correct ctx->NewState bitfield for rasterizer discard.

2011-12-20 Thread Paul Berry
On 19 December 2011 19:07, Marek Olšák wrote: > On Thu, Dec 15, 2011 at 7:21 PM, Paul Berry > wrote: > > On 15 December 2011 08:02, Eric Anholt wrote: > >> > >> On Thu, 15 Dec 2011 00:00:49 +0100, Marek Olšák > wrote: > >> > On Wed, Dec 14, 2011 at 11:25 PM, Paul Berry > > >> > wrote: > >> >

Re: [Mesa-dev] [PATCH 00/20] Implement GLX_ARB_create_context and friends

2011-12-20 Thread Ian Romanick
On 12/20/2011 12:31 PM, Ian Romanick wrote: This giant series of patches implements GLX_ARB_create_context, GLX_ARB_create_context_profile, and GLX_EXT_create_context_es2_profile. One of the difficulties with this patch series is that I had to rework some of the Gallium context creation plumbing

[Mesa-dev] [PATCH] glsl: Add additionnal type alias for convenience.

2011-12-20 Thread Vincent Lejeune
ivec2, ivec3, bvec2, bvec3 and bvec4 have now a "_type" suffixed alias to identify them easily. These types are currently not widely used inside glsl, however they are refered in UBO spec. It's an opportunity to add them. --- src/glsl/builtin_types.h |5 + src/glsl/glsl_types.h|5 +

Re: [Mesa-dev] [PATCH 01/20] st-api: Clean-up OpenGL profile handling

2011-12-20 Thread Brian Paul
On 12/20/2011 01:31 PM, Ian Romanick wrote: From: Ian Romanick There seems to have been two different ways to communicate the profile. There were flags and there were profiles. I've opted to remove the profile flags and use ST_PROFILE_DEFAULT (compatibility profile) and ST_PROFILE_OPENGL_CORE

Re: [Mesa-dev] [PATCH 02/20] st-api: Have context_create explain why creation failed

2011-12-20 Thread Brian Paul
On 12/20/2011 01:31 PM, Ian Romanick wrote: From: Ian Romanick This won't be used in the client-side libGL, but the xserver has to generate a different protocol error depending on the reason context creation failed. Signed-off-by: Ian Romanick --- src/gallium/include/state_tracker/st_api.h

[Mesa-dev] [PATCH 1/2] mesa: Move RasterDiscard to toplevel of gl_context.

2011-12-20 Thread Paul Berry
Previously we were storing the RasterDiscard flag (for GL_RASTERIZER_DISCARD) in gl_context::TransformFeedback. This was confusing, because we use the _NEW_TRANSFORM flag (not _NEW_TRANSFORM_FEEDBACK) to track state updates to it, and because rasterizer discard has effects even when transform feed

[Mesa-dev] [PATCH 2/2] mesa: Add _NEW_RASTERIZER_DISCARD as synonym for _NEW_TRANSFORM.

2011-12-20 Thread Paul Berry
This makes it easier to keep track of which dirty bits correspond to which pieces of context, since it makes _NEW_RASTERIZER_DISCARD correspond with ctx->RasterDiscard. --- src/mesa/drivers/dri/i965/brw_gs.c |5 +++-- src/mesa/main/enable.c |2 +- src/mesa/mai

Re: [Mesa-dev] vertex array regression

2011-12-20 Thread Brian Paul
On 12/19/2011 01:12 PM, Mathias Fröhlich wrote: Brian, On Monday, December 19, 2011 17:01:07 you wrote: I still don't get what the purpose of the special mapping of the last four/five elements is all about. Can you explain that? As far as I can see the last ones should not map to anything.

[Mesa-dev] [PATCH] vbo: signal _NEW_ARRAY when transitioning between glBegin/End, glDrawArrays

2011-12-20 Thread Brian Paul
This fixes a regression seen with the isosurf demo when switching between glBegin/End and glDrawArrays (do it several times). The problem was the driver wasn't getting _NEW_ARRAY when the arrays were subtly changed: (vertex3f, normal3f) vs. (normal3f, vertex3f). This patch fixes that by signaling

Re: [Mesa-dev] [PATCH 1/2] mesa: Move RasterDiscard to toplevel of gl_context.

2011-12-20 Thread Brian Paul
On 12/20/2011 05:41 PM, Paul Berry wrote: Previously we were storing the RasterDiscard flag (for GL_RASTERIZER_DISCARD) in gl_context::TransformFeedback. This was confusing, because we use the _NEW_TRANSFORM flag (not _NEW_TRANSFORM_FEEDBACK) to track state updates to it, and because rasterizer

[Mesa-dev] [Bug 43896] Mesa assembly breaks Super Meat Boy, Shank

2011-12-20 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=43896 --- Comment #6 from Ryan C. Gordon 2011-12-20 19:25:49 PST --- Brian is correct, this is my bug in MojoShader; that code is goofy, and I'll fix it soon (and push out an updated Super Meat Boy). My apologies for this generating traffic on your

Re: [Mesa-dev] [PATCH 2/2] mesa: Add _NEW_RASTERIZER_DISCARD as synonym for _NEW_TRANSFORM.

2011-12-20 Thread Kenneth Graunke
On 12/20/2011 04:41 PM, Paul Berry wrote: > This makes it easier to keep track of which dirty bits correspond to > which pieces of context, since it makes _NEW_RASTERIZER_DISCARD > correspond with ctx->RasterDiscard. > --- > src/mesa/drivers/dri/i965/brw_gs.c |5 +++-- > src/mesa/main

[Mesa-dev] [PATCH] i965: Don't use BRW_DEPTHFORMAT_D24_UNORM_X8_UINT on Gen4.

2011-12-20 Thread Kenneth Graunke
X8 depth formats weren't supported until Ironlake (Gen 5). Fixes GPU hangs introduced in d84a180417d1eabd680554970f1eaaa93abcd41e. One example test case was "fbo-missing-attachment-blit from". Signed-off-by: Kenneth Graunke --- src/mesa/drivers/dri/i965/brw_misc_state.c |4 +++- 1 files cha