[Mesa-dev] [PATCH] ast_to_hir: Only use the local 'type' variable as a temporary.

2011-04-12 Thread Kenneth Graunke
Lots of code (deleted in this patch) tried to make type == result->type, but not all cases did. Don't pretend; just use result->type. --- src/glsl/ast_to_hir.cpp | 23 --- 1 files changed, 4 insertions(+), 19 deletions(-) Why, so it does! Good catch. Of course, "type" is

[Mesa-dev] [Bug 36139] static build with -fPIC misses some symbols

2011-04-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=36139 --- Comment #1 from Michel Dänzer 2011-04-12 02:53:11 PDT --- You're not passing -fPIC in CXXFLAGS? -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the ass

Re: [Mesa-dev] gdb doesnt step into GL API calls of gears.

2011-04-12 Thread Brian Paul
On 04/11/2011 11:52 PM, kumar vemuri wrote: Hi Brian, I did use --enable-debug with configure. But still i dont see gdb stepping into gl calls... it does step into the glu calls though. This is my configure command: ./configure --enable-debug --enable-gallium-i915 --enable-gallium-swrast

[Mesa-dev] [Bug 36173] New: struct renderbuffer's 'format' field never set when using FBO

2011-04-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=36173 Summary: struct renderbuffer's 'format' field never set when using FBO Product: Mesa Version: git Platform: Other OS/Version: Linux (All) Status: NEW Seve

[Mesa-dev] [Bug 36173] struct renderbuffer's 'format' field never set when using FBO

2011-04-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=36173 --- Comment #1 from pell...@gmail.com 2011-04-12 09:02:03 PDT --- Created an attachment (id=45538) View: https://bugs.freedesktop.org/attachment.cgi?id=45538 Review: https://bugs.freedesktop.org/review?bug=36173&attachment=45538 proposed patch

Re: [Mesa-dev] [PATCH 4/6] glsl: When we've emitted a semantic error for ==, return a bool constant.

2011-04-12 Thread Eric Anholt
On Mon, 11 Apr 2011 15:51:55 -0700, Ian Romanick wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > On 04/09/2011 10:17 PM, Eric Anholt wrote: > > This prevents later errors (including an assertion failure) from > > cascading the failure. > > > > Fixes invalid-equality-04.vert. > > ---

Re: [Mesa-dev] [PATCH] ast_to_hir: Only use the local 'type' variable as a temporary.

2011-04-12 Thread Eric Anholt
On Tue, 12 Apr 2011 00:36:59 -0700, Kenneth Graunke wrote: > Lots of code (deleted in this patch) tried to make type == result->type, > but not all cases did. Don't pretend; just use result->type. > --- > src/glsl/ast_to_hir.cpp | 23 --- > 1 files changed, 4 insertions(+)

[Mesa-dev] [Bug 29789] TALLOC_CFLAGS not used properly

2011-04-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=29789 Eric Anholt changed: What|Removed |Added Status|NEW |RESOLVED Resolution|

[Mesa-dev] [Bug 29620] link errors in glcpp/glcpp

2011-04-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=29620 Eric Anholt changed: What|Removed |Added Status|NEW |RESOLVED Resolution|

[Mesa-dev] [Bug 29789] TALLOC_CFLAGS not used properly

2011-04-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=29789 --- Comment #10 from Eric Anholt 2011-04-12 10:10:59 PDT --- *** Bug 29620 has been marked as a duplicate of this bug. *** -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: -

[Mesa-dev] [Bug 36139] static build with -fPIC misses some symbols

2011-04-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=36139 --- Comment #2 from Burlen 2011-04-12 10:37:51 PDT --- I thought mesa is a c library, and thus CXXFLAGS is not needed. Do I need it? -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail

[Mesa-dev] [Bug 36139] static build with -fPIC misses some symbols

2011-04-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=36139 --- Comment #3 from Michel Dänzer 2011-04-12 10:43:49 PDT --- (In reply to comment #2) > I thought mesa is a c library, and thus CXXFLAGS is not needed. Do I need it? Probably; the new GLSL compiler is implemented in C++. -- Configure bugmail

Re: [Mesa-dev] [PATCH 4/6] glsl: When we've emitted a semantic error for ==, return a bool constant.

2011-04-12 Thread Ian Romanick
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 04/12/2011 09:40 AM, Eric Anholt wrote: > On Mon, 11 Apr 2011 15:51:55 -0700, Ian Romanick wrote: >> -BEGIN PGP SIGNED MESSAGE- >> Hash: SHA1 >> >> On 04/09/2011 10:17 PM, Eric Anholt wrote: >>> This prevents later errors (including an asse

[Mesa-dev] List of OpenGL features/extensions to avoid?

2011-04-12 Thread Török Edwin
Hi, Is there a list of OpenGL features/extensions that Mesa won't implement, and should thus be avoided when developing a new OpenGL application? [*] I know that S3TC has possible patent issues, and Mesa can't support it in the official release. Is there anything else in OpenGL 3.x (or OpenGL 4.x

Re: [Mesa-dev] List of OpenGL features/extensions to avoid?

2011-04-12 Thread Sven Arvidsson
On Tue, 2011-04-12 at 21:19 +0300, Török Edwin wrote: > Hi, > > Is there a list of OpenGL features/extensions that Mesa won't implement, > and should thus be avoided when developing a new OpenGL application? [*] > > I know that S3TC has possible patent issues, and Mesa can't support it > in the o

[Mesa-dev] [PATCH] i965: Convert 3DPRIMITIVE command from struct-style to OUT_BATCH style.

2011-04-12 Thread Kenneth Graunke
--- src/mesa/drivers/dri/i965/brw_defines.h | 11 +++--- src/mesa/drivers/dri/i965/brw_draw.c| 53 ++- src/mesa/drivers/dri/i965/brw_structs.h | 19 --- 3 files changed, 37 insertions(+), 46 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_defi

Re: [Mesa-dev] List of OpenGL features/extensions to avoid?

2011-04-12 Thread Eric Anholt
On Tue, 12 Apr 2011 21:19:46 +0300, Török Edwin wrote: > Hi, > > Is there a list of OpenGL features/extensions that Mesa won't implement, > and should thus be avoided when developing a new OpenGL application? [*] > > I know that S3TC has possible patent issues, and Mesa can't support it > in the

Re: [Mesa-dev] List of OpenGL features/extensions to avoid?

2011-04-12 Thread Török Edwin
On 2011-04-12 22:51, Eric Anholt wrote: > On Tue, 12 Apr 2011 21:19:46 +0300, Török Edwin wrote: >> Hi, >> >> Is there a list of OpenGL features/extensions that Mesa won't implement, >> and should thus be avoided when developing a new OpenGL application? [*] >> >> I know that S3TC has possible pat

[Mesa-dev] [Bug 29646] baddrawable when resizing a window in gnome-shell/mutter

2011-04-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=29646 Karl Tomlinson changed: What|Removed |Added CC||bugs.freedesk...@karlt.net -- Configur

[Mesa-dev] [PATCH 1/4] i965: Remove unnecessary release/reference of brw_context.state.depth_region

2011-04-12 Thread chad
From: Chad Versace Release the old depth region and reference the new one *only* if it has changed. Signed-off-by: Chad Versace --- src/mesa/drivers/dri/i965/brw_vtbl.c | 10 -- 1 files changed, 4 insertions(+), 6 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_vtbl.c b/src

[Mesa-dev] [PATCH 2/4] i965: Document brw_context.state.depth_region

2011-04-12 Thread chad
From: Chad Versace Signed-off-by: Chad Versace --- src/mesa/drivers/dri/i965/brw_context.h| 21 - src/mesa/drivers/dri/i965/brw_misc_state.c |3 +++ 2 files changed, 23 insertions(+), 1 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_context.h b/src/mesa/

[Mesa-dev] [PATCH 3/4] i965: Define BRW_DEPTHFORMAT_D24_UNORM_X8_UINT

2011-04-12 Thread chad
From: Chad Versace This depth format was added in Gen5. Signed-off-by: Chad Versace --- src/mesa/drivers/dri/i965/brw_defines.h |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_defines.h b/src/mesa/drivers/dri/i965/brw_defines.h index 6c61

[Mesa-dev] [PATCH 4/4] i965: Change assertion condition from implicit to explicit

2011-04-12 Thread chad
From: Chad Versace ... because grokking explicit assertions requires fewer neurons. In brw_misc_state.c:emit_depthbuffer, change assert(tiling != I915_TILING_X && tiling != I915_TILING_NONE) to assert(tiling == I915_TILING_Y) Signed-off-by: Chad Versace --- src/mesa/drivers/dri/i965/b

[Mesa-dev] [PATCH] i965: Allocate the whole URB to the VS and fix calculations for Gen6.

2011-04-12 Thread Kenneth Graunke
Since we never enable the GS on Sandybridge, there's no need to allocate it any URB space. Furthermore, the previous calculation was incorrect: it neglected to multiply by nr_vs_entries, instead comparing whether twice the size of a single VS URB entry was bigger than the entire URB space. It als

Re: [Mesa-dev] [PATCH 4/4] i965: Change assertion condition from implicit to explicit

2011-04-12 Thread Kenneth Graunke
On 04/12/2011 03:33 PM, c...@chad-versace.us wrote: From: Chad Versace ... because grokking explicit assertions requires fewer neurons. In brw_misc_state.c:emit_depthbuffer, change assert(tiling != I915_TILING_X&& tiling != I915_TILING_NONE) to assert(tiling == I915_TILING_Y) Signed

Re: [Mesa-dev] [PATCH 3/4] i965: Define BRW_DEPTHFORMAT_D24_UNORM_X8_UINT

2011-04-12 Thread Kenneth Graunke
On 04/12/2011 03:33 PM, c...@chad-versace.us wrote: From: Chad Versace This depth format was added in Gen5. Signed-off-by: Chad Versace --- src/mesa/drivers/dri/i965/brw_defines.h |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_defines.h

Re: [Mesa-dev] [PATCH 2/4] i965: Document brw_context.state.depth_region

2011-04-12 Thread Kenneth Graunke
On 04/12/2011 03:33 PM, c...@chad-versace.us wrote: From: Chad Versace Signed-off-by: Chad Versace Glad to see these comments! This should help prevent people (like myself) from rabbit-trailing and thinking this is the original pointer. I'll trust your analysis of the situation. Acked-by:

Re: [Mesa-dev] [PATCH 4/4] i965: Change assertion condition from implicit to explicit

2011-04-12 Thread Ian Romanick
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 04/12/2011 03:33 PM, c...@chad-versace.us wrote: > From: Chad Versace > > ... because grokking explicit assertions requires fewer neurons. > > In brw_misc_state.c:emit_depthbuffer, change > assert(tiling != I915_TILING_X && tiling != I915_TIL

Re: [Mesa-dev] [PATCH 1/4] i965: Remove unnecessary release/reference of brw_context.state.depth_region

2011-04-12 Thread Kenneth Graunke
On 04/12/2011 03:33 PM, c...@chad-versace.us wrote: From: Chad Versace Release the old depth region and reference the new one *only* if it has changed. Signed-off-by: Chad Versace --- src/mesa/drivers/dri/i965/brw_vtbl.c | 10 -- 1 files changed, 4 insertions(+), 6 deletions(-) di

Re: [Mesa-dev] [PATCH 3/4] i965: Define BRW_DEPTHFORMAT_D24_UNORM_X8_UINT

2011-04-12 Thread Chad Versace
On 04/12/2011 03:50 PM, Kenneth Graunke wrote: > It would be nice to have a /* GEN5 */ or /* ILK */ comment here, similar > to other #defines. > > Either way, > Reviewed-by: Kenneth Graunke > ___ I'll add the /* GEN5 */ comment. That may lessen some fu

[Mesa-dev] [Bug 36182] Game Trine from http://www.humblebundle.com/ needs ATI_draw_buffers

2011-04-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=36182 Marek Olšák changed: What|Removed |Added Summary|Game Trine from |Game Trine from |http://

[Mesa-dev] [Bug 36139] static build with -fPIC misses some symbols

2011-04-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=36139 --- Comment #4 from Burlen 2011-04-12 17:12:31 PDT --- OK, lets close the bug until I have a chance to investigate further. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because:

[Mesa-dev] [Bug 36139] static build with -fPIC misses some symbols

2011-04-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=36139 Burlen changed: What|Removed |Added Status|NEW |RESOLVED Resolution|

Re: [Mesa-dev] [PATCH 4/4] i965: Change assertion condition from implicit to explicit

2011-04-12 Thread Chad Versace
On 04/12/2011 03:52 PM, Ian Romanick wrote: > On 04/12/2011 03:33 PM, c...@chad-versace.us wrote: >> From: Chad Versace > >> ... because grokking explicit assertions requires fewer neurons. > >> In brw_misc_state.c:emit_depthbuffer, change >> assert(tiling != I915_TILING_X && tiling != I915_

[Mesa-dev] [Bug 36182] Game Trine from http://www.humblebundle.com/ needs ATI_draw_buffers

2011-04-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=36182 Jeff Epler changed: What|Removed |Added CC||jep...@unpythonic.net --- Comment #5 from J

[Mesa-dev] [Bug 34321] The ARB_fragment_program subset of ARB_draw_buffers not implemented

2011-04-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=34321 Jeff Epler changed: What|Removed |Added CC||jep...@unpythonic.net -- Configure bugmail

[Mesa-dev] [Bug 36182] Game Trine from http://www.humblebundle.com/ needs ATI_draw_buffers

2011-04-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=36182 --- Comment #6 from imamdxl8...@gmail.com 2011-04-12 18:36:29 PDT --- Similar error with Trine from Humble Bundle. It needs Shader Model 3 then exists. System: Ubuntu 10.10 Linux 2.6.36.4 Mesa 7.10.2 Intel GMA 4500 256MB Thanks -- Configure b

[Mesa-dev] [Bug 36182] Game Trine from http://www.humblebundle.com/ needs ATI_draw_buffers

2011-04-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=36182 --- Comment #7 from Marek Olšák 2011-04-12 18:40:56 PDT --- (In reply to comment #6) > Similar error with Trine from Humble Bundle. > It needs Shader Model 3 then exists. No, it doesn't. First, there is no Shader Model 3 in OpenGL per se. Second

[Mesa-dev] [Bug 34321] The ARB_fragment_program subset of ARB_draw_buffers not implemented

2011-04-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=34321 ojab changed: What|Removed |Added CC||o...@ojab.ru -- Configure bugmail: https://bugs.