Re: [Mesa-dev] R600 Patchset: Emit true ISA

2013-05-06 Thread Vincent Lejeune
Reviewed-by:Vincent Lejeune - Mail original - > De : Tom Stellard > À : Vincent Lejeune > Cc : "llvm-comm...@cs.uiuc.edu" ; > "mesa-dev@lists.freedesktop.org" > Envoyé le : Lundi 6 mai 2013 17h02 > Objet : Re: R600 Patchset: Emit true ISA > > On Sat, May 04, 2013 at 09:09:25AM -0700,

Re: [Mesa-dev] R600 Patchset: Emit true ISA

2013-05-06 Thread Tom Stellard
On Sat, May 04, 2013 at 09:09:25AM -0700, Vincent Lejeune wrote: > Hi, > > Thank for doing this. > Patches 1 2 and 3 have my rb. > For patch 4: > Hi Vincent, Attached is an updated version of patch 4. -Tom > >@@ -125,9 +106,7 @@ MCCodeEmitter *llvm::createR600MCCodeEmitter(const > >MCInstrIn

Re: [Mesa-dev] R600 Patchset: Emit true ISA

2013-05-04 Thread Aaron Watry
This series, and the associated mesa changes are all: Tested-By: Aaron Watry --Aaron On Fri, May 3, 2013 at 5:53 PM, Tom Stellard wrote: > Hi, > > The attached patches modify the CodeEmitter to emit true ISA. > Previously, we were prefixing all instructions with an instruction type > byte. > >

Re: [Mesa-dev] R600 Patchset: Emit true ISA

2013-05-04 Thread Vincent Lejeune
Hi, Thank for doing this. Patches 1 2 and 3 have my rb. For patch 4: >@@ -125,9 +106,7 @@ MCCodeEmitter *llvm::createR600MCCodeEmitter(const >MCInstrInfo &MCII, > > void R600MCCodeEmitter::EncodeInstruction(const MCInst &MI, raw_ostream &OS, >SmallVectorI