Re: [Mesa-dev] [PATCH v5 56/70] mesa: Add queries for GL_SHADER_STORAGE_BUFFER

2015-09-15 Thread Samuel Iglesias Gonsálvez
On 15/09/15 12:20, Tapani Pälli wrote: > As what Ilia said .. please move the extension checks first and then > check for the value. There is no reason to repeat mistakes done in the > past, also there are already getters with correct behavior with > image_load_store and shader_atomic_counters in

Re: [Mesa-dev] [PATCH v5 56/70] mesa: Add queries for GL_SHADER_STORAGE_BUFFER

2015-09-15 Thread Tapani Pälli
As what Ilia said .. please move the extension checks first and then check for the value. There is no reason to repeat mistakes done in the past, also there are already getters with correct behavior with image_load_store and shader_atomic_counters in this same function. Otherwise looks good to