Re: [Mesa-dev] [PATCH v2] st/dri: add 32-bit RGBX/RGBA formats

2017-07-31 Thread Chih-Wei Huang
2017-08-01 0:18 GMT+08:00 Rob Herring : > On Fri, Jul 28, 2017 at 6:06 AM, Chih-Wei Huang > wrote: >> Hi Rob, >> I'm testing this patch on an AMD radeon chip (PALM) now. >> I use our legacy drm_gralloc since the radeon driver >> doesn't support atomic api required by drm_hwcomposer. >> >> On Surf

Re: [Mesa-dev] [PATCH v2] st/dri: add 32-bit RGBX/RGBA formats

2017-07-31 Thread Rob Herring
On Fri, Jul 28, 2017 at 6:06 AM, Chih-Wei Huang wrote: > Hi Rob, > I'm testing this patch on an AMD radeon chip (PALM) now. > I use our legacy drm_gralloc since the radeon driver > doesn't support atomic api required by drm_hwcomposer. > > On SurfaceFlinger started, the screen just messed up. In

Re: [Mesa-dev] [PATCH v2] st/dri: add 32-bit RGBX/RGBA formats

2017-07-31 Thread Rob Herring
On Sun, Jul 30, 2017 at 10:48 AM, Chih-Wei Huang wrote: > Hi Rob, > Sorry to bother you again. > This patch also breaks the srwast/llvmpipe on Android > since the red and blue are just swapped. My guess is because in this case you use the framebuffer (/dev/fb0) and the format is fixed. The same p

Re: [Mesa-dev] [PATCH v2] st/dri: add 32-bit RGBX/RGBA formats

2017-07-31 Thread Rob Herring
On Fri, Jul 28, 2017 at 1:25 AM, Chih-Wei Huang wrote: > 2017-07-26 23:34 GMT+08:00 Rob Herring : >> On Tue, Jul 25, 2017 at 10:16 PM, Chih-Wei Huang >> wrote: >>> 2017-07-26 1:24 GMT+08:00 Rob Herring : I double checked and I get 8-8-8-8. I'm have HWC2 enabled and SurfaceFlinger i

Re: [Mesa-dev] [PATCH v2] st/dri: add 32-bit RGBX/RGBA formats

2017-07-30 Thread Marek Olšák
On Sun, Jul 30, 2017 at 5:49 PM, Chih-Wei Huang wrote: > 2017-07-28 22:59 GMT+08:00 Marek Olšák : > > Hi, > > > > I've sent a request to revert this commit in 17.2. I'll keep it in > > master, but I'll add a fix not to expose the new formats for GLX. > > I thought it doesn't break GLX according t

Re: [Mesa-dev] [PATCH v2] st/dri: add 32-bit RGBX/RGBA formats

2017-07-30 Thread Chih-Wei Huang
Hi Rob, Sorry to bother you again. This patch also breaks the srwast/llvmpipe on Android since the red and blue are just swapped. I guess nouveau has the same issue but I'm waiting Mauro's confirmation. Any comment? -- Chih-Wei Android-x86 project http://www.android-x86.org _

Re: [Mesa-dev] [PATCH v2] st/dri: add 32-bit RGBX/RGBA formats

2017-07-30 Thread Chih-Wei Huang
2017-07-28 22:59 GMT+08:00 Marek Olšák : > Hi, > > I've sent a request to revert this commit in 17.2. I'll keep it in > master, but I'll add a fix not to expose the new formats for GLX. I thought it doesn't break GLX according to the commit message (investigation by Chad Versace). Isn't it correct

Re: [Mesa-dev] [PATCH v2] st/dri: add 32-bit RGBX/RGBA formats

2017-07-28 Thread Marek Olšák
Hi, I've sent a request to revert this commit in 17.2. I'll keep it in master, but I'll add a fix not to expose the new formats for GLX. Marek On Tue, Jul 11, 2017 at 10:34 PM, Rob Herring wrote: > From: Marek Olšák > > Add support for 32-bit RGBX/RGBA formats which are required for Android. >

Re: [Mesa-dev] [PATCH v2] st/dri: add 32-bit RGBX/RGBA formats

2017-07-28 Thread Chih-Wei Huang
Hi Rob, I'm testing this patch on an AMD radeon chip (PALM) now. I use our legacy drm_gralloc since the radeon driver doesn't support atomic api required by drm_hwcomposer. On SurfaceFlinger started, the screen just messed up. If reverting this patch, it becomes normal as before. Does the radeon

Re: [Mesa-dev] [PATCH v2] st/dri: add 32-bit RGBX/RGBA formats

2017-07-27 Thread Chih-Wei Huang
2017-07-26 23:34 GMT+08:00 Rob Herring : > On Tue, Jul 25, 2017 at 10:16 PM, Chih-Wei Huang > wrote: >> 2017-07-26 1:24 GMT+08:00 Rob Herring : >>> >>> I double checked and I get 8-8-8-8. I'm have HWC2 enabled and >>> SurfaceFlinger is unpatched master branch. >> >> Hmm, strange. >> Which hwcompos

Re: [Mesa-dev] [PATCH v2] st/dri: add 32-bit RGBX/RGBA formats

2017-07-26 Thread Rob Herring
On Tue, Jul 25, 2017 at 10:16 PM, Chih-Wei Huang wrote: > 2017-07-26 1:24 GMT+08:00 Rob Herring : >> On Tue, Jul 25, 2017 at 10:15 AM, Emil Velikov >> wrote: >>> On 25 July 2017 at 03:46, Chih-Wei Huang wrote: On Tue 11 Jul 2017, Rob Herring wrote: >> From: Marek Olšák >> >> A

Re: [Mesa-dev] [PATCH v2] st/dri: add 32-bit RGBX/RGBA formats

2017-07-25 Thread Chih-Wei Huang
2017-07-26 1:24 GMT+08:00 Rob Herring : > On Tue, Jul 25, 2017 at 10:15 AM, Emil Velikov > wrote: >> On 25 July 2017 at 03:46, Chih-Wei Huang wrote: >>> On Tue 11 Jul 2017, Rob Herring wrote: > From: Marek Olšák > > Add support for 32-bit RGBX/RGBA formats which are required for And

Re: [Mesa-dev] [PATCH v2] st/dri: add 32-bit RGBX/RGBA formats

2017-07-25 Thread Rob Herring
On Tue, Jul 25, 2017 at 10:15 AM, Emil Velikov wrote: > On 25 July 2017 at 03:46, Chih-Wei Huang wrote: >> On Tue 11 Jul 2017, Rob Herring wrote: From: Marek Olšák Add support for 32-bit RGBX/RGBA formats which are required for Android. The original patch (commit ccdcf91

Re: [Mesa-dev] [PATCH v2] st/dri: add 32-bit RGBX/RGBA formats

2017-07-25 Thread Emil Velikov
On 25 July 2017 at 03:46, Chih-Wei Huang wrote: > On Tue 11 Jul 2017, Rob Herring wrote: >>> From: Marek Olšák >>> >>> Add support for 32-bit RGBX/RGBA formats which are required for Android. >>> >>> The original patch (commit ccdcf91104a5) was reverted (commit >>> c0c6ca40a25e) in mesa as it bro

Re: [Mesa-dev] [PATCH v2] st/dri: add 32-bit RGBX/RGBA formats

2017-07-25 Thread Rob Herring
On Mon, Jul 24, 2017 at 9:46 PM, Chih-Wei Huang wrote: > On Tue 11 Jul 2017, Rob Herring wrote: >>> From: Marek Olšák >>> >>> Add support for 32-bit RGBX/RGBA formats which are required for Android. >>> >>> The original patch (commit ccdcf91104a5) was reverted (commit >>> c0c6ca40a25e) in mesa as

Re: [Mesa-dev] [PATCH v2] st/dri: add 32-bit RGBX/RGBA formats

2017-07-24 Thread Chih-Wei Huang
On Tue 11 Jul 2017, Rob Herring wrote: >> From: Marek Olšák >> >> Add support for 32-bit RGBX/RGBA formats which are required for Android. >> >> The original patch (commit ccdcf91104a5) was reverted (commit >> c0c6ca40a25e) in mesa as it broke GLX resulting in swapped colors. Based >> on further i

Re: [Mesa-dev] [PATCH v2] st/dri: add 32-bit RGBX/RGBA formats

2017-07-12 Thread Chad Versace
On Tue 11 Jul 2017, Rob Herring wrote: > From: Marek Olšák > > Add support for 32-bit RGBX/RGBA formats which are required for Android. > > The original patch (commit ccdcf91104a5) was reverted (commit > c0c6ca40a25e) in mesa as it broke GLX resulting in swapped colors. Based > on further invest

Re: [Mesa-dev] [PATCH v2] st/dri: add 32-bit RGBX/RGBA formats

2016-04-20 Thread Eric Anholt
Rob Herring writes: > Add support for 32-bit RGBX/RGBA formats which are preferred for Android. > > Signed-off-by: Rob Herring > --- > v2: > - Rebase to current master after introduction of new > dri2_format_to_pipe_format function. Still gets my r-b. signature.asc Description: PGP signatu