On Thu, 30 Nov 2017 12:16:06 +
Eric Engestrom wrote:
> Commit f0ba7d897d1c22202531a added this code to expose asserts to the
> compiler in an attempt to hide 'unused variable' warnings, incorrectly
> claiming it was a no-op. This has two bad effects:
> - any assert with side-effects are execu
On 2017-11-30 01:16 PM, Eric Engestrom wrote:
> Commit f0ba7d897d1c22202531a added this code to expose asserts to the
> compiler in an attempt to hide 'unused variable' warnings, incorrectly
> claiming it was a no-op. This has two bad effects:
> - any assert with side-effects are executed when they
There was actually some ping-pong about this issue:
d885c9dad (Keith Whitwell) introduced it,
7a2271c65 (José Fonseca) removed it , and
f0ba7d897 (Keith Whitwell) introduced it again.
Given this I would give some preference to not to forward standard
assert instead, but don't really see it a
On Thursday, 2017-11-30 12:16:06 +, Eric Engestrom wrote:
> Commit f0ba7d897d1c22202531a added this code to expose asserts to the
> compiler in an attempt to hide 'unused variable' warnings, incorrectly
> claiming it was a no-op. This has two bad effects:
> - any assert with side-effects are ex
