Re: [Mesa-dev] [PATCH V2] glsl: remove unnecessary check

2014-07-19 Thread Ian Romanick
On 07/19/2014 03:24 AM, Timothy Arceri wrote: > On Sat, 2014-07-19 at 14:20 +1000, Timothy Arceri wrote: >> On Sat, 2014-07-19 at 12:25 +1000, Timothy Arceri wrote: >>> This code does nothing useful as the next recursive call on the array >>> element >>> will override any null values if the elemen

Re: [Mesa-dev] [PATCH V2] glsl: remove unnecessary check

2014-07-19 Thread Timothy Arceri
On Sat, 2014-07-19 at 14:20 +1000, Timothy Arceri wrote: > On Sat, 2014-07-19 at 12:25 +1000, Timothy Arceri wrote: > > This code does nothing useful as the next recursive call on the array > > element > > will override any null values if the element is a record anyway. The code is > > also not do

Re: [Mesa-dev] [PATCH V2] glsl: remove unnecessary check

2014-07-18 Thread Timothy Arceri
On Sat, 2014-07-19 at 12:25 +1000, Timothy Arceri wrote: > This code does nothing useful as the next recursive call on the array element > will override any null values if the element is a record anyway. The code is > also not doing what the comment says as its trying to set the record type > point