Re: [Mesa-dev] [PATCH 3/5] i965/vs: Add src_reg::negative_equals method

2015-04-09 Thread Ian Romanick
On 04/09/2015 09:31 AM, Matt Turner wrote: > On Wed, Apr 8, 2015 at 4:38 PM, Ian Romanick wrote: >> From: Ian Romanick >> >> This method is similar to the existing ::equals method. Instead of >> testing that two src_regs are equal to each other, it tests that one is >> the negation of the other.

Re: [Mesa-dev] [PATCH 3/5] i965/vs: Add src_reg::negative_equals method

2015-04-09 Thread Matt Turner
On Thu, Apr 9, 2015 at 9:31 AM, Matt Turner wrote: > I think the function does what it advertises. I just don't think that > happens to be the thing you really want. See next patch's reply. Oh, never mind. I missed the non-immediate case. Even still, I guess I expected your more general case to

Re: [Mesa-dev] [PATCH 3/5] i965/vs: Add src_reg::negative_equals method

2015-04-09 Thread Matt Turner
On Wed, Apr 8, 2015 at 4:38 PM, Ian Romanick wrote: > From: Ian Romanick > > This method is similar to the existing ::equals method. Instead of > testing that two src_regs are equal to each other, it tests that one is > the negation of the other. > > Signed-off-by: Ian Romanick > --- > src/mes