Re: [Mesa-dev] [PATCH 2/4] nir: fix typo for f2b description

2015-04-01 Thread Matt Turner
On Wed, Apr 1, 2015 at 4:26 PM, Ilia Mirkin wrote: > On Wed, Apr 1, 2015 at 7:14 PM, Connor Abbott wrote: >> On Wed, Apr 1, 2015 at 6:49 PM, Jason Ekstrand wrote: >>> On Tue, Mar 31, 2015 at 4:10 PM, Ilia Mirkin wrote: On Tue, Mar 31, 2015 at 6:57 PM, Rob Clark wrote: > From: Rob Clar

Re: [Mesa-dev] [PATCH 2/4] nir: fix typo for f2b description

2015-04-01 Thread Jason Ekstrand
On Wed, Apr 1, 2015 at 4:26 PM, Ilia Mirkin wrote: > On Wed, Apr 1, 2015 at 7:14 PM, Connor Abbott wrote: >> On Wed, Apr 1, 2015 at 6:49 PM, Jason Ekstrand wrote: >>> On Tue, Mar 31, 2015 at 4:10 PM, Ilia Mirkin wrote: On Tue, Mar 31, 2015 at 6:57 PM, Rob Clark wrote: > From: Rob Clar

Re: [Mesa-dev] [PATCH 2/4] nir: fix typo for f2b description

2015-04-01 Thread Ilia Mirkin
On Wed, Apr 1, 2015 at 7:14 PM, Connor Abbott wrote: > On Wed, Apr 1, 2015 at 6:49 PM, Jason Ekstrand wrote: >> On Tue, Mar 31, 2015 at 4:10 PM, Ilia Mirkin wrote: >>> On Tue, Mar 31, 2015 at 6:57 PM, Rob Clark wrote: From: Rob Clark Signed-off-by: Rob Clark --- src/

Re: [Mesa-dev] [PATCH 2/4] nir: fix typo for f2b description

2015-04-01 Thread Connor Abbott
On Wed, Apr 1, 2015 at 6:49 PM, Jason Ekstrand wrote: > On Tue, Mar 31, 2015 at 4:10 PM, Ilia Mirkin wrote: >> On Tue, Mar 31, 2015 at 6:57 PM, Rob Clark wrote: >>> From: Rob Clark >>> >>> Signed-off-by: Rob Clark >>> --- >>> src/glsl/nir/nir_opcodes.py | 4 ++-- >>> 1 file changed, 2 inserti

Re: [Mesa-dev] [PATCH 2/4] nir: fix typo for f2b description

2015-04-01 Thread Jason Ekstrand
On Tue, Mar 31, 2015 at 4:10 PM, Ilia Mirkin wrote: > On Tue, Mar 31, 2015 at 6:57 PM, Rob Clark wrote: >> From: Rob Clark >> >> Signed-off-by: Rob Clark >> --- >> src/glsl/nir/nir_opcodes.py | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/src/glsl/nir/nir_opcod

Re: [Mesa-dev] [PATCH 2/4] nir: fix typo for f2b description

2015-03-31 Thread Matt Turner
On Tue, Mar 31, 2015 at 4:06 PM, Matt Turner wrote: > On Tue, Mar 31, 2015 at 3:57 PM, Rob Clark wrote: >> From: Rob Clark >> >> Signed-off-by: Rob Clark >> --- > > It's not just a description -- it's the expression used for constant > evaluation. Presumably the mistake hasn't caused problems b

Re: [Mesa-dev] [PATCH 2/4] nir: fix typo for f2b description

2015-03-31 Thread Ilia Mirkin
On Tue, Mar 31, 2015 at 6:57 PM, Rob Clark wrote: > From: Rob Clark > > Signed-off-by: Rob Clark > --- > src/glsl/nir/nir_opcodes.py | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/src/glsl/nir/nir_opcodes.py b/src/glsl/nir/nir_opcodes.py > index 062cd62..b92fc7e 10

Re: [Mesa-dev] [PATCH 2/4] nir: fix typo for f2b description

2015-03-31 Thread Matt Turner
On Tue, Mar 31, 2015 at 3:57 PM, Rob Clark wrote: > From: Rob Clark > > Signed-off-by: Rob Clark > --- It's not just a description -- it's the expression used for constant evaluation. Presumably the mistake hasn't caused problems because optimizations in GLSL IR evaluated any f2b and i2b of a c