Re: [Mesa-dev] [PATCH 11/41] intel: Kill intel_mipmap_level::nr_images [v2]

2011-11-18 Thread Chad Versace
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 11/18/2011 03:55 PM, Kenneth Graunke wrote: > On 11/18/2011 01:52 PM, Chad Versace wrote: > [snip] >> @@ -335,23 +338,18 @@ intel_miptree_get_image_offset(struct >> intel_mipmap_tree *mt, >> GLuint level, GLuint face, GL

Re: [Mesa-dev] [PATCH 11/41] intel: Kill intel_mipmap_level::nr_images [v2]

2011-11-18 Thread Eric Anholt
On Fri, 18 Nov 2011 13:52:32 -0800, a...@anholt.net wrote: > From: Chad Versace > > For all texture targets except GL_TEXTURE_CUBE_MAP, the 'nr_images' and > 'depth' fields of intel_mipmap_level were identical. In the exceptional > case, nr_images == 6 and depth == 1. > > It is simple to determ

Re: [Mesa-dev] [PATCH 11/41] intel: Kill intel_mipmap_level::nr_images

2011-11-18 Thread Eric Anholt
On Fri, 18 Nov 2011 13:36:25 -0800, Chad Versace wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > On 11/18/2011 12:22 PM, Eric Anholt wrote: > > On Thu, 17 Nov 2011 19:58:38 -0800, Chad Versace > > wrote: > >>- For GL_TEXTURE_3D, it is the texture's depth at each miplevel. It's

Re: [Mesa-dev] [PATCH 11/41] intel: Kill intel_mipmap_level::nr_images [v2]

2011-11-18 Thread Kenneth Graunke
On 11/18/2011 01:52 PM, Chad Versace wrote: [snip] > @@ -335,23 +338,18 @@ intel_miptree_get_image_offset(struct intel_mipmap_tree > *mt, > GLuint level, GLuint face, GLuint depth, > GLuint *x, GLuint *y) > { > - switch (mt->target) { >

Re: [Mesa-dev] [PATCH 11/41] intel: Kill intel_mipmap_level::nr_images

2011-11-18 Thread Chad Versace
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 11/18/2011 12:22 PM, Eric Anholt wrote: > On Thu, 17 Nov 2011 19:58:38 -0800, Chad Versace > wrote: >>- For GL_TEXTURE_3D, it is the texture's depth at each miplevel. It's >> value, like width and height, varies with miplevel. > > "Its"

Re: [Mesa-dev] [PATCH 11/41] intel: Kill intel_mipmap_level::nr_images

2011-11-18 Thread Eric Anholt
On Thu, 17 Nov 2011 19:58:38 -0800, Chad Versace wrote: > For all texture targets except GL_TEXTURE_CUBE_MAP, the 'nr_images' and > 'depth' fields of intel_mipmap_level were identical. In the exceptional > case, nr_images == 6 and depth == 1. > > It is simple to determine if a texture is a cube