Re: [Mesa-dev] [PATCH 1/6] i965/fs: Optimize OR with 0 into a MOV

2018-06-15 Thread Ian Romanick
On 06/15/2018 02:27 AM, Iago Toral wrote: > On Thu, 2018-06-14 at 17:43 -0700, Ian Romanick wrote: >> From: Ian Romanick >> >> fs_visitor::set_gs_stream_control_data_bits generates some code like >> "control_data_bits | stream_id << ((2 * (vertex_count - 1)) % 32)" as >> part of EmitVertex. The f

Re: [Mesa-dev] [PATCH 1/6] i965/fs: Optimize OR with 0 into a MOV

2018-06-15 Thread Iago Toral
I dropped a suggestion in patch 1 that also applies to patch 3, feel free to take it or not, and then I pointed out a small issue in patch 6 that I think should be addressed that I think should be fixed. Otherwise, the series is: Reviewed-by: Iago Toral Quiroga On Thu, 2018-06-14 at 17:43 -0700,

Re: [Mesa-dev] [PATCH 1/6] i965/fs: Optimize OR with 0 into a MOV

2018-06-15 Thread Iago Toral
On Thu, 2018-06-14 at 17:43 -0700, Ian Romanick wrote: > From: Ian Romanick > > fs_visitor::set_gs_stream_control_data_bits generates some code like > "control_data_bits | stream_id << ((2 * (vertex_count - 1)) % 32)" as > part of EmitVertex. The first time this (dynamically) occurs in the > sha