subject:"Re\: \[Mesa\-dev\] \[PATCH 1\/3\] ra\: Use bool instead of GLboolean."

Re: [Mesa-dev] [PATCH 1/3] ra: Use bool instead of GLboolean.

2014-03-17 Thread Matt Turner

Series is Reviewed-by: Matt Turner ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 1/3] ra: Use bool instead of GLboolean.

2014-03-17 Thread Eric Anholt

Kenneth Graunke writes: > This isn't the GL API, so there's no reason to use GLboolean. > > Using bool is safer: any non-zero value is treated as "true". When > converting a value to a GLboolean, all but the low byte is discarded, > which means that values like 256 will be incorrectly rendered a