Re: [Mesa-dev] [PATCH 1/2] clover: Call end_query before getting timestamp result v2

2014-07-17 Thread Francisco Jerez
Tom Stellard writes: > v2: > - Move the end_query() call into the timestamp constructor. > - Still pass false as the wait parameter to get_query_result(). Reviewed-by: Francisco Jerez > --- > src/gallium/state_trackers/clover/core/timestamp.cpp | 1 + > 1 file changed, 1 insertion(+) > >

Re: [Mesa-dev] [PATCH 1/2] clover: Call end_query before getting timestamp result v2

2014-07-16 Thread Niels Ole Salscheider
Reviewed-by: Niels Ole Salscheider On Wednesday 16 July 2014, 17:37:48, Tom Stellard wrote: > v2: > - Move the end_query() call into the timestamp constructor. > - Still pass false as the wait parameter to get_query_result(). > --- > src/gallium/state_trackers/clover/core/timestamp.cpp | 1 +

Re: [Mesa-dev] [PATCH 1/2] clover: Call end_query before getting timestamp result

2014-07-16 Thread Niels Ole Salscheider
On Wednesday 16 July 2014, 16:49:08, Tom Stellard wrote: > Also change the wait parameter from false to true. > --- > > I'm really not sure what is correct here, but this patch fixes event > profiling on SI. I think you should call end_query in the constructor right after the call to create_quer