Re: [Mesa-dev] [PATCH 09/21] nir: Add a phi node placement helper

2016-03-21 Thread Connor Abbott
On Mon, Mar 21, 2016 at 7:37 PM, Jason Ekstrand wrote: > > > On Mon, Mar 21, 2016 at 4:21 PM, Connor Abbott wrote: >> >> On Mon, Mar 21, 2016 at 6:51 PM, Connor Abbott >> wrote: >> > So overall, I think that there needs to be some explanation of the >> > design choices in the implementation. The

Re: [Mesa-dev] [PATCH 09/21] nir: Add a phi node placement helper

2016-03-21 Thread Jason Ekstrand
On Mon, Mar 21, 2016 at 4:21 PM, Connor Abbott wrote: > On Mon, Mar 21, 2016 at 6:51 PM, Connor Abbott > wrote: > > So overall, I think that there needs to be some explanation of the > > design choices in the implementation. The API documentation is great, > > but digging into the implementation

Re: [Mesa-dev] [PATCH 09/21] nir: Add a phi node placement helper

2016-03-21 Thread Connor Abbott
On Mon, Mar 21, 2016 at 6:51 PM, Connor Abbott wrote: > So overall, I think that there needs to be some explanation of the > design choices in the implementation. The API documentation is great, > but digging into the implementation might be a little daunting without > knowing e.g. why NEEDS_PHI i

Re: [Mesa-dev] [PATCH 09/21] nir: Add a phi node placement helper

2016-03-21 Thread Connor Abbott
So overall, I think that there needs to be some explanation of the design choices in the implementation. The API documentation is great, but digging into the implementation might be a little daunting without knowing e.g. why NEEDS_PHI is a thing. From what I gather, there are three potential states