Re: [Mesa-dev] [PATCH 02/13] nir: limit copy propagation inside loops

2016-08-29 Thread Connor Abbott
On Mon, Aug 29, 2016 at 2:30 AM, Timothy Arceri wrote: > On Mon, 2016-08-29 at 01:30 -0400, Connor Abbott wrote: >> On Mon, Aug 29, 2016 at 12:54 AM, Timothy Arceri >> wrote: >> > >> > Don't do copy propagation inside loops until after we try >> > unrolling them. >> > >> > This helps avoid propag

Re: [Mesa-dev] [PATCH 02/13] nir: limit copy propagation inside loops

2016-08-28 Thread Timothy Arceri
On Mon, 2016-08-29 at 01:30 -0400, Connor Abbott wrote: > On Mon, Aug 29, 2016 at 12:54 AM, Timothy Arceri > wrote: > > > > Don't do copy propagation inside loops until after we try > > unrolling them. > > > > This helps avoid propagating everything to the phis which > > makes loop unrolling mor

Re: [Mesa-dev] [PATCH 02/13] nir: limit copy propagation inside loops

2016-08-28 Thread Connor Abbott
On Mon, Aug 29, 2016 at 12:54 AM, Timothy Arceri wrote: > Don't do copy propagation inside loops until after we try > unrolling them. > > This helps avoid propagating everything to the phis which > makes loop unrolling more difficult. > > For example without this: > >loop { > block block