Re: [Mesa-dev] [PATCH 02/11] nir: Add a pass-running infastructure

2015-11-02 Thread Ian Romanick
On 10/28/2015 04:43 PM, Connor Abbott wrote: > On Wed, Oct 28, 2015 at 7:06 PM, Ian Romanick wrote: >> On 10/28/2015 02:32 PM, Jason Ekstrand wrote: >>> --- >>> src/glsl/nir/nir.h | 19 +++ >>> src/glsl/nir/nir_pass.c | 64 >>> - >>

Re: [Mesa-dev] [PATCH 02/11] nir: Add a pass-running infastructure

2015-10-30 Thread Ian Romanick
On 10/28/2015 06:15 PM, Connor Abbott wrote: > On Wed, Oct 28, 2015 at 8:04 PM, Ian Romanick wrote: >> On 10/28/2015 04:43 PM, Connor Abbott wrote: >>> On Wed, Oct 28, 2015 at 7:06 PM, Ian Romanick wrote: On 10/28/2015 02:32 PM, Jason Ekstrand wrote: > --- > src/glsl/nir/nir.h

Re: [Mesa-dev] [PATCH 02/11] nir: Add a pass-running infastructure

2015-10-30 Thread Ian Romanick
On 10/28/2015 06:30 PM, Kenneth Graunke wrote: > On Wednesday, October 28, 2015 05:04:07 PM Ian Romanick wrote: >> On 10/28/2015 04:43 PM, Connor Abbott wrote: >>> On Wed, Oct 28, 2015 at 7:06 PM, Ian Romanick wrote: On 10/28/2015 02:32 PM, Jason Ekstrand wrote: > --- > src/glsl/nir/

Re: [Mesa-dev] [PATCH 02/11] nir: Add a pass-running infastructure

2015-10-30 Thread Ian Romanick
On 10/28/2015 09:26 PM, Ilia Mirkin wrote: > On Wed, Oct 28, 2015 at 8:04 PM, Ian Romanick wrote: >> People often complain about the way that open-source projects are so nit >> picky about coding standards. It's a necessary survival tactic. Mesa >> is 22 years old. It has had dozens of contribu

Re: [Mesa-dev] [PATCH 02/11] nir: Add a pass-running infastructure

2015-10-28 Thread Ilia Mirkin
On Wed, Oct 28, 2015 at 8:04 PM, Ian Romanick wrote: > People often complain about the way that open-source projects are so nit > picky about coding standards. It's a necessary survival tactic. Mesa > is 22 years old. It has had dozens of contributors. Imagine how much There are like 10 diffe

Re: [Mesa-dev] [PATCH 02/11] nir: Add a pass-running infastructure

2015-10-28 Thread Connor Abbott
On Wed, Oct 28, 2015 at 8:51 PM, Jason Ekstrand wrote: > On Wed, Oct 28, 2015 at 5:41 PM, Connor Abbott wrote: >> On Wed, Oct 28, 2015 at 8:00 PM, Jason Ekstrand wrote: >>> On Wed, Oct 28, 2015 at 4:26 PM, Connor Abbott wrote: While it works for now, I'm not so sure about how we're conflat

Re: [Mesa-dev] [PATCH 02/11] nir: Add a pass-running infastructure

2015-10-28 Thread Kenneth Graunke
On Wednesday, October 28, 2015 05:04:07 PM Ian Romanick wrote: > On 10/28/2015 04:43 PM, Connor Abbott wrote: > > On Wed, Oct 28, 2015 at 7:06 PM, Ian Romanick wrote: > >> On 10/28/2015 02:32 PM, Jason Ekstrand wrote: > >>> --- > >>> src/glsl/nir/nir.h | 19 +++ > >>> src/glsl/ni

Re: [Mesa-dev] [PATCH 02/11] nir: Add a pass-running infastructure

2015-10-28 Thread Connor Abbott
On Wed, Oct 28, 2015 at 8:04 PM, Ian Romanick wrote: > On 10/28/2015 04:43 PM, Connor Abbott wrote: >> On Wed, Oct 28, 2015 at 7:06 PM, Ian Romanick wrote: >>> On 10/28/2015 02:32 PM, Jason Ekstrand wrote: --- src/glsl/nir/nir.h | 19 +++ src/glsl/nir/nir_pass.c |

Re: [Mesa-dev] [PATCH 02/11] nir: Add a pass-running infastructure

2015-10-28 Thread Jason Ekstrand
On Wed, Oct 28, 2015 at 5:41 PM, Connor Abbott wrote: > On Wed, Oct 28, 2015 at 8:00 PM, Jason Ekstrand wrote: >> On Wed, Oct 28, 2015 at 4:26 PM, Connor Abbott wrote: >>> While it works for now, I'm not so sure about how we're conflating the >>> definition of a pass and its dynamic instantiatio

Re: [Mesa-dev] [PATCH 02/11] nir: Add a pass-running infastructure

2015-10-28 Thread Connor Abbott
On Wed, Oct 28, 2015 at 8:00 PM, Jason Ekstrand wrote: > On Wed, Oct 28, 2015 at 4:26 PM, Connor Abbott wrote: >> While it works for now, I'm not so sure about how we're conflating the >> definition of a pass and its dynamic instantiation. Eventually we'll >> want to have passes refer to each oth

Re: [Mesa-dev] [PATCH 02/11] nir: Add a pass-running infastructure

2015-10-28 Thread Ian Romanick
On 10/28/2015 04:43 PM, Connor Abbott wrote: > On Wed, Oct 28, 2015 at 7:06 PM, Ian Romanick wrote: >> On 10/28/2015 02:32 PM, Jason Ekstrand wrote: >>> --- >>> src/glsl/nir/nir.h | 19 +++ >>> src/glsl/nir/nir_pass.c | 64 >>> - >>

Re: [Mesa-dev] [PATCH 02/11] nir: Add a pass-running infastructure

2015-10-28 Thread Kristian Høgsberg
On Wed, Oct 28, 2015 at 4:43 PM, Connor Abbott wrote: > On Wed, Oct 28, 2015 at 7:06 PM, Ian Romanick wrote: >> On 10/28/2015 02:32 PM, Jason Ekstrand wrote: >>> --- >>> src/glsl/nir/nir.h | 19 +++ >>> src/glsl/nir/nir_pass.c | 64 >>> ++

Re: [Mesa-dev] [PATCH 02/11] nir: Add a pass-running infastructure

2015-10-28 Thread Jason Ekstrand
On Wed, Oct 28, 2015 at 4:26 PM, Connor Abbott wrote: > While it works for now, I'm not so sure about how we're conflating the > definition of a pass and its dynamic instantiation. Eventually we'll > want to have passes refer to each other ("please run pass B after pass > A to clean up its mess",

Re: [Mesa-dev] [PATCH 02/11] nir: Add a pass-running infastructure

2015-10-28 Thread Connor Abbott
On Wed, Oct 28, 2015 at 7:06 PM, Ian Romanick wrote: > On 10/28/2015 02:32 PM, Jason Ekstrand wrote: >> --- >> src/glsl/nir/nir.h | 19 +++ >> src/glsl/nir/nir_pass.c | 64 >> - >> 2 files changed, 82 insertions(+), 1 deletion(-) >

Re: [Mesa-dev] [PATCH 02/11] nir: Add a pass-running infastructure

2015-10-28 Thread Connor Abbott
While it works for now, I'm not so sure about how we're conflating the definition of a pass and its dynamic instantiation. Eventually we'll want to have passes refer to each other ("please run pass B after pass A to clean up its mess", etc.), and in that case we need to be able to have to the pass

Re: [Mesa-dev] [PATCH 02/11] nir: Add a pass-running infastructure

2015-10-28 Thread Ian Romanick
On 10/28/2015 02:32 PM, Jason Ekstrand wrote: > --- > src/glsl/nir/nir.h | 19 +++ > src/glsl/nir/nir_pass.c | 64 > - > 2 files changed, 82 insertions(+), 1 deletion(-) > > diff --git a/src/glsl/nir/nir.h b/src/glsl/nir/nir.h > in