Re: [Mesa-dev] [PATCH 0/9] Lima mesa driver

2019-03-18 Thread Qiang Yu
On Sun, Mar 17, 2019 at 10:20 PM Rob Clark wrote: > > Any chance you could submit a gitlab MR? Replying with comments > inline to the driver patch is a bit more than gmail can handle.. OK, I've created one: https://gitlab.freedesktop.org/mesa/mesa/merge_requests/465 > > but quick comments: > >

Re: [Mesa-dev] [PATCH 0/9] Lima mesa driver

2019-03-17 Thread Rob Clark
Any chance you could submit a gitlab MR? Replying with comments inline to the driver patch is a bit more than gmail can handle.. but quick comments: In lima_pack_pp_frame_reg() maybe the swizzle field in 'struct util_format_description' is a better way to determine swap_channels? Not sure how ma