Re: [Mesa-dev] [PATCH 0/9] Fix shader_draw_parameters CTS tests

2017-11-30 Thread Kenneth Graunke
On Thursday, November 30, 2017 1:11:28 PM PST Neil Roberts wrote: > Kenneth Graunke writes: > > > Neil, in case you were wondering, I suggested the above organization > > of vertex elements because it would let us only upload 1 in the common > > case. Looking in shader-db, there are 3579 shaders

Re: [Mesa-dev] [PATCH 0/9] Fix shader_draw_parameters CTS tests

2017-11-30 Thread Neil Roberts
Kenneth Graunke writes: > Neil, in case you were wondering, I suggested the above organization > of vertex elements because it would let us only upload 1 in the common > case. Looking in shader-db, there are 3579 shaders that use > gl_InstanceID, 186 shaders that use gl_VertexID, and 0 shaders th

Re: [Mesa-dev] [PATCH 0/9] Fix shader_draw_parameters CTS tests

2017-11-30 Thread Kenneth Graunke
On Friday, November 10, 2017 9:53:28 AM PST Antia Puentes wrote: > Hi, > > the series sets gl_BaseVertex to zero for gl*DrawArrays* in i965. [snip] Hi Antia, Neil, The end result of this series looks reasonable, but it looks like it's going to break a bunch of things at each step. Either that o

Re: [Mesa-dev] [PATCH 0/9] Fix shader_draw_parameters CTS tests

2017-11-10 Thread Neil Roberts
Just to note, I made some Piglit patches to verify this new behaviour too: https://patchwork.freedesktop.org/series/33626/ This might make testing a little easier if someone wants to implement the behaviour for other drivers too. - Neil Antia Puentes writes: > Hi, > > the series sets gl_BaseV