Re: [Mesa-dev] [PATCH] radv: Really use correct HTILE expanded words.

2018-02-23 Thread Bas Nieuwenhuizen
On Fri, Feb 23, 2018 at 11:52 AM, James Legg wrote: > On Thu, 2018-02-22 at 22:48 +0100, Bas Nieuwenhuizen wrote: >> since IIRC the last change was also done due to Feral noticing and we >> are clearly lacking testcases in this area, can you check that that >> case still works for you? Thanks a lo

Re: [Mesa-dev] [PATCH] radv: Really use correct HTILE expanded words.

2018-02-23 Thread James Legg
On Thu, 2018-02-22 at 22:48 +0100, Bas Nieuwenhuizen wrote: > since IIRC the last change was also done due to Feral noticing and we > are clearly lacking testcases in this area, can you check that that > case still works for you? Thanks a lot! I looked at an issue that was fixed with 5158603182fe7

Re: [Mesa-dev] [PATCH] radv: Really use correct HTILE expanded words.

2018-02-22 Thread Grazvydas Ignotas
Seems to fix dxvk, nice! Also tested DOOM which still works. Tested-by: Grazvydas Ignotas On Thu, Feb 22, 2018 at 6:57 PM, James Legg wrote: > When transitioning to an htile compressed depth format, Set the full > depth range, so later rasterization can pass HiZ. Previously, for depth > only for

Re: [Mesa-dev] [PATCH] radv: Really use correct HTILE expanded words.

2018-02-22 Thread Bas Nieuwenhuizen
yeah, looks like I may have lifted the values from a driver which set the ZRANGE_PRECISION to 0, but this at least mirrors PAL and fixes one of the remaining transition issues there that I was aware of. Reviewed-by: Bas Nieuwenhuizen since IIRC the last change was also done due to Feral noticing