Re: [Mesa-dev] [PATCH] mesa: add bounds checking to eliminate buffer overrun

2014-04-08 Thread Kenneth Graunke
On 04/08/2014 08:10 AM, Courtney Goeltzenleuchter wrote: > Decompressing ETC2 textures was causing intermitent segfault > by copying resulting 4x4 texel block to the destination texture > regardless of the size of the destination texture. Issue found > via application crash in GLBenchmark 3.0's Man

Re: [Mesa-dev] [PATCH] mesa: add bounds checking to eliminate buffer overrun

2014-04-08 Thread Courtney Goeltzenleuchter
Apologies folks, I had made those changes and somehow grabbed the wrong patch when I went to add the bug reference. Ugh. This time for sure! I'll follow this with the -- real -- patch. Courtney On Tue, Apr 8, 2014 at 1:28 AM, Kenneth Graunke wrote: > On 04/07/2014 09:20 PM, Courtney Goeltzenle

Re: [Mesa-dev] [PATCH] mesa: add bounds checking to eliminate buffer overrun

2014-04-08 Thread Kenneth Graunke
On 04/07/2014 09:20 PM, Courtney Goeltzenleuchter wrote: > Decompressing ETC2 textures was causing intermitent segfault > by copying resulting 4x4 texel block to the destination texture > regardless of the size of the destination texture. Issue found > via application crash in GLBenchmark 3.0's Man

Re: [Mesa-dev] [PATCH] mesa: add bounds checking to eliminate buffer overrun

2014-04-07 Thread Courtney Goeltzenleuchter
Thanks Emil, I've got it sorted out I think. The format of the cc: was incorrect, it shouldn't have the piece. Should look like: Cc: "9.2 10.0 10.1" I'll send out updated patch. Courtney On Mon, Apr 7, 2014 at 6:28 PM, Emil Velikov wrote: > On 08/04/14 01:18, Courtney Goeltzenleuchter wrote:

Re: [Mesa-dev] [PATCH] mesa: add bounds checking to eliminate buffer overrun

2014-04-07 Thread Emil Velikov
On 08/04/14 01:18, Courtney Goeltzenleuchter wrote: > Hi Ian, > > I didn't think this even got out. I was getting a weird error from > git-send-mail when it tried to send to the gmail server and I got > distracted with other things. > > Here's log: > Send this email? ([y]es|[n]o|[q]uit|[a]ll): y

Re: [Mesa-dev] [PATCH] mesa: add bounds checking to eliminate buffer overrun

2014-04-07 Thread Courtney Goeltzenleuchter
Hi Ian, I didn't think this even got out. I was getting a weird error from git-send-mail when it tried to send to the gmail server and I got distracted with other things. Here's log: Send this email? ([y]es|[n]o|[q]uit|[a]ll): y Password for 'smtp://court...@lunarg.com@smtp.gmail.com:587': OK. Lo

Re: [Mesa-dev] [PATCH] mesa: add bounds checking to eliminate buffer overrun

2014-04-07 Thread Ian Romanick
On 04/07/2014 12:19 PM, Courtney Goeltzenleuchter wrote: > Updated patch to include reference to bug that it resolves. Where? The proper way to do this is to send the path with git-send-mail, and include extra verbage in the commit message like: v3: Updated patch to include reference to bug that

Re: [Mesa-dev] [PATCH] mesa: add bounds checking to eliminate buffer overrun

2014-02-28 Thread Courtney Goeltzenleuchter
No, I do not believe this commit has made it. Courtney On Wed, Feb 26, 2014 at 11:44 AM, Ian Romanick wrote: > On 02/17/2014 09:43 AM, Courtney Goeltzenleuchter wrote: > >> Thanks for the feedback. >> >> I've updated the patch to integrate Ian's comments. >> > > Did the updated patch ever land

Re: [Mesa-dev] [PATCH] mesa: add bounds checking to eliminate buffer overrun

2014-02-26 Thread Ian Romanick
On 02/17/2014 09:43 AM, Courtney Goeltzenleuchter wrote: Thanks for the feedback. I've updated the patch to integrate Ian's comments. Did the updated patch ever land? Courtney On Fri, Feb 14, 2014 at 2:00 PM, Ian Romanick mailto:i...@freedesktop.org>> wrote: On 02/14/2014 07:52 AM, Co

Re: [Mesa-dev] [PATCH] mesa: add bounds checking to eliminate buffer overrun

2014-02-17 Thread Courtney Goeltzenleuchter
Thanks for the feedback. I've updated the patch to integrate Ian's comments. Courtney On Fri, Feb 14, 2014 at 2:00 PM, Ian Romanick wrote: > On 02/14/2014 07:52 AM, Courtney Goeltzenleuchter wrote: > > Decompressing ETC2 textures was causing intermitent segfault > > by copying resulting 4x4 t

Re: [Mesa-dev] [PATCH] mesa: add bounds checking to eliminate buffer overrun

2014-02-14 Thread Ian Romanick
On 02/14/2014 07:52 AM, Courtney Goeltzenleuchter wrote: > Decompressing ETC2 textures was causing intermitent segfault > by copying resulting 4x4 texel block to the destination texture > regardless of the size of the destination texture. Issue found > via application crash in GLBenchmark 3.0's Man

Re: [Mesa-dev] [PATCH] mesa: add bounds checking to eliminate buffer overrun

2014-02-14 Thread Courtney Goeltzenleuchter
Forgot to mention. This patch addresses bug #74988 . No piglit regressions. Courtney On Fri, Feb 14, 2014 at 8:52 AM, Courtney Goeltzenleuchter < court...@lunarg.com> wrote: > Decompressing ETC2 textures was causing intermitent segfault > by