Re: [Mesa-dev] [PATCH] mesa: add back glGetnUniformfv() overflow error reporting

2012-03-13 Thread Brian Paul
This looks good to me. One minor comment below. On 03/13/2012 01:51 AM, nobled wrote: ping x2 Also an 8.0 candidate, now that 8.0 exists. On Mon, Jan 16, 2012 at 6:52 PM, nobled wrote: ping? On Thu, Dec 22, 2011 at 4:34 PM, nob...@dreamwidth.org wrote: The error was erroneously removed i

Re: [Mesa-dev] [PATCH] mesa: add back glGetnUniformfv() overflow error reporting

2012-03-13 Thread nobled
ping x2 Also an 8.0 candidate, now that 8.0 exists. On Mon, Jan 16, 2012 at 6:52 PM, nobled wrote: > ping? > > On Thu, Dec 22, 2011 at 4:34 PM, nob...@dreamwidth.org wrote: >> The error was erroneously removed in this commit: >> >> 719909698c67c287a393d2380278e7b7495ae018 >> "mesa: Rewrite the w

Re: [Mesa-dev] [PATCH] mesa: add back glGetnUniformfv() overflow error reporting

2012-01-16 Thread nobled
ping? On Thu, Dec 22, 2011 at 4:34 PM, nob...@dreamwidth.org wrote: > The error was erroneously removed in this commit: > > 719909698c67c287a393d2380278e7b7495ae018 > "mesa: Rewrite the way uniforms are tracked and handled" > > You also aren't even supposed to truncate the output to 'bufSize', > s