Re: [Mesa-dev] [PATCH] intel/tools: new i965_disasm tool

2018-08-20 Thread Sagar Ghuge
Thanks for reviewing the patch. I will make changes and send v2 accordingly. On 08/20/2018 11:34 AM, Matt Turner wrote: > On Thu, Aug 16, 2018 at 1:51 PM Sagar Ghuge wrote: >> >> Adds a new i965 instruction disassemble tool > > This looks very good. A few comments about the structure inline. >

Re: [Mesa-dev] [PATCH] intel/tools: new i965_disasm tool

2018-08-20 Thread Matt Turner
On Thu, Aug 16, 2018 at 1:51 PM Sagar Ghuge wrote: > > Adds a new i965 instruction disassemble tool This looks very good. A few comments about the structure inline. > Signed-off-by: Sagar Ghuge > --- > src/intel/Makefile.tools.am | 15 +++ > src/intel/tools/i965_disasm.c | 202 +