Re: [Mesa-dev] [PATCH] intel/eu: print bytes instead of 32 bit hex value

2018-08-20 Thread Sagar Ghuge
On 08/20/2018 11:06 AM, Matt Turner wrote: > Cool. This looks pretty good to me. A few comments inline. > > On Wed, Aug 15, 2018 at 2:00 PM Sagar Ghuge wrote: >> >> INTEL_DEBUG=hex prints 32 bit hex value >> and due to endianness of CPU byte order is >> reversed. In order to disassemble binary

Re: [Mesa-dev] [PATCH] intel/eu: print bytes instead of 32 bit hex value

2018-08-20 Thread Matt Turner
Cool. This looks pretty good to me. A few comments inline. On Wed, Aug 15, 2018 at 2:00 PM Sagar Ghuge wrote: > > INTEL_DEBUG=hex prints 32 bit hex value > and due to endianness of CPU byte order is > reversed. In order to disassemble binary > files, print each byte instead of 32 bit hex > value.