Re: [Mesa-dev] [PATCH] i965: Simplify MOCS mashing in genX_state_upload.c.

2017-08-24 Thread Lionel Landwerlin
On 24/08/17 16:15, Kenneth Graunke wrote: On Thursday, August 24, 2017 4:04:26 AM PDT Lionel Landwerlin wrote: Looks good, but it looks like you could replace an additional one in upload_push_constant_packets(). That one is a bit weird - it uses 0 on Gen8+. I've wondered about that, actually -

Re: [Mesa-dev] [PATCH] i965: Simplify MOCS mashing in genX_state_upload.c.

2017-08-24 Thread Kenneth Graunke
On Thursday, August 24, 2017 4:04:26 AM PDT Lionel Landwerlin wrote: > Looks good, but it looks like you could replace an additional one in > upload_push_constant_packets(). That one is a bit weird - it uses 0 on Gen8+. I've wondered about that, actually - the docs claim that you must use 0 - bu

Re: [Mesa-dev] [PATCH] i965: Simplify MOCS mashing in genX_state_upload.c.

2017-08-24 Thread Lionel Landwerlin
Looks good, but it looks like you could replace an additional one in upload_push_constant_packets(). Also why not name it GEN_MOCS ? (so it's a bit more consistent with other macros defined per gen). Thanks! On 23/08/17 23:57, Kenneth Graunke wrote: Instead of having a proliferation of genera