Re: [Mesa-dev] [PATCH] i965/fs: Fix saturate for nir_opcode_bcsel.

2015-02-03 Thread Jason Ekstrand
On Tue, Feb 3, 2015 at 12:42 PM, Connor Abbott wrote: > On Tue, Feb 3, 2015 at 3:27 PM, Kenneth Graunke > wrote: > > On Tuesday, February 03, 2015 07:10:20 AM you wrote: > >> On Feb 3, 2015 2:35 AM, "Kenneth Graunke" > wrote: > >> > Caught by lit_sat.shader_test. > >> > > >> > Signed-off-by: Ke

Re: [Mesa-dev] [PATCH] i965/fs: Fix saturate for nir_opcode_bcsel.

2015-02-03 Thread Connor Abbott
On Tue, Feb 3, 2015 at 3:27 PM, Kenneth Graunke wrote: > On Tuesday, February 03, 2015 07:10:20 AM you wrote: >> On Feb 3, 2015 2:35 AM, "Kenneth Graunke" wrote: >> > Caught by lit_sat.shader_test. >> > >> > Signed-off-by: Kenneth Graunke >> > --- >> > src/mesa/drivers/dri/i965/brw_fs_nir.cpp |

Re: [Mesa-dev] [PATCH] i965/fs: Fix saturate for nir_opcode_bcsel.

2015-02-03 Thread Jason Ekstrand
On Tue, Feb 3, 2015 at 12:27 PM, Kenneth Graunke wrote: > On Tuesday, February 03, 2015 07:10:20 AM you wrote: > > On Feb 3, 2015 2:35 AM, "Kenneth Graunke" wrote: > > > Caught by lit_sat.shader_test. > > > > > > Signed-off-by: Kenneth Graunke > > > --- > > > src/mesa/drivers/dri/i965/brw_fs_n

Re: [Mesa-dev] [PATCH] i965/fs: Fix saturate for nir_opcode_bcsel.

2015-02-03 Thread Kenneth Graunke
On Tuesday, February 03, 2015 07:10:20 AM you wrote: > On Feb 3, 2015 2:35 AM, "Kenneth Graunke" wrote: > > Caught by lit_sat.shader_test. > > > > Signed-off-by: Kenneth Graunke > > --- > > src/mesa/drivers/dri/i965/brw_fs_nir.cpp | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/sr

Re: [Mesa-dev] [PATCH] i965/fs: Fix saturate for nir_opcode_bcsel.

2015-02-03 Thread Jason Ekstrand
Hrm... I thought bcsel worked on integers. You shouldn't be able to sat it anyway... This seems strange. As a side-note, this is one of the downsides to typeless that we should figure out how to solve. Not 100% sure how at the moment. On Feb 3, 2015 2:35 AM, "Kenneth Graunke" wrote: > Caught b