Re: [Mesa-dev] [PATCH] glsl: remove logical xor FINISHME

2012-01-09 Thread Kenneth Graunke
On 01/09/2012 08:36 AM, Eric Anholt wrote: On Sun, 8 Jan 2012 22:44:17 -0500, Matt Turner wrote: GLSL spec boneheadedly says (a ^^ a) must actually be evaluated. What it's trying to say there is that any side-effects of both LHS and RHS will occur (as opposed to how&& or || work), not that

Re: [Mesa-dev] [PATCH] glsl: remove logical xor FINISHME

2012-01-09 Thread Eric Anholt
On Sun, 8 Jan 2012 22:44:17 -0500, Matt Turner wrote: > GLSL spec boneheadedly says (a ^^ a) must actually be evaluated. What it's trying to say there is that any side-effects of both LHS and RHS will occur (as opposed to how && or || work), not that you actually compute the expression that you

Re: [Mesa-dev] [PATCH] glsl: remove logical xor FINISHME

2012-01-08 Thread Matt Turner
On Sun, Jan 8, 2012 at 10:44 PM, Matt Turner wrote: > GLSL spec boneheadedly says (a ^^ a) must actually be evaluated. > > Signed-off-by: Matt Turner > --- On second thought, maybe the better thing to do here is to evaluate $a twice, which in most cases would be dead-code eliminated, and then si