Re: [Mesa-dev] [PATCH] draw/llvm: fix generation of the VS with GS present

2014-03-04 Thread Matthew McClure
Looks good to me too! Reviewed-by: Matthew McClure Matthew - Original Message - From: "Roland Scheidegger" To: "Zack Rusin" , mesa-dev@lists.freedesktop.org Cc: jfons...@vmware.com, mcclu...@vmware.com Sent: Tuesday, March 4, 2014 8:57:30 AM Subject: Re: [PATCH] draw/llvm: fix generati

Re: [Mesa-dev] [PATCH] draw/llvm: fix generation of the VS with GS present

2014-03-04 Thread Roland Scheidegger
Am 04.03.2014 05:08, schrieb Zack Rusin: > draw_current_shader_* functions return a final output when considering > both the geometry shader and the vertex shader. But when code generating > vertex shader we can not be using output slots from the geometry shader > because, obviously, those can be c

Re: [Mesa-dev] [PATCH] draw/llvm: fix generation of the VS with GS present

2014-03-04 Thread Jose Fonseca
Makes sense. Good catch. BTW, both changes seem candidate for stable branch. Jose - Original Message - > draw_current_shader_* functions return a final output when considering > both the geometry shader and the vertex shader. But when code generating > vertex shader we can not be using o