Re: [Mesa-dev] [PATCH] c11/threads: initialize timeout structure

2015-10-08 Thread Emil Velikov
On 6 October 2015 at 21:39, Jose Fonseca wrote: > On 06/10/15 20:30, Ian Romanick wrote: >> >> On 10/06/2015 12:04 PM, Matt Turner wrote: >>> >>> On Sat, Oct 3, 2015 at 5:19 PM, Jan Vesely wrote: Signed-off-by: Jan Vesely --- include/c11/threads_posix.h | 6 ++ 1

Re: [Mesa-dev] [PATCH] c11/threads: initialize timeout structure

2015-10-08 Thread Emil Velikov
On 8 October 2015 at 06:44, Jan Vesely wrote: > On Tue, 2015-10-06 at 10:38 -0700, Ian Romanick wrote: >> I had also noticed the unused parameter warning, but I had a patch >> that >> just papered over the problem. I'm a bit annoyed that GCC didn't >> warn >> (but I guess it couldn't really) that

Re: [Mesa-dev] [PATCH] c11/threads: initialize timeout structure

2015-10-07 Thread Jan Vesely
On Tue, 2015-10-06 at 10:38 -0700, Ian Romanick wrote: > I had also noticed the unused parameter warning, but I had a patch > that > just papered over the problem. I'm a bit annoyed that GCC didn't > warn > (but I guess it couldn't really) that abs_time might be used > uninitialized. > > This pat

Re: [Mesa-dev] [PATCH] c11/threads: initialize timeout structure

2015-10-06 Thread Jose Fonseca
On 06/10/15 20:30, Ian Romanick wrote: On 10/06/2015 12:04 PM, Matt Turner wrote: On Sat, Oct 3, 2015 at 5:19 PM, Jan Vesely wrote: Signed-off-by: Jan Vesely --- include/c11/threads_posix.h | 6 ++ 1 file changed, 6 insertions(+) diff --git a/include/c11/threads_posix.h b/include/c11/

Re: [Mesa-dev] [PATCH] c11/threads: initialize timeout structure

2015-10-06 Thread Ian Romanick
On 10/06/2015 12:04 PM, Matt Turner wrote: > On Sat, Oct 3, 2015 at 5:19 PM, Jan Vesely wrote: >> Signed-off-by: Jan Vesely >> --- >> include/c11/threads_posix.h | 6 ++ >> 1 file changed, 6 insertions(+) >> >> diff --git a/include/c11/threads_posix.h b/include/c11/threads_posix.h >> index 3

Re: [Mesa-dev] [PATCH] c11/threads: initialize timeout structure

2015-10-06 Thread Matt Turner
On Sat, Oct 3, 2015 at 5:19 PM, Jan Vesely wrote: > Signed-off-by: Jan Vesely > --- > include/c11/threads_posix.h | 6 ++ > 1 file changed, 6 insertions(+) > > diff --git a/include/c11/threads_posix.h b/include/c11/threads_posix.h > index 3def6c4..ce9853b 100644 > --- a/include/c11/threads_p

Re: [Mesa-dev] [PATCH] c11/threads: initialize timeout structure

2015-10-06 Thread Ian Romanick
I had also noticed the unused parameter warning, but I had a patch that just papered over the problem. I'm a bit annoyed that GCC didn't warn (but I guess it couldn't really) that abs_time might be used uninitialized. This patch is Reviewed-by: Ian Romanick On 10/03/2015 05:19 PM, Jan Vesely w