Re: [Mesa-dev] [PATCH] Mesa: Fix performance query id check

2017-03-01 Thread Robert Bragg
Since seeing that I had indeed sent out a v2 patch and it was reviewed by Plamena too (thanks) I've just gone a head and pushed that now (though with an updated commit message instead of copy pasting the original message). Thanks, - Robert On Mon, Feb 27, 2017 at 3:43 PM, Robert Bragg wrote: >

Re: [Mesa-dev] [PATCH] Mesa: Fix performance query id check

2017-02-27 Thread Robert Bragg
On Mon, Feb 27, 2017 at 2:47 PM, Juha-Pekka Heikkila wrote: > In queryid_valid() fix handling of zero index. > > CC: Robert Bragg > Signed-off-by: Juha-Pekka Heikkila > --- > src/mesa/main/performance_query.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/mesa/main

Re: [Mesa-dev] [PATCH] mesa: Fix performance query id check

2017-02-26 Thread Manolova, Plamena
Looks good to me :) Reviewed-by: Plamena Manolova On Fri, Feb 24, 2017 at 6:46 PM, Robert Bragg wrote: > In queryid_valid() index is unsigned so checking if it is less > than zero is useless. On queryid_to_index() is comment > saying 0 is reserved to be invalid thus rule it out. > > This is a