Re: [Mesa-dev] r600/sb loop issue

2014-12-16 Thread Vadim Girlin
On 12/16/2014 05:44 AM, Dave Airlie wrote: On 16 December 2014 at 08:59, Vadim Girlin wrote: On 12/16/2014 01:30 AM, Dave Airlie wrote: New patch is attached, the only difference is in the sb_sched.cpp (it disables copy coalescing for some "unsafe" cases, so it may leave more MOVs than prev

Re: [Mesa-dev] r600/sb loop issue

2014-12-15 Thread Dave Airlie
On 16 December 2014 at 08:59, Vadim Girlin wrote: > On 12/16/2014 01:30 AM, Dave Airlie wrote: > > > > New patch is attached, the only difference is in the sb_sched.cpp (it > disables copy coalescing for some "unsafe" cases, so it may leave more > MOVs > than previously

Re: [Mesa-dev] r600/sb loop issue

2014-12-15 Thread Vadim Girlin
On 12/16/2014 01:30 AM, Dave Airlie wrote: New patch is attached, the only difference is in the sb_sched.cpp (it disables copy coalescing for some "unsafe" cases, so it may leave more MOVs than previously, but I don't think there will be any noticeable effect on performance). So far I don't se

Re: [Mesa-dev] r600/sb loop issue

2014-12-15 Thread Dave Airlie
>>> >>> >>> New patch is attached, the only difference is in the sb_sched.cpp (it >>> disables copy coalescing for some "unsafe" cases, so it may leave more >>> MOVs >>> than previously, but I don't think there will be any noticeable effect on >>> performance). >>> >>> So far I don't see any proble

Re: [Mesa-dev] r600/sb loop issue

2014-12-15 Thread Vadim Girlin
On 12/12/2014 05:28 PM, Alex Deucher wrote: On Wed, Dec 10, 2014 at 6:50 AM, Vadim Girlin wrote: On 12/09/2014 07:39 AM, Vadim Girlin wrote: On 12/09/2014 05:18 AM, Dave Airlie wrote: On 8 December 2014 at 20:41, Vadim Girlin wrote: On 12/06/2014 07:13 AM, Vadim Girlin wrote: On 12/04

Re: [Mesa-dev] r600/sb loop issue

2014-12-12 Thread Alex Deucher
On Wed, Dec 10, 2014 at 6:50 AM, Vadim Girlin wrote: > On 12/09/2014 07:39 AM, Vadim Girlin wrote: >> >> On 12/09/2014 05:18 AM, Dave Airlie wrote: >>> >>> On 8 December 2014 at 20:41, Vadim Girlin wrote: On 12/06/2014 07:13 AM, Vadim Girlin wrote: > > > On 12/04/2014 01:43

Re: [Mesa-dev] r600/sb loop issue

2014-12-10 Thread Vadim Girlin
On 12/09/2014 07:39 AM, Vadim Girlin wrote: On 12/09/2014 05:18 AM, Dave Airlie wrote: On 8 December 2014 at 20:41, Vadim Girlin wrote: On 12/06/2014 07:13 AM, Vadim Girlin wrote: On 12/04/2014 01:43 AM, Dave Airlie wrote: Hi Vadim, I've been looking with Glenn's help into a bug in sb for

Re: [Mesa-dev] r600/sb loop issue

2014-12-08 Thread Vadim Girlin
On 12/09/2014 05:18 AM, Dave Airlie wrote: On 8 December 2014 at 20:41, Vadim Girlin wrote: On 12/06/2014 07:13 AM, Vadim Girlin wrote: On 12/04/2014 01:43 AM, Dave Airlie wrote: Hi Vadim, I've been looking with Glenn's help into a bug in sb for a couple of weeks now triggered by a change

Re: [Mesa-dev] r600/sb loop issue

2014-12-08 Thread Dave Airlie
On 8 December 2014 at 20:41, Vadim Girlin wrote: > On 12/06/2014 07:13 AM, Vadim Girlin wrote: >> >> On 12/04/2014 01:43 AM, Dave Airlie wrote: >>> >>> Hi Vadim, >>> >>> I've been looking with Glenn's help into a bug in sb for a couple of >>> weeks now triggered by a change in how GLSL generates s

Re: [Mesa-dev] r600/sb loop issue

2014-12-08 Thread Dave Airlie
On 9 December 2014 at 10:25, Dave Airlie wrote: > On 8 December 2014 at 20:41, Vadim Girlin wrote: >> On 12/06/2014 07:13 AM, Vadim Girlin wrote: >>> >>> On 12/04/2014 01:43 AM, Dave Airlie wrote: Hi Vadim, I've been looking with Glenn's help into a bug in sb for a couple of >

Re: [Mesa-dev] r600/sb loop issue

2014-12-08 Thread Dave Airlie
On 8 December 2014 at 20:41, Vadim Girlin wrote: > On 12/06/2014 07:13 AM, Vadim Girlin wrote: >> >> On 12/04/2014 01:43 AM, Dave Airlie wrote: >>> >>> Hi Vadim, >>> >>> I've been looking with Glenn's help into a bug in sb for a couple of >>> weeks now triggered by a change in how GLSL generates s

Re: [Mesa-dev] r600/sb loop issue

2014-12-08 Thread Vadim Girlin
On 12/06/2014 07:13 AM, Vadim Girlin wrote: On 12/04/2014 01:43 AM, Dave Airlie wrote: Hi Vadim, I've been looking with Glenn's help into a bug in sb for a couple of weeks now triggered by a change in how GLSL generates switch statements. I understand you probably aren't too interested in r600

Re: [Mesa-dev] r600/sb loop issue

2014-12-05 Thread Vadim Girlin
On 12/06/2014 08:01 AM, Matt Turner wrote: On Fri, Dec 5, 2014 at 8:56 PM, Vadim Girlin wrote: On 12/06/2014 07:50 AM, Matt Turner wrote: On Fri, Dec 5, 2014 at 8:13 PM, Vadim Girlin wrote: I suspect we should rather get rid of such loops somehow, i.e. convert to something else, the loop t

Re: [Mesa-dev] r600/sb loop issue

2014-12-05 Thread Matt Turner
On Fri, Dec 5, 2014 at 8:56 PM, Vadim Girlin wrote: > On 12/06/2014 07:50 AM, Matt Turner wrote: >> >> On Fri, Dec 5, 2014 at 8:13 PM, Vadim Girlin >> wrote: >>> >>> I suspect we should rather get rid of such loops somehow, i.e. convert to >>> something else, the loop that never repeats is not re

Re: [Mesa-dev] r600/sb loop issue

2014-12-05 Thread Vadim Girlin
On 12/06/2014 07:50 AM, Matt Turner wrote: On Fri, Dec 5, 2014 at 8:13 PM, Vadim Girlin wrote: I suspect we should rather get rid of such loops somehow, i.e. convert to something else, the loop that never repeats is not really a loop anyway. AFAICS "continue" is not supported in switch statemen

Re: [Mesa-dev] r600/sb loop issue

2014-12-05 Thread Matt Turner
On Fri, Dec 5, 2014 at 8:13 PM, Vadim Girlin wrote: > I suspect we should rather get rid of such loops somehow, i.e. convert to > something else, the loop that never repeats is not really a loop anyway. > AFAICS "continue" is not supported in switch statements according to GLSL > specs, so the loo

Re: [Mesa-dev] r600/sb loop issue

2014-12-05 Thread Vadim Girlin
On 12/04/2014 01:43 AM, Dave Airlie wrote: Hi Vadim, I've been looking with Glenn's help into a bug in sb for a couple of weeks now triggered by a change in how GLSL generates switch statements. I understand you probably aren't too interested in r600g but I believe I'm hitting a design level pr

[Mesa-dev] r600/sb loop issue

2014-12-03 Thread Dave Airlie
Hi Vadim, I've been looking with Glenn's help into a bug in sb for a couple of weeks now triggered by a change in how GLSL generates switch statements. I understand you probably aren't too interested in r600g but I believe I'm hitting a design level problem and I would like some advice. So it ap