Re: [Mesa-dev] mediump / half-precision support

2016-05-15 Thread Rob Clark
hmm, that is still a lot of sites of type comparison to fixup, unless maybe some operator overloading hackery.. but that sounds ugly.. I guess the pass to propagate precision works out equivalently, as far as applying precision propagation, to my precision_visitor. Not *really* sure that makes it

Re: [Mesa-dev] mediump / half-precision support

2016-05-15 Thread Connor Abbott
Maybe instead you could do something in the middle -- add a precision field to glsl_type instead of adding to glsl_base_type. Then make different precision types compare equal in most places (since it is a hint to the compiler, rather than a full-fledged extra type) and have a pass that propagates

[Mesa-dev] mediump / half-precision support

2016-05-15 Thread Rob Clark
So I've been hacking around on a couple approaches to getting half-precision support going for gles (and btw, someday it might be interesting to have an extension to respect precision qualifiers in gl too) I initially started by propagating ir_variable_data::precision to nir_variable_data and fixi