Re: [Mesa-dev] glxinfo proposed change

2013-01-07 Thread Jorge Ramirez Ortiz, HCL Europe
>>> -Original Message- >>> From: Ian Romanick [mailto:i...@freedesktop.org] >>> Sent: Monday, January 07, 2013 7:48 PM >>> To: Jorge Ramirez Ortiz, HCL Europe >>> Cc: Dan Nicholson; mesa-dev@lists.freedesktop.org >>> Subject: Re: [Mesa

Re: [Mesa-dev] glxinfo proposed change

2013-01-07 Thread Ian Romanick
] glxinfo proposed change On 01/07/2013 06:35 AM, Jorge Ramirez Ortiz, HCL Europe wrote: -Original Message- From: Dan Nicholson [mailto:dbn.li...@gmail.com] Sent: Monday, January 07, 2013 2:31 PM To: Jorge Ramirez Ortiz, HCL Europe Cc: mesa-dev@lists.freedesktop.org Subject: Re: [Mesa-dev

Re: [Mesa-dev] glxinfo proposed change

2013-01-07 Thread Brian Paul
On 01/07/2013 02:34 PM, Matt Turner wrote: On Mon, Jan 7, 2013 at 1:08 PM, Jorge Ramirez Ortiz, HCL Europe wrote: You are absolutely wrong. NULL is a valid return value. Please read the code. I'm not sure if you missed Ian's point or you're just being pedantic, but let me try to explain. Th

Re: [Mesa-dev] glxinfo proposed change

2013-01-07 Thread Matt Turner
On Mon, Jan 7, 2013 at 1:08 PM, Jorge Ramirez Ortiz, HCL Europe wrote: > You are absolutely wrong. NULL is a valid return value. Please read the code. I'm not sure if you missed Ian's point or you're just being pedantic, but let me try to explain. The glxinfo code does this: if (glXMakeCurrent(

Re: [Mesa-dev] glxinfo proposed change

2013-01-07 Thread Jorge Ramirez Ortiz, HCL Europe
>-Original Message- >From: Brian Paul [mailto:bri...@vmware.com] >Sent: Monday, January 07, 2013 8:07 PM >To: Jorge Ramirez Ortiz, HCL Europe >Cc: Ian Romanick; mesa-dev@lists.freedesktop.org >Subject: Re: [Mesa-dev] glxinfo proposed change > >On 01/07/2013 11:4

Re: [Mesa-dev] glxinfo proposed change

2013-01-07 Thread Jorge Ramirez Ortiz, HCL Europe
>-Original Message- >From: Ian Romanick [mailto:i...@freedesktop.org] >Sent: Monday, January 07, 2013 7:48 PM >To: Jorge Ramirez Ortiz, HCL Europe >Cc: Dan Nicholson; mesa-dev@lists.freedesktop.org >Subject: Re: [Mesa-dev] glxinfo proposed change > >On 01/07/2013

Re: [Mesa-dev] glxinfo proposed change

2013-01-07 Thread Brian Paul
Subject: Re: [Mesa-dev] glxinfo proposed change On Mon, Jan 7, 2013 at 5:06 AM, Jorge Ramirez Ortiz, HCL Europe wrote: Hi all, Does this patch make sense? glVersion can be NULL and not having the changes below could cause a SIGSEGV [jramirez@calypso-2 mesa-demos.git (tmp *)]$ git diff src

Re: [Mesa-dev] glxinfo proposed change

2013-01-07 Thread Ian Romanick
On 01/07/2013 06:35 AM, Jorge Ramirez Ortiz, HCL Europe wrote: -Original Message- From: Dan Nicholson [mailto:dbn.li...@gmail.com] Sent: Monday, January 07, 2013 2:31 PM To: Jorge Ramirez Ortiz, HCL Europe Cc: mesa-dev@lists.freedesktop.org Subject: Re: [Mesa-dev] glxinfo proposed change

Re: [Mesa-dev] glxinfo proposed change

2013-01-07 Thread Jorge Ramirez Ortiz, HCL Europe
>-Original Message- >From: Dan Nicholson [mailto:dbn.li...@gmail.com] >Sent: Monday, January 07, 2013 2:31 PM >To: Jorge Ramirez Ortiz, HCL Europe >Cc: mesa-dev@lists.freedesktop.org >Subject: Re: [Mesa-dev] glxinfo proposed change > >On Mon, Jan 7, 2013 at 5:06

Re: [Mesa-dev] glxinfo proposed change

2013-01-07 Thread Dan Nicholson
On Mon, Jan 7, 2013 at 5:06 AM, Jorge Ramirez Ortiz, HCL Europe wrote: > Hi all, > > Does this patch make sense? glVersion can be NULL and not having the changes > below could cause a SIGSEGV > > [jramirez@calypso-2 mesa-demos.git (tmp *)]$ git diff src/xdemos/glxinfo.c > diff --git a/src/xdemos

[Mesa-dev] glxinfo proposed change

2013-01-07 Thread Jorge Ramirez Ortiz, HCL Europe
Hi all, Does this patch make sense? glVersion can be NULL and not having the changes below could cause a SIGSEGV [jramirez@calypso-2 mesa-demos.git (tmp *)]$ git diff src/xdemos/glxinfo.c diff --git a/src/xdemos/glxinfo.c b/src/xdemos/glxinfo.c index aa6430d..97b6539 100644 --- a/src/xdemos/glxi