Re: [Mesa-dev] RFC Remove _mesa_problem() from paths where execution path is not altered

2017-05-15 Thread Samuel Pitoiset
I'm personally fine with this. I have never hit this _mesa_problem() path, or maybe one time but it was me doing something dumb. Except a comment on patch 1, this series is: Reviewed-by: Samuel Pitoiset On 05/09/2017 05:04 AM, Timothy Arceri wrote: There is still more that can be removed I j

Re: [Mesa-dev] RFC Remove _mesa_problem() from paths where execution path is not altered

2017-05-14 Thread Timothy Arceri
Ping! On 09/05/17 13:04, Timothy Arceri wrote: There is still more that can be removed I just though I'd get comments before going too far. This is a follow on from [1][2]. Besides patch 1 we are just replacing it with an unreachable() when the path doesn't try to work around the problem i.e r

[Mesa-dev] RFC Remove _mesa_problem() from paths where execution path is not altered

2017-05-08 Thread Timothy Arceri
There is still more that can be removed I just though I'd get comments before going too far. This is a follow on from [1][2]. Besides patch 1 we are just replacing it with an unreachable() when the path doesn't try to work around the problem i.e return early. _mesa_problem() is still useful in s