Re: [Mesa-dev] RFC: Haswell resource streamer/hw-generated binding tables (v2)

2013-10-31 Thread Abdiel Janulgue
On Thursday, October 10, 2013 01:04:08 PM Eric Anholt wrote: > > My basic comment on resource streamer: We need performance data showing > that it is a win before we commit it. I'm not planning on reviewing the > changes until we get that data. Okay, I revisited the series, did some additional o

Re: [Mesa-dev] RFC: Haswell resource streamer/hw-generated binding tables (v2)

2013-10-16 Thread Eric Anholt
Abdiel Janulgue writes: > On Tuesday, October 15, 2013 10:29:16 AM Eric Anholt wrote: >> Abdiel Janulgue writes: >> > On Monday, October 14, 2013 10:50:24 AM Eric Anholt wrote: >> >> Abdiel Janulgue writes: >> >> > One optimization idea that I had in mind a few months ago was to find a >> >> >

Re: [Mesa-dev] RFC: Haswell resource streamer/hw-generated binding tables (v2)

2013-10-16 Thread Abdiel Janulgue
On Tuesday, October 15, 2013 10:29:16 AM Eric Anholt wrote: > Abdiel Janulgue writes: > > On Monday, October 14, 2013 10:50:24 AM Eric Anholt wrote: > >> Abdiel Janulgue writes: > >> > One optimization idea that I had in mind a few months ago was to find a > >> > way to reduce emission of surface

Re: [Mesa-dev] RFC: Haswell resource streamer/hw-generated binding tables (v2)

2013-10-15 Thread Eric Anholt
Abdiel Janulgue writes: > On Monday, October 14, 2013 10:50:24 AM Eric Anholt wrote: >> Abdiel Janulgue writes: >> > >> > One optimization idea that I had in mind a few months ago was to find a >> > way to reduce emission of surface state objects. Currently, we rebuild >> > surface states every

Re: [Mesa-dev] RFC: Haswell resource streamer/hw-generated binding tables (v2)

2013-10-15 Thread Abdiel Janulgue
On Monday, October 14, 2013 10:50:24 AM Eric Anholt wrote: > Abdiel Janulgue writes: > > > > One optimization idea that I had in mind a few months ago was to find a > > way to reduce emission of surface state objects. Currently, we rebuild > > surface states every time we generate binding tables.

Re: [Mesa-dev] RFC: Haswell resource streamer/hw-generated binding tables (v2)

2013-10-14 Thread Eric Anholt
Abdiel Janulgue writes: > On Friday, October 11, 2013 11:39:53 AM Eric Anholt wrote: >> As a general rule, we don't land code whose purpose is performance >> improvement if it doesn't actually improve performance. If more work is >> needed to make it actually improve performance, then we wait un

Re: [Mesa-dev] RFC: Haswell resource streamer/hw-generated binding tables (v2)

2013-10-14 Thread Abdiel Janulgue
On Friday, October 11, 2013 11:39:53 AM Eric Anholt wrote: > As a general rule, we don't land code whose purpose is performance > improvement if it doesn't actually improve performance. If more work is > needed to make it actually improve performance, then we wait until then. > > As I understand

Re: [Mesa-dev] RFC: Haswell resource streamer/hw-generated binding tables (v2)

2013-10-14 Thread Abdiel Janulgue
On Friday, October 11, 2013 11:39:53 AM Eric Anholt wrote: > > As I understand it, the thing that you think will make this eventually > actually improve performance is state flagging that indicates which > individual surfaces need updating. Since that should improve > performance even in the non

Re: [Mesa-dev] RFC: Haswell resource streamer/hw-generated binding tables (v2)

2013-10-11 Thread Eric Anholt
Abdiel Janulgue writes: > On Thursday, October 10, 2013 01:04:08 PM Eric Anholt wrote: >> >> My basic comment on resource streamer: We need performance data showing >> that it is a win before we commit it. I'm not planning on reviewing the >> changes until we get that data. > > At it's current

Re: [Mesa-dev] RFC: Haswell resource streamer/hw-generated binding tables (v2)

2013-10-10 Thread Abdiel Janulgue
On Thursday, October 10, 2013 01:04:08 PM Eric Anholt wrote: > > My basic comment on resource streamer: We need performance data showing > that it is a win before we commit it. I'm not planning on reviewing the > changes until we get that data. At it's current form, I don't expect that much perf

Re: [Mesa-dev] RFC: Haswell resource streamer/hw-generated binding tables (v2)

2013-10-10 Thread Eric Anholt
Abdiel Janulgue writes: > Prerequisites: > > - Kernel patches: [1] > (do 'make headers_install' and update libdrm headers after compiling > the kernel) > - Mesa patch: [2] > > This is an update from my previous RFC patches [3]. Most notable > change is that the resource streamer is a

Re: [Mesa-dev] RFC: Haswell resource streamer/hw-generated binding tables (v2)

2013-10-08 Thread Abdiel Janulgue
On Wednesday, October 09, 2013 12:41:37 AM Abdiel Janulgue wrote: > Prerequisites: > > - Kernel patches: [1] > (do 'make headers_install' and update libdrm headers after compiling > the kernel) > - Mesa patch: [2] > Series lives on http://cgit.freedesktop.org/~abj/mesa/ mesa_rs branc

[Mesa-dev] RFC: Haswell resource streamer/hw-generated binding tables (v2)

2013-10-08 Thread Abdiel Janulgue
Prerequisites: - Kernel patches: [1] (do 'make headers_install' and update libdrm headers after compiling the kernel) - Mesa patch: [2] This is an update from my previous RFC patches [3]. Most notable change is that the resource streamer is an experimental feature disabled by defaul