Thanks for reviewing the patch. I will make changes and send v2 accordingly.
On 08/20/2018 11:34 AM, Matt Turner wrote:
> On Thu, Aug 16, 2018 at 1:51 PM Sagar Ghuge wrote:
>>
>> Adds a new i965 instruction disassemble tool
>
> This looks very good. A few comments about the structure inline.
>
On Thu, Aug 16, 2018 at 1:51 PM Sagar Ghuge wrote:
>
> Adds a new i965 instruction disassemble tool
This looks very good. A few comments about the structure inline.
> Signed-off-by: Sagar Ghuge
> ---
> src/intel/Makefile.tools.am | 15 +++
> src/intel/tools/i965_disasm.c | 202 +
Adds a new i965 instruction disassemble tool
Signed-off-by: Sagar Ghuge
---
src/intel/Makefile.tools.am | 15 +++
src/intel/tools/i965_disasm.c | 202 ++
src/intel/tools/i965_disasm.h | 46
src/intel/tools/meson.build | 11 ++
4 files changed, 274
