Re: [Mesa-dev] [PATCH] glsl: initialise pointer to NULL

2016-08-28 Thread Kenneth Graunke
On Monday, August 29, 2016 12:03:47 PM PDT Timothy Arceri wrote: > Fixes uninitialised warning and covery defect. > > Cc: Kenneth Graunke > --- > src/compiler/glsl/lower_blend_equation_advanced.cpp | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/compiler/glsl/lower_

[Mesa-dev] [PATCH] glsl: initialise pointer to NULL

2016-08-28 Thread Timothy Arceri
Fixes uninitialised warning and covery defect. Cc: Kenneth Graunke --- src/compiler/glsl/lower_blend_equation_advanced.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/compiler/glsl/lower_blend_equation_advanced.cpp b/src/compiler/glsl/lower_blend_equation_advanced.cp

Re: [Mesa-dev] [PATCH] glsl: initialise pointer to NULL

2016-06-06 Thread Iago Toral
On Mon, 2016-06-06 at 16:45 +0200, Jakob Sinclair wrote: > On 2016-06-06 15:48, Iago Toral wrote: > > Reviewed-by: Iago Toral Quiroga > > > > I don't have push access so I would be very happy if you could push this > patch for me. Thanks! Sure, I have just pushed it. Iago ___

Re: [Mesa-dev] [PATCH] glsl: initialise pointer to NULL

2016-06-06 Thread Jakob Sinclair
On 2016-06-06 15:48, Iago Toral wrote: Reviewed-by: Iago Toral Quiroga I don't have push access so I would be very happy if you could push this patch for me. Thanks! -- Mvh Jakob Sinclair On Sat, 2016-06-04 at 01:09 +0200, Jakob Sinclair wrote: Could cause issues if you tried to read fro

Re: [Mesa-dev] [PATCH] glsl: initialise pointer to NULL

2016-06-06 Thread Iago Toral
Reviewed-by: Iago Toral Quiroga On Sat, 2016-06-04 at 01:09 +0200, Jakob Sinclair wrote: > Could cause issues if you tried to read from an uninitialised pointer. > This just initalises the pointer to null to avoid that being a problem. > Discovered by Coverity. > > CID: 1343616 > > Signed-off-b

[Mesa-dev] [PATCH] glsl: initialise pointer to NULL

2016-06-03 Thread Jakob Sinclair
Could cause issues if you tried to read from an uninitialised pointer. This just initalises the pointer to null to avoid that being a problem. Discovered by Coverity. CID: 1343616 Signed-off-by: Jakob Sinclair --- src/compiler/glsl/glsl_parser_extras.cpp | 1 + 1 file changed, 1 insertion(+) d