Re: [Mesa-dev] [PATCH] clover: fix llvm 3.5 build error

2015-08-21 Thread Francisco Jerez
"Serge Martin (EdB)" writes: > On Wednesday 19 August 2015 11:56:08 Zoltan Gilian wrote: >> There is no MDOperand in llvm 3.5. >> >> v2: Check if kernel metadata is present to avoid crash (EdB). >> v3: Second attempt to avoid crash: switch off metadata query for llvm < 3.6. > > Since the change

Re: [Mesa-dev] [PATCH] clover: fix llvm 3.5 build error

2015-08-21 Thread Serge Martin (EdB)
On Wednesday 19 August 2015 11:56:08 Zoltan Gilian wrote: > There is no MDOperand in llvm 3.5. > > v2: Check if kernel metadata is present to avoid crash (EdB). > v3: Second attempt to avoid crash: switch off metadata query for llvm < 3.6. Since the change you made for image support won't be back

[Mesa-dev] [PATCH] clover: fix llvm 3.5 build error

2015-08-19 Thread Zoltan Gilian
There is no MDOperand in llvm 3.5. v2: Check if kernel metadata is present to avoid crash (EdB). v3: Second attempt to avoid crash: switch off metadata query for llvm < 3.6. --- .../state_trackers/clover/llvm/invocation.cpp | 33 ++ 1 file changed, 21 insertions(+), 12 de

Re: [Mesa-dev] [PATCH] clover: fix llvm 3.5 build error

2015-08-16 Thread Serge Martin (EdB)
On Sunday 09 August 2015 11:52:13 orome wrote: > On Sun, 2015-08-09 at 15:39 +0200, Zoltan Gilian wrote: > > There is no MDOperand in llvm 3.5. > > > > v2: Check if kernel metadata is present to avoid crash (EdB). > > still builds for me. Sadly, it's still crashing for me. auto kernel_node = ge

Re: [Mesa-dev] [PATCH] clover: fix llvm 3.5 build error

2015-08-09 Thread orome
On Sun, 2015-08-09 at 15:39 +0200, Zoltan Gilian wrote: > There is no MDOperand in llvm 3.5. > > v2: Check if kernel metadata is present to avoid crash (EdB). still builds for me. thanks, Jan > --- > .../state_trackers/clover/llvm/invocation.cpp | 22 > +- > 1 file ch

[Mesa-dev] [PATCH] clover: fix llvm 3.5 build error

2015-08-09 Thread Zoltan Gilian
There is no MDOperand in llvm 3.5. v2: Check if kernel metadata is present to avoid crash (EdB). --- .../state_trackers/clover/llvm/invocation.cpp | 22 +- 1 file changed, 13 insertions(+), 9 deletions(-) diff --git a/src/gallium/state_trackers/clover/llvm/invocation.cpp

Re: [Mesa-dev] [PATCH] clover: fix llvm 3.5 build error

2015-08-05 Thread Jan Vesely
On Wed, 2015-08-05 at 12:47 +0200, Zoltán Gilián wrote: > > thanks, this fixes the build for me. > > Should I commit this marking you as reviewer? sorry, I can't do a proper review or test. I won't have access to my dev box until december, and the machine that hit the failure only builds the stat

Re: [Mesa-dev] [PATCH] clover: fix llvm 3.5 build error

2015-08-05 Thread Zoltán Gilián
> Also I've > noticed that you've pushed a few patches [1][2][3][4] without > Reviewed-by tag. Please stop. Yes, I've already been told to include patch versions and reviewer. I'm sorry, I'll try not to screw it up again. On Wed, Aug 5, 2015 at 1:55 PM, Francisco Jerez wrote: > Zoltán Gilián w

Re: [Mesa-dev] [PATCH] clover: fix llvm 3.5 build error

2015-08-05 Thread Francisco Jerez
Zoltán Gilián writes: >> thanks, this fixes the build for me. > > Should I commit this marking you as reviewer? "fixes the build for me" hardly qualifies as a Tested-by. Also I've noticed that you've pushed a few patches [1][2][3][4] without Reviewed-by tag. Please stop. [1] d2cd2c69b20fcb3f1

Re: [Mesa-dev] [PATCH] clover: fix llvm 3.5 build error

2015-08-05 Thread Zoltán Gilián
> thanks, this fixes the build for me. Should I commit this marking you as reviewer? On Wed, Aug 5, 2015 at 5:21 AM, Jan Vesely wrote: > On Tue, 2015-08-04 at 22:40 +0200, Zoltan Gilian wrote: >> There is no MDOperand in llvm 3.5. > > thanks, this fixes the build for me. > > jan > >> --- >> src

Re: [Mesa-dev] [PATCH] clover: fix llvm 3.5 build error

2015-08-04 Thread Jan Vesely
On Tue, 2015-08-04 at 22:40 +0200, Zoltan Gilian wrote: > There is no MDOperand in llvm 3.5. thanks, this fixes the build for me. jan > --- > src/gallium/state_trackers/clover/llvm/invocation.cpp | 19 > ++- > 1 file changed, 10 insertions(+), 9 deletions(-) > > diff --git a/s

[Mesa-dev] [PATCH] clover: fix llvm 3.5 build error

2015-08-04 Thread Zoltan Gilian
There is no MDOperand in llvm 3.5. --- src/gallium/state_trackers/clover/llvm/invocation.cpp | 19 ++- 1 file changed, 10 insertions(+), 9 deletions(-) diff --git a/src/gallium/state_trackers/clover/llvm/invocation.cpp b/src/gallium/state_trackers/clover/llvm/invocation.cpp index