Re: [Mesa-dev] [RFC PATCH 52/65] radeonsi: implement ARB_bindless_texture

2017-05-25 Thread Marek Olšák
On Thu, May 25, 2017 at 10:49 PM, Samuel Pitoiset wrote: > > > On 05/25/2017 10:45 PM, Marek Olšák wrote: >> >> On Thu, May 25, 2017 at 9:56 PM, Samuel Pitoiset >> wrote: >>> >>> >>> >>> On 05/25/2017 07:58 PM, Marek Olšák wrote: Hi, 1) Patches 48 and 52 are missing code

Re: [Mesa-dev] [RFC PATCH 52/65] radeonsi: implement ARB_bindless_texture

2017-05-25 Thread Samuel Pitoiset
On 05/25/2017 10:45 PM, Marek Olšák wrote: On Thu, May 25, 2017 at 9:56 PM, Samuel Pitoiset wrote: On 05/25/2017 07:58 PM, Marek Olšák wrote: Hi, 1) Patches 48 and 52 are missing code comments. I'd like to see code comments about how things work and why it was designed like that. Okay

Re: [Mesa-dev] [RFC PATCH 52/65] radeonsi: implement ARB_bindless_texture

2017-05-25 Thread Marek Olšák
On Thu, May 25, 2017 at 9:56 PM, Samuel Pitoiset wrote: > > > On 05/25/2017 07:58 PM, Marek Olšák wrote: >> >> Hi, >> >> 1) Patches 48 and 52 are missing code comments. I'd like to see code >> comments about how things work and why it was designed like that. > > > Okay, I will add some. > >> >> 2)

Re: [Mesa-dev] [RFC PATCH 52/65] radeonsi: implement ARB_bindless_texture

2017-05-25 Thread Samuel Pitoiset
On 05/25/2017 07:58 PM, Marek Olšák wrote: Hi, 1) Patches 48 and 52 are missing code comments. I'd like to see code comments about how things work and why it was designed like that. Okay, I will add some. 2) There is a lot of code duplication regarding managing the resizable arrays. I'd l

Re: [Mesa-dev] [RFC PATCH 52/65] radeonsi: implement ARB_bindless_texture

2017-05-25 Thread Marek Olšák
Hi, 1) Patches 48 and 52 are missing code comments. I'd like to see code comments about how things work and why it was designed like that. 2) There is a lot of code duplication regarding managing the resizable arrays. I'd like to see some util module used here, e.g. u_vector or you can add new ma

Re: [Mesa-dev] [RFC PATCH 52/65] radeonsi: implement ARB_bindless_texture

2017-05-24 Thread Samuel Pitoiset
On 05/24/2017 01:25 PM, Marek Olšák wrote: On Fri, May 19, 2017 at 6:52 PM, Samuel Pitoiset wrote: This implements the Gallium interface. Decompression of resident textures/images will follow in the next patches. Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/radeonsi/si_descripto

Re: [Mesa-dev] [RFC PATCH 52/65] radeonsi: implement ARB_bindless_texture

2017-05-24 Thread Marek Olšák
On Fri, May 19, 2017 at 6:52 PM, Samuel Pitoiset wrote: > This implements the Gallium interface. Decompression of resident > textures/images will follow in the next patches. > > Signed-off-by: Samuel Pitoiset > --- > src/gallium/drivers/radeonsi/si_descriptors.c | 340 >

[Mesa-dev] [RFC PATCH 52/65] radeonsi: implement ARB_bindless_texture

2017-05-19 Thread Samuel Pitoiset
This implements the Gallium interface. Decompression of resident textures/images will follow in the next patches. Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/radeonsi/si_descriptors.c | 340 ++ src/gallium/drivers/radeonsi/si_pipe.c| 12 + src/gallium/